From: Richard Hansen <rhansen@rhansen.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56210@debbugs.gnu.org, larsi@gnus.org
Subject: bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions
Date: Wed, 29 Jun 2022 19:17:29 -0400 [thread overview]
Message-ID: <07d8210a-40af-2c46-1a7f-a3bd9f5e4285@rhansen.org> (raw)
In-Reply-To: <831qva82sz.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 3205 bytes --]
On 2022-06-27 12:54, Eli Zaretskii wrote:
>> I changed the test to switch to the temporary buffer in the
>> selected window and it now reliably inserts "x" into the temporary
>> buffer. It still doesn't run the `after-change-functions' hook,
>> however. Updated test code:
>>
>> ;; -*- lexical-binding: t; -*-
>> (require 'ert)
>> (require 'ert-x)
>> (defvar-local acf 0)
>> (defun acf (&rest _) (setq-local acf (1+ acf)))
>> (ert-deftest test ()
>> (ert-with-test-buffer ()
>> (let ((b (current-buffer)))
>> (save-window-excursion
>> (with-current-buffer-window b
>> `(display-buffer-below-selected
>> (body-function
>> . ,(lambda (window)
>> (select-window window t)
>> (should (eq (current-buffer) b))
>> (setq-local acf 0)
>> ;; Note that LOCAL is t:
>> (add-hook 'after-change-functions #'acf nil t)
>> (should (memq #'acf after-change-functions))
>> (execute-kbd-macro (kbd "x"))
>> (should (equal (buffer-string) "x"))
>> ;; The above checks pass, this check fails:
>> (should (equal acf 1)))))
>> nil)))))
>
> Your test calls with-current-buffer-window, which calls
> temp-buffer-window-setup, which inhibits modification hooks:
I looked into this a bit more. It turns out that `inhibit-modification-hooks' is actually nil in the body of `with-current-buffer-window', as expected. It is t in the above test code because of `display-buffer-below-selected', which calls `window--display-buffer', which does the following:
(when (functionp (cdr (assq 'body-function alist)))
(let ((inhibit-read-only t)
(inhibit-modification-hooks t))
(funcall (cdr (assq 'body-function alist)) window)))
The `body-function' action alist entry was added in Emacs 28.1 by commit 3273e2ace78 [1] for bug#39822 [2]. Presumably the modification hooks are inhibited during the execution of `body-function' because `body-function' was added to replace the (now-deprecated) `with-displayed-buffer-window' macro, which inhibits them. The `with-displayed-buffer-window' macro has inhibited them ever since the macro was first added to Emacs 25.1 by commit f0f70ec0bc5 [3] for bug#17809 [4].
I'm guessing that `body-function' is only intended for initial buffer set-up, thus modification hooks are inhibited. However, the body of `with-current-buffer-window' is also only intended for initial buffer set-up (it actually runs before `body-function' and before the buffer is displayed), so the inconsistency is unexpected and awkward. Either both should inhibit the modification hooks, or neither should.
[1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3273e2ace788a58bef77cef936021d151815ea94
[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39822
[3] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f0f70ec0bc55e452ea29b5cf3f532740966b0192
[4] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17809
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-06-29 23:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 6:21 bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions Richard Hansen
2022-06-25 11:51 ` Lars Ingebrigtsen
2022-06-25 18:06 ` Richard Hansen
2022-06-25 18:56 ` Eli Zaretskii
2022-06-25 20:34 ` Richard Hansen
2022-06-26 8:10 ` Eli Zaretskii
2022-06-27 3:21 ` Richard Hansen
2022-06-27 7:50 ` Lars Ingebrigtsen
2022-06-27 16:52 ` Richard Hansen
2022-06-27 16:54 ` Eli Zaretskii
2022-06-27 17:07 ` Richard Hansen
2022-06-27 17:17 ` Eli Zaretskii
2022-06-27 17:22 ` Richard Hansen
2022-06-28 11:31 ` Lars Ingebrigtsen
2022-06-28 12:20 ` Eli Zaretskii
2022-06-28 12:26 ` Lars Ingebrigtsen
2022-06-27 17:23 ` Richard Hansen
2022-06-29 23:17 ` Richard Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07d8210a-40af-2c46-1a7f-a3bd9f5e4285@rhansen.org \
--to=rhansen@rhansen.org \
--cc=56210@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).