unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>, "Ludovic Courtès" <ludo@gnu.org>
Cc: Tobias Kortkamp <tobias.kortkamp@gmail.com>, guix-devel@gnu.org
Subject: Re: Dealing with upstream issues
Date: Tue, 28 Jun 2022 14:21:44 +0200	[thread overview]
Message-ID: <cdea9d182daa9bb0df7fb1291372fc515a90db4a.camel@telenet.be> (raw)
In-Reply-To: <865yklf3vq.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

zimoun schreef op di 28-06-2022 om 13:01 [+0200]:
> Well, from my understanding, the question is: should a perfectly working
> and fine submission be delayed because unrelated-to-Guix issues are in
> upstream code?

This is not the question.  The dispute is about:

Maxime Devos: https://issues.guix.gnu.org/55541#3
> AFAICT the issues have not been reported upstream yet, so I don't
> think we can close this entry on debbugs yet. 

zimoun:
> Ludo said these unrelated-to-Guix issues are not blocker, from my
> understandings.  And I agree.  Do you disagree?

I agree too.  What I disagree with, is ignoring the bug.  The blocker
for me is: appropriate parties need to be at least informed of bug if
it isn't fixed.

> You are commenting on “standard” which somehow asks about explicit
> criteria.  And, you are implicitly commenting on blocking while
> issues from upstream are not fixed.  Instead of trying to deduce
> myself (and probably the wrong way), could you please explicitly
> write down your arguments?

Reviewer noticed a $bug.  This kind of $bug has two accepted and
standard methods for addressing it:

 (1) fix it (by replacing the configure script or patching it or
     sufficient substitute*).
     (a) in Guix (often work-around-ish, though often a work-around is
         sufficient for these kind of cross-compilation problems)
     (b) upstream (more work, sometimes more fulfilling, sometimes not 
         worth it
 (2) report it upstream (because it's more complicated than a simple
     'substitute*'.

Why?  It's a bug, needs to be fixed somehow, and for (2): we can't
solve everything ourselves.

What happened:

  Committer pushed changed, ignoring (1) and (2).

/me: What?  Why ignore the bugs?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-06-28 12:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6d31ff958ec0c75cbba8324a275315d195a54902.1653045472.git.tobias.kortkamp@gmail.com>
     [not found] ` <87sfntu6ft.fsf@gnu.org>
     [not found]   ` <b6d482002f7773e65e02dbbbf354e1c0178b823a.camel@telenet.be>
2022-06-27 10:10     ` Dealing with upstream issues Ludovic Courtès
2022-06-27 10:30       ` Maxime Devos
2022-06-27 10:37         ` Maxime Devos
2022-06-27 12:32           ` zimoun
2022-06-27 14:20             ` Maxime Devos
2022-06-27 15:06               ` zimoun
2022-06-27 15:41                 ` Maxime Devos
2022-06-28 11:01         ` zimoun
2022-06-28 12:21           ` Maxime Devos [this message]
2022-06-28 16:21             ` zimoun
2022-06-28 16:47               ` Maxime Devos
2022-06-28 17:36                 ` zimoun
2022-06-28 20:03                   ` Maxime Devos
2022-06-28 12:22           ` Maxime Devos
2022-06-28 12:31           ` Maxime Devos
2022-06-28 16:25             ` zimoun
2022-06-28 16:47               ` Maxime Devos
2022-06-29  6:07               ` bokr
2022-06-29  7:29                 ` Missing tags in Debbugs? zimoun
2022-06-29 13:45                   ` Bengt Richter
2022-06-30 11:53         ` Dealing with upstream issues Ludovic Courtès
2022-06-27 12:53       ` zimoun
2022-06-27 14:32         ` Maxime Devos
2022-06-27 15:23           ` zimoun
2022-06-27 15:47             ` Maxime Devos
2022-06-27 16:03             ` Maxime Devos
2022-06-27 16:14             ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdea9d182daa9bb0df7fb1291372fc515a90db4a.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    --cc=tobias.kortkamp@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).