From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>, Guix Devel <guix-devel@gnu.org>
Subject: Re: Sanitizer of record fields?
Date: Thu, 8 Sep 2022 11:32:14 +0200 [thread overview]
Message-ID: <be4034ae-86c6-ff41-3f7d-14d421017ece@telenet.be> (raw)
In-Reply-To: <868rmuxpnw.fsf@gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1294 bytes --]
On 08-09-2022 09:59, zimoun wrote:
> We could add a lint checker. Is it a “good” idea?
We already have one, 'check-license'.
> Because lint is not always applied, a check should be done when running
> ’make’ or a special target. Is it a “good” idea?
I suppose it is a possibility, but it adds a few seconds to every 'make':
time ./pre-inst-env guix lint --checkers=license
make all-recursive [...]
gnu/packages/qt.scm:1373:13: qtshadertools@6.3.1: invalid license field
gnu/packages/tex.scm:11816:2: texlive-setspace@59745: invalid
real 0m1,492s
user 0m3,331s
sys 0m0,214s
As such, here's an alternative proposal: instead of checking it at
compile-time
(which is currently impossible), let's check them at runtime, with a
field sanitizer.
Given that, unless I'm mistaken, build-aux/compile-all.scm loads every Guix
module anyway, and given that 'license' isn't thunked or delayed, 'the
runtime
check' would also a compile-time check.
(Performance impact on "guix ..." commands would need to be checked.)
Alternatively, some error checking could be added to the website code,
to indicate
which package and which is wrong. Or maybe the website code can run the
'license'
linter first.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-08 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 7:59 Sanitizer of record fields? zimoun
2022-09-08 9:32 ` Maxime Devos [this message]
2022-09-08 11:16 ` zimoun
2022-09-08 11:33 ` Maxime Devos
2022-09-08 11:35 ` bokr
2022-09-08 11:43 ` Maxime Devos
2022-09-08 11:44 ` Maxime Devos
2022-09-08 12:50 ` zimoun
2022-10-01 16:35 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4034ae-86c6-ff41-3f7d-14d421017ece@telenet.be \
--to=maximedevos@telenet.be \
--cc=guix-devel@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).