unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Guix Devel <guix-devel@gnu.org>
Subject: Sanitizer of record fields?
Date: Thu, 08 Sep 2022 09:59:15 +0200	[thread overview]
Message-ID: <868rmuxpnw.fsf@gmail.com> (raw)

Hi,

The website is currently failing [1] to build because a typo in some
package declaration.  The error message is not very helpful,

        srfi/srfi-1.scm:241:2: In procedure map:
        In procedure map: Wrong type argument: "https://www.qt.io/"
        building pages in '/tmp/gnu.org/software/guix'...

and it was not straightforward to find the issue.  Using some ’pk’ in
the website builder restricted the origin of the failure; but still.
Thanks to Florian, they found this commit [2] introducing the package
qtshadertools where a field is unexpected,

        +    (license (package-home-page qtbase))))

and boum!

It seems impossible to detect that typo at compile-time because fields
do not have a specific type (except by convention).  Therefore, how can
we detect such typo?

We could add a lint checker.  Is it a “good” idea?

Because lint is not always applied, a check should be done when running
’make’ or a special target.  Is it a “good” idea?


1: <http://issues.guix.gnu.org/issue/57581>
2: <https://git.savannah.gnu.org/cgit/guix.git/diff/?id=1d65ff8fdeb20cc2db956093f0ecb1f3f72afc0e>


Cheers,
simon



             reply	other threads:[~2022-09-08  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  7:59 zimoun [this message]
2022-09-08  9:32 ` Sanitizer of record fields? Maxime Devos
2022-09-08 11:16   ` zimoun
2022-09-08 11:33     ` Maxime Devos
2022-09-08 11:35 ` bokr
2022-09-08 11:43   ` Maxime Devos
2022-09-08 11:44   ` Maxime Devos
2022-09-08 12:50   ` zimoun
2022-10-01 16:35 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868rmuxpnw.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).