unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Greg Hogan <code@greghogan.com>, 60042@debbugs.gnu.org
Subject: [bug#60042] Julia dependency on Git
Date: Fri, 30 Dec 2022 14:15:29 +0100	[thread overview]
Message-ID: <87bknlkp72.fsf@gmail.com> (raw)
In-Reply-To: <875ye1znjz.fsf_-_@gnu.org>

Hi Ludo,

On Sat, 24 Dec 2022 at 00:51, Ludovic Courtès <ludo@gnu.org> wrote:

> Oh right.  I found that ‘julia-documenter’ depends on ‘git-minimal’; I
> changed it to depend on ‘git-minimal/fixed’.  (The purpose of ‘/fixed’
> variants, such as ‘guile-3.0/fixed’, is to avoid rebuilds of unrelated
> sub-graphs.)  A few other packages were in a similar situation:

Two things are really hard in computer science: naming and cache
invalidation. :-)

Here, the suffix /fixed is confusing because it is used for the both
cases:

 1) You use fixed to describe something which stays the same and does not
    or cannot vary.
 2) If you fix a problem or a bad situation, you deal with it and make it
    satisfactory.


For instance, it is the meaning #2,

--8<---------------cut here---------------start------------->8---
(define gnupg/fixed
  (package
    (inherit gnupg)
    (source (origin
              (inherit (package-source gnupg))
              (patches
                (append (origin-patches (package-source gnupg))
                        (search-patches "gnupg-CVE-2022-34903.patch")))))))
--8<---------------cut here---------------end--------------->8---

therefore, I expect that the package gnupg is replaced (grafted).  And
indeed,

--8<---------------cut here---------------start------------->8---
(define-public gnupg
  (package
    (name "gnupg")
    ;; Note: The 2.2.X releases are Long Term Support (LTS), so stick to it
    ;; for our stable 'gnupg'.
    ;; Note2: 2.2.33 currently suffers from regressions, so do not update to it
    ;; (see: https://dev.gnupg.org/T5742).
    (version "2.2.32")
    (replacement gnupg/fixed)
--8<---------------cut here---------------end--------------->8---


Well, the situation looks like:

version-control.scm:673:(define-public git-minimal/fixed  #1 stable
onc-rpc.scm:91:         (define libtirpc/fixed            #2
gnupg.scm:257:          (define libksba/fixed             #2
gnupg.scm:369:          (define gnupg/fixed               #2
linux.scm:2164:         (define-public util-linux/fixed   #2
linux.scm:7674:         (define-public libnftnl/fixed     #1 stable
tls.scm:601:            (define openssl/fixed             #2
samba.scm:295:          (define-public samba/fixed        #1 stable
xml.scm:159:            (define expat/fixed               #2
compression.scm:1890:   (define unzip/fixed               #2
guile.scm:424:          (define-public guile-3.0/fixed    #1 stable


Therefore, to avoid the confusion I would suggest to use /pinned instead
of /fixed for this stable meaning.  Hence, 4 renaming.  WDYT?


Cheers,
simon




  reply	other threads:[~2022-12-30 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 18:40 [bug#60042] [PATCH] gnu: git: Update to 2.39.0 Greg Hogan
2022-12-15 11:35 ` zimoun
2022-12-15 18:55   ` bug#60042: " Greg Hogan
2022-12-20 14:52   ` [bug#60042] " Ludovic Courtès
2022-12-20 15:38     ` Simon Tournier
2022-12-23 23:51       ` [bug#60042] Julia dependency on Git Ludovic Courtès
2022-12-30 13:15         ` zimoun [this message]
2023-01-03 17:59           ` Leo Famulari
2023-01-06 22:55           ` [bug#60042] What to call pinned package versions Ludovic Courtès
2023-01-09 10:32             ` Simon Tournier
2023-01-11 13:19               ` Simon Tournier
2023-01-11 17:27                 ` Ludovic Courtès
2023-01-11 17:26               ` Ludovic Courtès
2023-01-26 16:45                 ` zimoun
2022-12-20 16:38     ` [bug#60042] [PATCH] gnu: git: Update to 2.39.0 Greg Hogan
2022-12-25 16:18       ` Ludovic Courtès
2023-02-17 15:55         ` [bug#60042] open branches with target merge dates (was Re: [bug#60042] [PATCH] gnu: git: Update to 2.39.0.) Simon Tournier
2023-02-20 11:02           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bknlkp72.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=60042@debbugs.gnu.org \
    --cc=code@greghogan.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).