unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Greg Hogan <code@greghogan.com>, 60042@debbugs.gnu.org
Subject: [bug#60042] What to call pinned package versions
Date: Wed, 11 Jan 2023 14:19:36 +0100	[thread overview]
Message-ID: <86h6wx5huf.fsf@gmail.com> (raw)
In-Reply-To: <87h6x0yp57.fsf@gmail.com>

Hi,

On Mon, 09 Jan 2023 at 11:32, Simon Tournier <zimon.toutoune@gmail.com> wrote:

>  + Option a.
>
> version-control.scm:673:(define-public git-minimal/fixed -> git-minimal/pinned

[...]


>  + Option b.
>
> onc-rpc.scm:91:         (define libtirpc/fixed          -> libtirpc/grafted

[...]


>  + Option c. = option a. + option b. (remove reference to /fixed)
>
>
> From my point of view, option a. is the less “disruptive” because for
> instance we use the term “Fixes“ in commit message when a bug is indeed
> fixed.

Well, we also have another option:

   + Option d.: the version in the symbol; as in htslib-1.14.

   Considering the initial example,

     git-minimal/fixed    ->    git-minimal-2.33.1


This option d. appears to me the best:

 + it avoids ambiguity.

 + it is explicit – no need to grep for finding which version
 git-minimal/pinned refers to when reading Julia package recipes.

 + we are already doing that for multi-version packages.

Moreover, a ’default’ property could be also assigned to default
version (here the package defined by the symbol git-minimal).  And it
would allow to have less surprise when some multi versions package are
exported or incorrectly hidden.  See #60200 [1].

WDYT?

If we agree on Option d., then I could prepare a patch set and document
in the manual.  Let me know. :-)

1: <http://issues.guix.gnu.org/msgid/Y6LQs9+in964glaz@noor.fritz.box>


Cheers,
simon




  reply	other threads:[~2023-01-11 16:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 18:40 [bug#60042] [PATCH] gnu: git: Update to 2.39.0 Greg Hogan
2022-12-15 11:35 ` zimoun
2022-12-15 18:55   ` bug#60042: " Greg Hogan
2022-12-20 14:52   ` [bug#60042] " Ludovic Courtès
2022-12-20 15:38     ` Simon Tournier
2022-12-23 23:51       ` [bug#60042] Julia dependency on Git Ludovic Courtès
2022-12-30 13:15         ` zimoun
2023-01-03 17:59           ` Leo Famulari
2023-01-06 22:55           ` [bug#60042] What to call pinned package versions Ludovic Courtès
2023-01-09 10:32             ` Simon Tournier
2023-01-11 13:19               ` Simon Tournier [this message]
2023-01-11 17:27                 ` Ludovic Courtès
2023-01-11 17:26               ` Ludovic Courtès
2023-01-26 16:45                 ` zimoun
2022-12-20 16:38     ` [bug#60042] [PATCH] gnu: git: Update to 2.39.0 Greg Hogan
2022-12-25 16:18       ` Ludovic Courtès
2023-02-17 15:55         ` [bug#60042] open branches with target merge dates (was Re: [bug#60042] [PATCH] gnu: git: Update to 2.39.0.) Simon Tournier
2023-02-20 11:02           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86h6wx5huf.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=60042@debbugs.gnu.org \
    --cc=code@greghogan.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).