unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Florian <florhizome@posteo.net>
To: zimoun <zimon.toutoune@gmail.com>, <60013@debbugs.gnu.org>
Subject: [bug#60013] [PATCH 1/3] gnu: Add libmodule
Date: Tue, 20 Dec 2022 16:33:49 +0000	[thread overview]
Message-ID: <871qounifm.fsf@posteo.net> (raw)
In-Reply-To: <86pmckdhts.fsf@gmail.com>

On 2022-12-15, 12:31 +0100, zimoun <zimon.toutoune@gmail.com> wrote:

> Well, I understand your workflow, I guess.  My point is just to mention
> that creating a branch with Git costs nothing.

Creating a branch, yes, but continuously rebasing them all and recompiling before
working on each single commission: yes (building guix is pretty time
intensive). This is where I think guix lacks a proper CI/CD. That contributors
even have to check if a patch applies, if it builds and run guix lint
seems paradox to me, especially with the capacity problems that already exist
when accepting submissions.

I think the problem you have comes from multiple patches of mine being in
wm.scm which has also made rebasing more complicated. Git really seems
to struggle when patches have hunks in one file that might touch each other,
that I haven't really understood how to avoid. but I can check
one more time. Maybe we could have a look at how the patch is failing?




  reply	other threads:[~2022-12-20 18:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 16:53 [bug#60013] [PATCH] gnu: Add clight Florian
2022-12-12 19:16 ` zimoun
2022-12-12 20:51   ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-12 20:31 ` [bug#60013] [PATCH 1/3] gnu: Add libmodule florhizome
2022-12-12 20:31   ` [bug#60013] [PATCH 2/3] gnu: Add clightd florhizome
2022-12-12 21:53     ` ( via Guix-patches via
2022-12-12 20:31   ` [bug#60013] [PATCH 3/3] gnu: Add clight florhizome
2022-12-12 21:57     ` ( via Guix-patches via
2022-12-12 21:00   ` [bug#60013] [PATCH 1/3] gnu: Add libmodule ( via Guix-patches via
2022-12-12 23:48   ` zimoun
2022-12-13 11:51     ` Florian
2022-12-15 11:31       ` zimoun
2022-12-20 16:33         ` Florian [this message]
2022-12-21 11:22           ` ( via Guix-patches via
2022-12-30 12:45           ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qounifm.fsf@posteo.net \
    --to=florhizome@posteo.net \
    --cc=60013@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).