unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: florhizome@posteo.net, 60013@debbugs.gnu.org
Cc: florhizome <florhizome@posteo.net>
Subject: [bug#60013] [PATCH 1/3] gnu: Add libmodule
Date: Tue, 13 Dec 2022 00:48:25 +0100	[thread overview]
Message-ID: <86tu20b2uu.fsf@gmail.com> (raw)
In-Reply-To: <91575b0f95b5a71b18108b57fa1a366e0f6044c9.1670876889.git.florhizome@posteo.net>

Hi,

On Mon, 12 Dec 2022 at 20:31, florhizome@posteo.net wrote:

> zimoun: yes I usually send an empty mail before a patchset wit
> multiple patches

Two minor opinionated comments. :-) Maybe instead of an empty mail
before a patch set, you could send a cover letter.  For instance, the
most simple as template is provided by:

    git format-patch --cover-letter -3 --base=origin/master

which creates 0000-cover-letter.patch; and it looks like:

--8<---------------cut here---------------start------------->8---
From e84042fdd4ac2f903224e1b5f366537a22b4d593 Mon Sep 17 00:00:00 2001
From: zimoun <zimon.toutoune@gmail.com>
Date: Tue, 13 Dec 2022 00:42:04 +0100
Subject: [PATCH 0/3] *** SUBJECT HERE ***

*** BLURB HERE ***

Ricardo Wurmus (3):
  gnu: python-flasgger: Update to 0.9.5.
  gnu: seqmagick: Update to 0.8.4.
  gnu: cnvkit: Update to 0.9.9.

 gnu/packages/bioinformatics.scm | 31 +++++++++++++++++++---------
 gnu/packages/python-xyz.scm     | 36 +++++++++++++++++++--------------
 2 files changed, 42 insertions(+), 25 deletions(-)


base-commit: 8c197f990b7ab60e4524567d628d78ea62973c11
-- 
2.35.1
--8<---------------cut here---------------end--------------->8---



Last, just to point that,

> base-commit: 0ce1f82e5aaac951b21d579eb46bf75cfe6713c0
> prerequisite-patch-id: 36ae907c0ae2cbc001f774c0514ab217855270c2

[...]

> prerequisite-patch-id: 709b4522fd225f3c28bb2721e5dd9a20014ce131

these prerequisite could lead to trouble when applying this patch set.


Anyway, thanks for the patch set. :-)

Cheers,
simon




  parent reply	other threads:[~2022-12-12 23:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 16:53 [bug#60013] [PATCH] gnu: Add clight Florian
2022-12-12 19:16 ` zimoun
2022-12-12 20:51   ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-12 20:31 ` [bug#60013] [PATCH 1/3] gnu: Add libmodule florhizome
2022-12-12 20:31   ` [bug#60013] [PATCH 2/3] gnu: Add clightd florhizome
2022-12-12 21:53     ` ( via Guix-patches via
2022-12-12 20:31   ` [bug#60013] [PATCH 3/3] gnu: Add clight florhizome
2022-12-12 21:57     ` ( via Guix-patches via
2022-12-12 21:00   ` [bug#60013] [PATCH 1/3] gnu: Add libmodule ( via Guix-patches via
2022-12-12 23:48   ` zimoun [this message]
2022-12-13 11:51     ` Florian
2022-12-15 11:31       ` zimoun
2022-12-20 16:33         ` Florian
2022-12-21 11:22           ` ( via Guix-patches via
2022-12-30 12:45           ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tu20b2uu.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=60013@debbugs.gnu.org \
    --cc=florhizome@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).