From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UHUqEIQoyWOGzAAAbAwnHQ (envelope-from ) for ; Thu, 19 Jan 2023 12:24:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ANs3EIQoyWMTIwEA9RJhRA (envelope-from ) for ; Thu, 19 Jan 2023 12:24:52 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 965213364F for ; Thu, 19 Jan 2023 12:24:51 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIT1f-0001MU-1D; Thu, 19 Jan 2023 06:24:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIFrU-0004gb-V2 for emacs-orgmode@gnu.org; Wed, 18 Jan 2023 16:21:04 -0500 Received: from mx0.chaotikum.eu ([2a01:4f8:c2c:ce71::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIFrP-00079M-Qs for emacs-orgmode@gnu.org; Wed, 18 Jan 2023 16:20:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=chaotikum.eu; s=20200128.mx0; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MB0g7+S/ViGkZcyr3X4dyqEJUUr2UOZb5sAojxptO3c=; b=bOcTY14X3hQs4vrVmoQgONn4TK nAUNfXSsjjYHZp6+G4iee+S9oyVrq417vWaSkrX5fQJfnvQ/lUOF6SP+Dwvw4ekLgMveBsGvb6sbv 0/qiGh4N/GRO5gX9huH/itxibTuHyAFjl8Gq5pf7HEQnEtXL0RHh9OHLz5OH5UH4Lnr00iFoRXluy 0FtszOuDVcbcxbNpgAxVf1dhNUKhawnfiDYDaDkkmZsbDM3hI1vLoF08vHTqdmcvVwNAG2CLSWwzG dzsNo89qftKUnR9fQmS8KO7kmECkPO+/S3zqOHaM1HaGvjAP6PvwS0MyKGeg1AdMVPqFnOH18cRTo TEVhJNa3w2Efu7rlcxg2Wq+/h+FBC7reSG2IhTyYZQlO+7qc5GKGj48BEPgR5faeKdDpD6gcMYird +159JdzaeaoioxD4Too8kuMqn+/lqi+/qWGsoWh8Fp7HypcEwYWsBMJRKQX28nW7a74WguxD3lcB5 fD1vl4iVXLJwnco8QCird43BHz80W8nANP5bNscDAzbeBJ7iAGoCPmmfH96WtNjS7tcEPoxsJmTxM 23j2pDWdR24QKZywHyCeAct340hoH0pk0LdB67VFyLKW/85e6sEPv8E+4JsFgCr6qi1jodQ/4ukJ0 JFEQu1fU2t0gVevtq8VFNAB3bia6jy68qSxQc5zEE=; Received: from [2001:4dd0:4f8e:0:fc6f:3e74:5718:be97] (port=52146 helo=naboo.chaotikum.eu) by mx0.chaotikum.eu with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIFrK-0005Li-DQ for emacs-orgmode@gnu.org; Wed, 18 Jan 2023 22:20:38 +0100 From: Thomas Schneider To: emacs-orgmode@gnu.org Subject: [BUG] org-open-line in tables broken with stripe-table-mode [9.6.1 (release_9.6.1 @ /usr/share/emacs/29.0.60/lisp/org/)] Openpgp: id=E384009D3B54DCD321BF953295EE94A432583DB1; url=https://keys.openpgp.org/vks/v1/by-fingerprint/E384009D3B54DCD321BF953295EE94A432583DB1; preference=signencrypt Date: Wed, 18 Jan 2023 22:20:37 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a01:4f8:c2c:ce71::1; envelope-from=qsx@chaotikum.eu; helo=mx0.chaotikum.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 19 Jan 2023 06:24:07 -0500 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674127492; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature: openpgp:openpgp; bh=MB0g7+S/ViGkZcyr3X4dyqEJUUr2UOZb5sAojxptO3c=; b=W7w8SKAn47Vmg5Wr8zplFWNeiOP9ZQG6dL/TmyUG3MMIxrhR/q4vbGzQM0fg9rVENl11/y k1V3gLbY4klkSYRGuDkUxI6oFCOuNa1mrZGUigF8dDXAaVxZIYsXdHb1EUN+jy8iRcdVZK 8fJOuRSDBlFaeAzzPYHnkblNeN0LL7gAxkuujhXc5oLWcAIbvk0DJcHGMkgImy3XSwNeVG iKqUdAS5DZ5TIk5Q/WKgX1xbvb0WK/2wOzTRw01T9m0Rt4sXkvNp3+OKGeiSCHnzWD4TrG UlHYmMfJQ36O0neCD/mIUDsL47hyUEd9j1mSl9I62fqnljLjvZmS26+FQgWqBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=chaotikum.eu header.s=20200128.mx0 header.b=bOcTY14X; dmarc=fail reason="SPF not aligned (relaxed)" header.from=chaotikum.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674127492; a=rsa-sha256; cv=none; b=QNfzQGJmMOmgekGT5qrBNPMAfV9sWt44zes0r+OCv9Kh0aGSTWn3IqjSliS6K3Pyie/Rht hnMYTZ/MJSuOQHPxKJi6ImhK49BUCj0zjTCXHkNK77b/wlUR8EAqqRcviO/r6IChfJReCr JDFuy7Djc7IVpSdNLOmMzqklFFKKWnSS/u9YrS2vxlM+Ud4GU5u92AXF4kjwn3iCasXgdp SvL+GZKrBhHBJh3klVvORWJI0hTsmKe2AtvfTBBaFZnHHwcIFMKn3gFsHLOmxnt3ZG0isO DLpmeOoP2e4g660pifxfiKeH1VnIRvogNe2AXS0N4Ip/zwzsn0LWGiqT3AmjVA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 6.07 X-Spam-Score: 6.07 X-Migadu-Queue-Id: 965213364F Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=chaotikum.eu header.s=20200128.mx0 header.b=bOcTY14X; dmarc=fail reason="SPF not aligned (relaxed)" header.from=chaotikum.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: /hGJywQBXFqz Dear maintainers, I=E2=80=99ve run into an issue with Org tables in Emacs 29 since it updated= Org to 9.6. While I think it is a very similar issue to [0] and thus probably not Org=E2=80=99s problem, I nevertheless would like to at least r= ecord this for others. This issue only manifests together with stripe-table-mode from [1]. With that active, C-o (i. e., #'org-open-line) fails with some =E2=80=9Carg= ument out of range=E2=80=9D error. Steps to reproduce: --- wget https://melpa.org/packages/stripe-buffer-20141208.1508.el cat << EOF > x.org | | | # | EOF emacs -Q -l stripe-buffer-20141208.1508.el --file x.org M-x stripe-table-mode RET C-n # point should now be at the beginning of the 2nd line C-o # Result: org-table-insert-row: Args out of range: 7, 12 --- >From a user point of view, this was broken by Org 9.6, but as outlined above, the issue may as well be with stripe-buffer. In any case, I `git bisect`ed Org and found that this happens since commit fa7530c7b (Rename old function call to use org-fold). The following patch to stripe-buffer partially solves the issue: C-o no longer fails, but in the table that I found the issue in, C-o and everything that causes formulas to be (re-)calculated still takes very long if and only if stripe-table-mode is enabled. --- diff --git a/stripe-buffer.el b/stripe-buffer.el index 5a185db..e9a1b57 100644 --- a/stripe-buffer.el +++ b/stripe-buffer.el @@ -189,13 +189,13 @@ Used by `stripe-table-mode' Only the first matching g= roup will be painted." (let (( visible-ranges (sb/buffer-visible-regions-compressed)) ranges) (cl-dolist (vr visible-ranges) - (save-excursion + (save-excursion (save-match-data (goto-char (car vr)) (while (and (<=3D (point) (cdr vr)) (re-search-forward stripe-in-table-regex (cdr vr) t) (not (invisible-p (match-beginning 0)))) (push (cons (match-beginning 1) (match-end 1)) ranges) - ))) + )))) (sb/compress-ranges ranges))) =20 (defun sb/redraw-all-tables (&rest ignore) --- Whether or not this issue is with Org, I=E2=80=99d appreciate any feedback = on this. Thanks, Thomas [0]: https://lists.gnu.org/archive/html/emacs-orgmode/2022-12/msg00000.html [1]: https://github.com/sabof/stripe-buffer Emacs : GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24= .35, cairo version 1.17.6) of 2023-01-18 Package: Org mode version 9.6.1 (release_9.6.1 @ /usr/share/emacs/29.0.60/l= isp/org/) current state: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D (setq org-link-elisp-confirm-function 'yes-or-no-p org-bibtex-headline-format-function #[257 "\300%1\236A\207" [:title] 3 "\n= \n(fn ENTRY)"] org-export-before-parsing-hook '(org-attach-expand-links) org-cycle-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-he= ader-arg-expand) org-archive-hook '(org-attach-archive-delete-maybe) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lin= es org-cycle-optimize-window-after-visibility-change org-cycle-display-inl= ine-images) org-link-from-user-regexp "\\\\|\\" org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-fold-show-all append local] 5] #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append loca= l] 5] org-babel-result-hide-spec org-babel-hide-all-hashes #[0 "\301\211%10\207" [imenu-create-index-function org-imenu-get-tree] 2] turn-on-auto-fill) org-babel-load-languages '((emacs-lisp . t) (sqlite . t)) org-confirm-shell-link-function 'yes-or-no-p outline-isearch-open-invisible-function 'outline-isearch-open-invisible org-agenda-before-write-hook '(org-agenda-add-entry-text) org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-confi= gure-edit-buffer) org-confirm-elisp-link-function 'yes-or-no-p org-speed-command-hook '(org-speed-command-activate org-babel-speed-comman= d-activate) org-fold-core-isearch-open-function 'org-fold-core--isearch-reveal org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-a= rg-expand) org-link-shell-confirm-function 'yes-or-no-p org-babel-pre-tangle-hook '(save-buffer) org-agenda-loop-over-headlines-in-active-region nil org-occur-hook '(org-first-headline-recenter) org-metadown-hook '(org-babel-pop-to-session-maybe) org-link-parameters '(("attachment" :follow org-attach-follow :complete or= g-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org= -irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link :insert-description org-info-description-as-command) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :st= ore org-docview-store-link) ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link) ("w3m" :store org-w3m-store-link) ("doi" :follow org-link-doi-open :export org-link-doi-export) ("fi= le+sys") ("file+emacs") ("shell" :follow org-link--open-shell) ("news" :follow #[514 "\301\300\302%4Q%2\"\207" ["news" browse-url ":"] 6 "\n\n(fn URL A= RG)"]) ("mailto" :follow #[514 "\301\300\302%4Q%2\"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"] ) ("https" :follow #[514 "\301\300\302%4Q%2\"\207" ["https" browse-url ":"] 6 "\n\n(fn URL = ARG)"] ) ("http" :follow #[514 "\301\300\302%4Q%2\"\207" ["http" browse-url ":"] 6 "\n\n(fn URL A= RG)"]) ("ftp" :follow #[514 "\301\300\302%4Q%2\"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL AR= G)"]) ("help" :follow org-link--open-help :store org-link--store-help) ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp)) org-metaup-hook '(org-babel-load-in-session-maybe) org-list-allow-alphabetical t )