emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] etc/ORG-NEWS: Clarify org-protocol bookmarklet issue
Date: Sat, 28 Dec 2024 22:50:56 +0700	[thread overview]
Message-ID: <vkp6p5$16ck$1@ciao.gmane.io> (raw)
In-Reply-To: <87msgh3sg6.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

On 28/12/2024 01:13, Ihor Radchenko wrote:
> Max Nikulin writes:
> 
> I also added an entry to ORG-NEWS:
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0af98b8411

I do not like "spawn empty page". See the attachment for another variant 
of wording.

[-- Attachment #2: 0001-etc-ORG-NEWS-Clarify-org-protocol-bookmarklet-issue.patch --]
[-- Type: text/x-patch, Size: 1262 bytes --]

From 61323321eaf0821aadb6fabf53ba4d8d8312e62a Mon Sep 17 00:00:00 2001
From: Max Nikulin <manikulin@gmail.com>
Date: Sat, 28 Dec 2024 22:45:06 +0700
Subject: [PATCH] etc/ORG-NEWS: Clarify org-protocol bookmarklet issue

---
 etc/ORG-NEWS | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index d26813c98..03e2693e1 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -20,14 +20,11 @@ Please send Org bug reports to mailto:emacs-orgmode@gnu.org.
 
 *** You may need to update =org-protocol= bookmarklets for browsers
 
-In Firefox-133, Firefox-128.5 ESR, and later, javascript bookmarklets
-may spawn empty page.  We have updated the manual with new
-bookmarklets that do not have such problem.
-
-TL;DR: ~void(0);~ needs to be added to the bookmarklets, so that they
-do not return anything.
-
-Example:
+In Firefox-133, Firefox-128.5 ESR, provided javascript
+bookmarklet examples replace current web page with =org-protocol= URL.
+It is necessary to reload the page to restore original content.
+We have updated bookmarklets in the manual appending ~;void(0)~
+to explicitly discard expression value, for example
 
 #+begin_example
 javascript:location.href='org-protocol://store-link?url='+
-- 
2.39.5


  reply	other threads:[~2024-12-28 16:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  8:12 [BUG] Org-protocol bookmarklets in Firefox behaving badly after recent upgrade [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)] Rehan Deen
2024-12-12 10:34 ` Max Nikulin
2024-12-12 14:14   ` Max Nikulin
2024-12-12 18:47     ` Rehan Deen
2024-12-13 11:09       ` Max Nikulin
2024-12-16 16:01       ` [PATCH] org-protocol: Add void() to bookmarklets Max Nikulin
2024-12-16 16:40         ` Max Nikulin
2024-12-22 12:43           ` Ihor Radchenko
2024-12-22 12:42         ` Ihor Radchenko
2024-12-24 14:14           ` Max Nikulin
2024-12-24 14:23             ` Ihor Radchenko
2024-12-27 16:48               ` [PATCH v2] " Max Nikulin
2024-12-27 18:13                 ` Ihor Radchenko
2024-12-28 15:50                   ` Max Nikulin [this message]
2024-12-28 16:58                     ` [PATCH] etc/ORG-NEWS: Clarify org-protocol bookmarklet issue Ihor Radchenko
2024-12-29 11:45                       ` Max Nikulin
     [not found]   ` <875xnp6qin.fsf@gmail.com>
2024-12-12 17:15     ` [BUG] Org-protocol bookmarklets in Firefox behaving badly after recent upgrade [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)] Rehan Deen
2024-12-26 16:49 ` Max Nikulin
2024-12-28 13:55   ` Rehan Deen
2024-12-28 16:05     ` Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='vkp6p5$16ck$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).