From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kAmSBgBjYWNWQAEAbAwnHQ (envelope-from ) for ; Tue, 01 Nov 2022 19:18:40 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id APpfBQBjYWNDDwEAG6o9tA (envelope-from ) for ; Tue, 01 Nov 2022 19:18:40 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D47B167E7 for ; Tue, 1 Nov 2022 19:18:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opsof-0007sR-5b; Tue, 01 Nov 2022 11:04:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opsod-0007sI-TN for emacs-orgmode@gnu.org; Tue, 01 Nov 2022 11:04:35 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opsoc-0006aT-25 for emacs-orgmode@gnu.org; Tue, 01 Nov 2022 11:04:35 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1opsoX-0004xj-F2 for emacs-orgmode@gnu.org; Tue, 01 Nov 2022 16:04:29 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [BUG] ox-odt file: links are not pointing to the real files (was: [BUG] ox-odt fails for org-id links (e.g., from org-roam v2) [9.5.2 (9.5.2-gfbff08 @ /home/moritz/.emacs.d/elpa/27.2/develop/org-9.5.2/)]) Date: Tue, 1 Nov 2022 22:04:20 +0700 Message-ID: References: <877d0xfu9m.fsf@localhost> <877d0wayn8.fsf@localhost> <87lep97tnn.fsf@localhost> <87ilkc30wd.fsf@localhost> <87ilk0jzab.fsf@localhost> <87iljzjkpu.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US In-Reply-To: <87iljzjkpu.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667326718; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3dGAUEuWVrN5NZDynvFtyOHQ3/yqcXgAtygDn7ACQlk=; b=BVQrdSngixuWM638mBakAhu8xiUhZHIp1PHNYpZIxSCWC0vmgbHDpO4P3E85YIfeqRWtuv VffisHGsRXIjFpEMebjbF9S/jle/pkp7kQeH7N+hdgtpiDiqIcFaiwVIBuvSh1H64KsK/D IzgU9VphKKP1U9Y9E1cvBqUMWn3MBR8nQwyoyJFWbYo96qcNYh2Rrk0CTuYXidlai0lirR TjbghmUrGdV4XEi3ki2Zwp/s4jTtbPEmjoRY8s7chluSThHqX2e4/o/X2IJmMH4XCodpze n2Z42aiXEfINRlyL0eS3kwWBObI92r2s9dDDWCpn0lWm/C4ypu+BPaA7YoukJQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667326718; a=rsa-sha256; cv=none; b=JOzF9keF894HfnZ5Is72IJb91ymsWgcTFx/IR7s4temGAg88h1fyZIi24ZZVJ+wps0ZXw6 NgAf2mOpWJHkb320Z+d0nUcuA7ahEIwKiBNslV+aYTPvoMRrgtYjrfa3dKtLLW8+pRzCEB 2E52FOLBWlIVS5dgGGz4QwwRzAXscSStOGFeZkwvRb3voeeUp7h+f/If/lwIINrLLMuETZ 1fFJiB4cNygxAp1TTwChxzd7vyrJePuoWnmpse1O9glCAjza593+1T/A7oR5SR8jkA/LU4 tsQM7KKvh586RaSgjz90QYpcDAYTNPd8V6iwBMSP6tpfpJGCcmwHDb1mC7f+gQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.25 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8D47B167E7 X-Spam-Score: 4.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: SPBWNMZbxPfF On 01/11/2022 12:40, Ihor Radchenko wrote: > See the attached new version of the patch. > > diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el > index 15a9cf2de..e4fb7eb84 100644 > --- a/lisp/ox-odt.el > +++ b/lisp/ox-odt.el > @@ -2688,7 +2688,16 @@ (defun org-odt-link (link desc info) > ((member type '("http" "https" "ftp" "mailto")) > (concat type ":" raw-path)) > ((string= type "file") > - (org-export-file-uri raw-path)) > + (pcase (org-export-file-uri raw-path) > + (`(and (pred #'file-name-absolute-p) ,path) > + path) I am in doubts if this branch may be executed at all. For absolute file names `org-export-file-uri' adds "file:" prefix so I expect that `file-name-absolute-p' is always false. > + (path > + (if (string-prefix-p "file://" path) > + path > + ;; OpenOffice treats base directory inside the odt > + ;; archive. The directory containing the odt file > + ;; is "../". > + (concat "../" path))))) > (t raw-path))) > ;; Convert & to & for correct XML representation > (path (replace-regexp-in-string "&" "&" path))) This time I am not lucky enough to accidentally face a case with invalid link URI. However I do not think that for the link [[file:file-b.org]] "../file-b.org" is appropriate default description. I do not expect "../" here.