From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SGz8JmaX3WHRDgEAgWs5BA (envelope-from ) for ; Tue, 11 Jan 2022 15:42:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gHBtJGaX3WF71wAA9RJhRA (envelope-from ) for ; Tue, 11 Jan 2022 15:42:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6DE7B11F51 for ; Tue, 11 Jan 2022 15:42:46 +0100 (CET) Received: from localhost ([::1]:38800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7IMH-0005yT-Hg for larch@yhetil.org; Tue, 11 Jan 2022 09:42:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7HcL-0005GX-Pw for emacs-orgmode@gnu.org; Tue, 11 Jan 2022 08:55:25 -0500 Received: from ciao.gmane.io ([116.202.254.214]:35964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7HcJ-0006eT-Lx for emacs-orgmode@gnu.org; Tue, 11 Jan 2022 08:55:17 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n7HcH-000A8V-2S for emacs-orgmode@gnu.org; Tue, 11 Jan 2022 14:55:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-maxima.el: Fix execution on MS Windows Date: Tue, 11 Jan 2022 20:55:05 +0700 Message-ID: References: <53a33993-2e62-2600-ee28-7c3d886de678@gmail.com> <8cd49b4c-9342-a77f-d665-402c41432b57@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <8cd49b4c-9342-a77f-d665-402c41432b57@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641912166; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2kBOEy91TsRTwChG27UC85a5i2vCXooUfQzpE5DkFqQ=; b=PFZzQ6Hr+uPTb7bvv0Y5g702ixGy8eVN/lFTAVW+8rQGQsIHWy9DVaaUOIyJDJVkaIxX/I itXfRh/TZfgLtdcMv6gX9F91lxoOKv3LugWxIda/7b23RKKrQtfAVvsRbmFxWc1ZkUT2PA EEQvLeKOocn2BOpI96wdwD2yeCvxuD0e6gclZqfwuCIRntmLpSOxpgzgbpds0rOCfKqqH3 hmx8vUDsWAVwxN5LLu609ErIpQyGoioOl2u4QQ+89/U87ZgEWsySTfHVLvrqr5cpOYAi1/ dtZlWKxmF60QNp8FSWgKhC7tYCqEWTeTUuYshPEpvSABGSvHNHWwaP0m9e2R5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641912166; a=rsa-sha256; cv=none; b=qzWJDXRub06rTwgy6JGn2UAeLD2h0EdCeWDsCH+q1HeMc0ZVoWxH0TImtJb7eI0svH/eQu S3uxGEqZYAUe8srV/vcpdZTvzio/i5uTgxrGWy5swmDvaJHZcsogDBFGSfU5S9WqTzH4JJ eky0Sc8ph+UvRmXS1qsy4TCiz4n9WLdEHCNYROpKkG5faU5Zo1WwM4TKrK+Bhe0ywBBiqN hlkGVlpsGqjo1AVKoUxrhs66DoKjE8WL85g1rGAjeZ5E39nB2MzAV37h4y8l4QAGOZK9bB SUlzhDefcQnBCLXWbOCQjhQWH83IbZugCzQxXHz7UPYpSHEacLcfj0CZHKevhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.31 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6DE7B11F51 X-Spam-Score: -3.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: MiBwVgg4hWfe Nikolay, I do not have any objections concerning the last version of your patch (I have not test it though). It is tracked on https://updates.orgmode.org/ however it may take months before it will be committed. Have you signed FSF papers related to copyright? See https://orgmode.org/worg/org-contribute.html#copyright There is no "TINYCHANGE" keyword in the commit message and I have not found you in the list of contributors to Org mode (Bastien likely have access to more actual data). Since several your patches have been accepted to Emacs, you are close to the limit when formalities become necessary. Do not consider the comments below as a request to change anything in the patch. I am just trying to express more clear what I wrote in the previous message. On 31/12/2021 03:54, Nikolay Kudryavtsev wrote: >> When some external data is substituted into a Maxima command >> (batchload this case) there should be an extra pass of escaping that >> protects special characters like quotes (and backslashes?) accordingly >> to Maxima rules. > Not necessarily, Maxima is capable of understanding unescaped paths, for > example, this works: > > maxima --very-quiet -r "batchload(\"/tmp/sp > ce/babel-gxqTkM/maxima-ua3e9j.max\")"$ Consider a really peculiar path for tmp files with quotes /tmp/")$ something-weird$ "/maxima-ua3e9j.max I hope, it is unrealistic and will be properly escaped by %S formatter. I am a bit surprised that Maxima does not allow to do it in a more reliable way since several interfaces exist (WxMaxima, texmacs). Unsure if get_application_args is suitable https://sourceforge.net/p/maxima/mailman/message/35180908/ > Command line Maxima actually has a batch flag, but using it returns the > entire input file in the output too and that seems to be the reason why > the original authors of ob-maxima didn't use it. It would be great if it had another flag to suppress printing content of the batch script or a flag that changes a setting that controls such behavior.