From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cHDhGliYzGFZ7wAAgWs5BA (envelope-from ) for ; Wed, 29 Dec 2021 18:18:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2MVeF1iYzGEhaQAAauVa8A (envelope-from ) for ; Wed, 29 Dec 2021 18:18:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1A37120C76 for ; Wed, 29 Dec 2021 18:18:16 +0100 (CET) Received: from localhost ([::1]:35234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2cad-0000Ht-AV for larch@yhetil.org; Wed, 29 Dec 2021 12:18:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2cOL-0002U0-Dh for emacs-orgmode@gnu.org; Wed, 29 Dec 2021 12:05:35 -0500 Received: from ciao.gmane.io ([116.202.254.214]:46074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2cOJ-0005D4-Ub for emacs-orgmode@gnu.org; Wed, 29 Dec 2021 12:05:33 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n2cOH-0006XW-39 for emacs-orgmode@gnu.org; Wed, 29 Dec 2021 18:05:29 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] ob-maxima.el: Fix execution on MS Windows Date: Thu, 30 Dec 2021 00:05:22 +0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 17 X-Spam_score: 1.7 X-Spam_bar: + X-Spam_report: (1.7 / 5.0 requ) DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.024, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640798296; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GtUyttqx9zCAqVQ1dUccjvMUeFGnHNpTbnkl74fKK58=; b=qUe2w95yYhFVZAA0kE7pZgS1vIkU1k0QWlmniK4WLcK4JzWlRh/arc40SF8tt3Lz9NLFCA wHoHYwhfJSG8tlMkIDIEbZf1kXDc0dk0H9/ZEuzhDAqqy4myZckvpmKRIzE1GTH5LmQJZ4 oeYNOXL+YmXe8ld8OAzNP43N3/e5TotAS/YufgnTux3QOZvFKS0htm/mRjAGjFQlJoAcgs THfv9Ntk5KWJ+J8mn8jikCzv02nXjVixmSqqT00wVklRu/9zDljfxFYr9zIjJqf8xepjH8 md4c4tDuIE5XPRzYS0o4uHhfFo+tPRomIb+HMoXJb7SvYOz/UC8a8OnGn5TWjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640798296; a=rsa-sha256; cv=none; b=N/Y/61xC/icMq5KBTIk8E+zbYcPmZ+PxP37XQqZ40fixds1kU00LAGYoqMmJZv0VisDfcI 0cmLnOVzGYQtuZvDyFtfBDSMAyNTq1I+XhqLlfosbdfBr6uwoe4L2Dsp8c+PQOh3P6wRkS kilbfGcUdRV7U3xpZCRnLbpoMLBZnIlmojMexnH/RDAs9F7HcKRNTvb3dIl5LKmIIfrE3Y FZCmuta7bJbUN0WDqTbmRzcIdQOO3WLRNJyQef0ZAbFAqXhzw8raxHrdpmQTPBJR4Z68Te H3J4HvHY1sZRs20ypM9u63VJJKMf32rN6MpllVxdbl5bZ7glGJwRvB/UWFF+vQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.47 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1A37120C76 X-Spam-Score: -2.47 X-Migadu-Scanner: scn1.migadu.com X-TUID: WPgV9ZCC4SXv On 27/12/2021 03:18, Nikolay Kudryavtsev wrote: > > Ob-maxima currently does not work on Windows due to it using single > quotes in the Maxima invocation and those not being supported by Windows > CMD. > > After some testing I've found an invocation that seems to work fine on > both Windows and Linux. I don't think this patch can cause any real > issue, since the string in those quotes is just the temp file path. > --- a/lisp/ob-maxima.el > +++ b/lisp/ob-maxima.el > @@ -77,7 +77,7 @@ This function is called by `org-babel-execute-src-block'." > (result > (let* ((cmdline (or (cdr (assq :cmdline params)) "")) > (in-file (org-babel-temp-file "maxima-" ".max")) > - (cmd (format "%s --very-quiet -r 'batchload(%S)$' %s" > + (cmd (format "%s --very-quiet -r \"batchload(\\\"%S\\\")\"$ %s" > org-babel-maxima-command in-file cmdline))) I do not like original variant, but suggested change makes it unsafe in more cases. `in-file' might contain apostrophe in the case of peculiar path of the directory for temporary files. More characters may be interpreted by BASH inside double quotes. Even docstring for `shell-quote-argument' mentions security issues with the function. Ideally command arguments should be passed as a list to avoid intermediate interpretation by shell at all. Unfortunately gluing strings to make a shell command is used too widely in org code and emacs API encourages such unsafe way.