From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yE9jBzXBn2HMiQAAgWs5BA (envelope-from ) for ; Thu, 25 Nov 2021 18:00:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4HkgAzXBn2FjcQAAB5/wlQ (envelope-from ) for ; Thu, 25 Nov 2021 17:00:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A402F1356D for ; Thu, 25 Nov 2021 18:00:36 +0100 (CET) Received: from localhost ([::1]:35850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqI6s-00024D-U4 for larch@yhetil.org; Thu, 25 Nov 2021 12:00:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqI60-000223-R3 for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 11:59:42 -0500 Received: from ciao.gmane.io ([116.202.254.214]:55142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqI5y-0006M0-Eb for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 11:59:40 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mqI5w-0002Ut-KO for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 17:59:36 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [Patch] to correctly sort the items with emphasis marks in a list Date: Thu, 25 Nov 2021 23:59:23 +0700 Message-ID: References: <87a6qg1rjx.fsf@posteo.net> <874kgft7n1.fsf@nicolasgoaziou.fr> <87blanxb1z.fsf@posteo.net> <87lf9fa3ak.fsf@posteo.net> <87sg3n8f33.fsf@posteo.net> <87tuo2d670.fsf@nicolasgoaziou.fr> <87r1j6b6ku.fsf@nicolasgoaziou.fr> <87a6pt9hyd.fsf@nicolasgoaziou.fr> <874kg0ae0k.fsf@nicolasgoaziou.fr> <877dcw3052.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 X-Mozilla-News-Host: news://news.gmane.io In-Reply-To: <877dcw3052.fsf@localhost> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-4.1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637859636; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+pxbDYYUJZ1WTa/R8C2bSWBzJNrPkYmqQxwsPxGwB0Y=; b=Cm5u1ZkpeDBmiNWP1wWiwC2UyerMavBfRjo+xgqbXmNPH+Wnii48C+ICtkMORL8NOFVc6o MpdlhV51flsyEF2/sarlqnM9Jg3khJpu+VsysjXFw62B3J6WNM56XITmIIsP6Cd1aLRpfS ZEiyaQKOtqSjFbpjUge07I3as+GdPSr5VzqTQyBRkeA1LXY5DKnMzGshX9egbm3KBmS7zv ZTWLsAz7RCO0pJTWCAqPfFIBhu/8Ob44A7YEkNaflsMg1CujU+DQeXiE+1LXpMm16njE6k v7PFEShg95eRdQxrHn+ILzYZn18sGLQvmYFPGg8ioud8exY6zKj6abJCXwvLhA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637859636; a=rsa-sha256; cv=none; b=VzbACvTXfHSXSYqZuZkWBJ5KLgXo/R8vhmKN2k/x9bybHQjmNhGWgrZn87yup9IwQ8RkZb VBswUxGxJ6p9vD/JPbyrT5y+6lzyFd0hh0nJOwjQSkvXLvCyPskLdHabdizvFirGAalOYl UQ5KNVY/N5i/3y3ElgTbXsfH6ZYOFFs6V95bUUWSorp2THqyiYtSFR+xl4WviU0LjM42yu U6nsgudrTF7jfYbxqR7ubLmp1Y9S/RU4KMtk0fbAiPQziBK+5HAAfh16wNizws/H/pxwkk bpTDovxkCTaOOZrGwB03O/APDVDiWisAuDRmI0NMcRZD0PZsfHjgBQznt+XENw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A402F1356D X-Spam-Score: -2.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: u9ebDM6Ay2QI On 25/11/2021 19:11, Ihor Radchenko wrote: > Maxim Nikulin writes: > >> I think, new variant should be committed even it does not fix Juan's >> case. He have not confirmed the fix yet. > > The patch does apply onto main, but I have a comment. > >> + ;; Emphasis of second word. >> + ;; Locales with significant spaces (C, es_ES, pl_PL) > > I suspect that most of maintainers simply use C/en_US locales and we may > not be able to catch test errors in foreign locales. Do you know a good > way to automate testing with different locales? Can it be somehow > automated? > > Otherwise, the patch looks good for me. For this test locale is fixed to "C", see below. Concerning tests of multiple locales, I have no idea besides a virtual machine (qemu, VirtualBox, etc.) or container (docker, LXC, etc.) with enough enabled and generated locales. I think, more locales may be enabled on SourceHut as well. https://list.orgmode.org/s864tq$jet$1@ciao.gmane.io/ On 21/05/2021 00:06, Maxim Nikulin wrote:> > In the following subthread Nicolas mentioned that some of them could fail > https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr > I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8, > es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any > problem. This set of locales has 3 different collation rules, > however I do not think it matters for tests. > > On 20/04/2021 19:37, Maxim Nikulin wrote: >> On 20/04/2021 00:50, Nicolas Goaziou wrote: >>> Maxim Nikulin writes: >>> >>>> On 19/04/2021 23:08, Nicolas Goaziou wrote: >>>>>> + ;; Space role in sorting. >>>>>> + ;; Test would fail for locales with ignored space, e.g. en_US, it works >>>>>> + ;; in C and currently rare locales having significant space (es_ES, pl_PL) >>>>>> + (should >>>>>> + (equal "- Time stamp\n- Timer\n" >>>>>> + (org-test-with-temp-text "- Timer\n- Time stamp\n" >>>>>> + (org-sort-list t ?a) >>>>>> + (buffer-string)))))) >>>>> Since this test is bound to fail for some developers, I assume it >>>>> shouldn't be included. >>>> >>>> Locale "C" is forced for this group of tests. >>> >>> Sorry, I don't understand. There is no locale change around this test, >>> so it will fail, for example, for me. I wouldn't want to get a noisy >>> failure each time I run tests. >> >> Certainly flaky tests must be avoided. However I can not identify the source of confusion (yours or mine). >> >> There is redefinition of `string-collate-lessp' to run tests with "C" locale: >> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207 >> >> And it works for me