From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4MFZNgJxnmHVZwEAgWs5BA (envelope-from ) for ; Wed, 24 Nov 2021 18:06:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cATmMQJxnmESOAAAB5/wlQ (envelope-from ) for ; Wed, 24 Nov 2021 17:06:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A06C6D82A for ; Wed, 24 Nov 2021 18:06:10 +0100 (CET) Received: from localhost ([::1]:57334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpvij-0006gA-Fj for larch@yhetil.org; Wed, 24 Nov 2021 12:06:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpvd3-0000qY-9z for emacs-orgmode@gnu.org; Wed, 24 Nov 2021 12:00:19 -0500 Received: from ciao.gmane.io ([116.202.254.214]:35868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpvd1-0006aF-HR for emacs-orgmode@gnu.org; Wed, 24 Nov 2021 12:00:17 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mpvcx-0009af-OE for emacs-orgmode@gnu.org; Wed, 24 Nov 2021 18:00:11 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Fix regex for determining image width from attribute Date: Thu, 25 Nov 2021 00:00:04 +0700 Message-ID: References: <87czmtuy0p.fsf@gmail.com> <87ilwl71gh.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> <8735nnlaef.fsf@gmail.com> <87v90jph1w.fsf@gmail.com> <871r37l96a.fsf@gmail.com> <87k0gzpb5s.fsf@gmail.com> <87h7c2pb6w.fsf@gmail.com> <87ee75pmsn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <87ee75pmsn.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-4.1, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637773570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x8KHkIuhO9sAflcQWPkBQHVtswRfMV+HqXaf2WJTS6E=; b=RFRrtdgXZeosVsEmLTlTkGswCIIc483H724QPLRJ/Wo0qQAbVRz80XwihTLO5HZupLhYSb SXAv8pI67nbQYbxuYlmWxC9ZuzDxIg1bVBxe6LUClm4rMLFKF9c1kBYFuoaAZsihgrYFwd 9to4R0qwbVZQo7UjPJBI0Ozft4zvcp0/e6us3nLDJGdqulyOVuRhsqxNKq1uap9i8Oout5 AyHed8JnTn0n0PE1vXyNeSCdsVFQFRrHm+wvKy1sQxwt0EyBbQTjI/Pr9S455+WIPbXsBO eIH7OqnSZrm1+7xrG3HA7jOreAVyQnrAiRQmQ6OofzMfpk9ypmSAlfGwmGZlLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637773570; a=rsa-sha256; cv=none; b=QuBTBu0A++1Yw99jRXIHMlpjRXaIU5jllq6t9B4br/mNeq8pUpwb5jkoL5VMBharO+ysJ3 Ffljk33CK2YrYdo6BcyphDNjmmZuxo1uy/1Pbp5nrfyx8jIm3s5ONzcav3J1LYC7zeBb32 Dn64YUodZTtkYvGkHSMmTZ/llt00hHrkD/GdNIbHbTyxoyv+sq7sDrzS0V5374wDJY+MP8 IYAqFxc8AcNhTDsyWyvCZt4p978G7yXvktT/asIvmj3HHdCGHCO0oceXQiOHZXMruD4wcK nFRh8UffXANQWnlVLNWz/ZLE65ke9/yVW6L3nL6z3qXev/PwlswCEUtEV86xHw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A06C6D82A X-Spam-Score: -2.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: PvyP3A4+G3eu On 24/11/2021 22:59, Matt Huszagh wrote: > > Better? Certainly. I have not tested the patch though. I am sorry that I confused you by my note concerning space before :width. I am afraid, current variant means repeated ":" > + (concat "^[ \t]*#\\+attr_" > + backend > + ":+.*? :width +\\(\\S-+\\)"))) ^ -----------------------------------' Is space after "#+attr_XXX:" is required at all? Is something besides spaces allowed here? Untested: ":\\s-*:width\\s-+\\(\\S-+\\)" I am unsure concerning newlines as space characters, so the following, perhaps, is more correct: ":[^\n\\S-]*:width[^\n\\S-]+\\(\\S-+\\)" Actually value is everything till line end besides trailing spaces, so precise regexp should be a bit longer. Are there backends that allows spaces between number and units?