From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 5wD6EAmjZWH8HQAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 17:00:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mKEPDAmjZWHKMgAA1q6Kng (envelope-from ) for ; Tue, 12 Oct 2021 15:00:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9784B9E0B for ; Tue, 12 Oct 2021 17:00:24 +0200 (CEST) Received: from localhost ([::1]:45604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maJGR-00035l-8m for larch@yhetil.org; Tue, 12 Oct 2021 11:00:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maJFm-00034R-0E for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 10:59:43 -0400 Received: from ciao.gmane.io ([116.202.254.214]:52746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maJFk-0006qY-BW for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 10:59:41 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1maJFh-0000is-Kg for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 16:59:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Tue, 12 Oct 2021 21:59:23 +0700 Message-ID: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <878rz3ddet.fsf@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634050824; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Quo9PrjSZPNpIcoZ63ZfqkQwgKSciFvnkgnHKif7xcM=; b=JgBHg+YL2Kf7s/TwLXx5XVx2LheDXDcfwPskgERe3gk0GapsxavuAfwrvcorvCl5dvjd21 jkexnheDJGluFhjW7jREiOD7zSq1PCLfX8ZJU//M3QRzrXdOqVejaEtWghsVEqGnD93Gvn 9bp69VJVGmitJnM6xY5t16mcLXXtZFZ2mphL4+Fvawee1LPh117vP2vlYFqjjYmX2Nu+PF ukYgAqUYq0xqHsgug1trA2loCZMj5VzAGGFSrziB02CGO2keE1DXklKq0a3ryyMbTbtmR3 CPHudzaZohPQpNMkAagPKSnDYIm8g9kJ3mOVLCVgDOLYLvCFk7Z1ST4co9ytmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634050824; a=rsa-sha256; cv=none; b=ja0tdZH/8+hOAkHwOsfmmVf2q/lhnhnv9OVmLafzG/uCnKJKUQbz79WUeBYPfGrLOaqROn 158Yy68NaNHYWMygoluf+lszWDz4F7aDTVzFFU5jEDdltVhqQaFmRshvAJ5YYenAPjb9pl CCwjvFE9RkNygPRKLlAvTSgvZlf8pNJOh0rp0ysmwqzWB2t2GRCmMMkzLlZGc/dyIktd75 xl9isiJoejaTTlRfCyFs+HIAmWjQ8wSYoWCWO+zx+T3i6awvRyJYrd0yNLCMH2wrP3bm/c NGM/Yzn8GEJfS1pKBRzj0RkbHBQqvg0qRVDMSrljTaZbXprfl7Ca+Cx6A3xXig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9784B9E0B X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3/qdI9N/JoeU On 08/10/2021 17:22, Marco Wahl wrote: > Max Nikulin writes: >> On 05/10/2021 23:32, Ihor Radchenko wrote: >>> Max Nikulin writes: >>> I tried come up with the reason why org-no-popup was used in the >>> initial >>> implementation. I think, the reason is avoiding situation like what you >>> may see after running >>> (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) >>> So, removing the macro completely is not a good idea. >>> I have updated the patch that should work without dropping the >>> macro. >>> See the attached. > > Please note the documentation of variable `pop-up-windows'. > > This variable is provided mainly for backward compatibility and > should not be used in new code. > > The same holds for `pop-up-frames'. > > The drop of the macro looks like a good idea to me. Can someone please > describe the price for dropping macro `org-no-popups'? > > @Ihor I do not understand what "situation" you mean. Marco, have you tried (setq pop-up-frames t) with first version of patch? It shows help in a new separate frame. Unsure if it is expected behavior even with such customization. However current version of macro does not protect against (setq display-buffer-base-action '((display-buffer-reuse-window display-buffer-pop-up-frame) (reusable-frames . 0))) The example is taken from (info "(elisp) Choosing Window Options"). I have no idea if such customization can be considered as shooting a foot. P.S. http://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=399481bad10845a77f210c9320ff1efee9a312c8 that caused the current problem changed namely `pop-up-windows' Joshua mentioned `display-buffer-overriding-action'.