From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AJlkNH34UWGxOgAAgWs5BA (envelope-from ) for ; Mon, 27 Sep 2021 18:59:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2MEcMH34UWFLOwAA1q6Kng (envelope-from ) for ; Mon, 27 Sep 2021 16:59:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C25C1C8C0 for ; Mon, 27 Sep 2021 18:59:41 +0200 (CEST) Received: from localhost ([::1]:44194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUtye-0006ca-BI for larch@yhetil.org; Mon, 27 Sep 2021 12:59:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUtt3-000724-5D for emacs-orgmode@gnu.org; Mon, 27 Sep 2021 12:53:53 -0400 Received: from ciao.gmane.io ([116.202.254.214]:60022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUtt1-0003iy-JS for emacs-orgmode@gnu.org; Mon, 27 Sep 2021 12:53:52 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mUtsy-0007EZ-T6 for emacs-orgmode@gnu.org; Mon, 27 Sep 2021 18:53:48 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [Patch] tests for org-remove-invisible Date: Mon, 27 Sep 2021 23:53:40 +0700 Message-ID: References: <87a6qg1rjx.fsf@posteo.net> <874kgft7n1.fsf@nicolasgoaziou.fr> <87blanxb1z.fsf@posteo.net> <87lf9fa3ak.fsf@posteo.net> <87sg3n8f33.fsf@posteo.net> <87tuo2d670.fsf@nicolasgoaziou.fr> <87r1j6b6ku.fsf@nicolasgoaziou.fr> <87a6pt9hyd.fsf@nicolasgoaziou.fr> <874kg0ae0k.fsf@nicolasgoaziou.fr> <87v97dz3ef.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 X-Woof-Patch: [PATCH 1/3] More tests for `org-sort-list' In-Reply-To: <87v97dz3ef.fsf@nicolasgoaziou.fr> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.136, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632761981; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HTWwC/IpADtFGZ8U8d8aRrUg9Fhe6WQOWFqlGhjpWQI=; b=UiNGU3Tp26XfV75lzidn6/8eJhG6Ab6mqjVdqHhJUGb5sfxGIWk4Grug/PhxUl9M1FmAlE k89rohplnIcqx5gsGPD4HOhZ98/2/n3xfZMEVWiPq4fAOfdpj2uNVpb8hS5RveyQMJd5gx i5U+NKpVN3q/Ka4LX3ZEWrN2I8Jr6YJIOUgyOgMQjRIHsa1nyiN4A0Dvlw8zwQtABIRXUo VHJiGtwpgbDw+UFS8XkqJ3gyLey69P2rDMRZ0MJXviO22qlJa6dJpnoboWl+mdLVmjbIxF OjribHIqMZEC+ce99X0u0xHsj6kFQK/pgJcuCFX1qOmpOC3yhxEdMmRDPBJWVQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632761981; a=rsa-sha256; cv=none; b=N2bpbZTayEY7Z6md2f0LwzlWYhvirNldVB0Vi34hH6qNrmJBSU91OVh5At9tBTdbpOZevJ 5Z6YUQEX1d+2tuNkvB/4gjG1m3hDQO8OHAYQgxxxRpaS/Opc5EbiFaD/NxvzlBke0joCVn 76KYsIF2n7u58gzlHplG6MLJY3lMHyawYXwx+UsGcjCRP3SairdITFsnsZjMqyQLcAp12G 2pykBEiwAfdHiHsTee6WKidBQvjmqKehbSc9Q/ssjOgvqgMceM6KHeO1a66NWPagN/nLbu nRH0XiM4Ag/vd+f6pkUqzM5vX8N2t0ss79QiCr5Q8YZD5i0mY9KPEUrSHdMOhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3C25C1C8C0 X-Spam-Score: -0.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: YeNT1b7ppUcy On 21/05/2021 01:06, Nicolas Goaziou wrote: > Maxim Nikulin writes: > >> The main patch that fixes org-remove-invisible to improve list sorting is landed. >> >> Let me remind that there were patches that added more test cases: >> https://orgmode.org/list/s5p88r$go9$1@ciao.gmane.io >> Is there any interest in them? >> >> In the following subthread Nicolas mentioned that some of them could fail >> https://orgmode.org/list/87r1j6b6ku.fsf@nicolasgoaziou.fr >> I do not see any reason for failure. I just have tried C.UTF-8, en_US.UTF-8, >> es_ES.UTF-8, and ru_RU.UTF-8 locales (interactively) and do not see any >> problem. This set of locales has 3 different collation rules, >> however I do not think it matters for tests. > > [...] > >>> There is redefinition of `string-collate-lessp' to run tests with "C" locale: >>> https://code.orgmode.org/bzg/org-mode/src/master/testing/lisp/test-org-list.el#L1207 > > I probably missed that re-definition. Feel free to disregard my comment. Do not consider this reminder as I insist on committing the patches. I am rather curious which kinds of unit tests are acceptable and which problems should be avoided. Since it is just tests, it does not matter whether the patches will be committed before or after the release.