From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:2:c151::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms9.migadu.com with LMTPS
	id mK4tGClDRWQPBwEASxT56A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 23 Apr 2023 16:39:37 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:c151::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id IEEEGClDRWRT7wAA9RJhRA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 23 Apr 2023 16:39:37 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 3F87435BAD
	for <larch@yhetil.org>; Sun, 23 Apr 2023 16:39:37 +0200 (CEST)
Authentication-Results: aspmx1.migadu.com;
	dkim=none;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1682260777;
	h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post; bh=8FS8NnXVgzdLTawaIq2QLmG8B1ButCZXXo9UiLDlEpI=;
	b=DFRPq98FO22IRgIakkUeHbxNIrM2OqbpBS0Tfj09J1pkEr740pPgvfQPqZj9cLM/e3gbY4
	Dlz8ycAHJ8zUcKlTt1baaVGluv58xFEziNKH5KDeXnu3v+oNcmxca6yaTf/LGo/Kun0Ocu
	rIi0XVYUaeVDUdmD1xjSOTgzfPRfNLF9rSY+xXcgGvTg2j1J0a/mPAyDcLzcp/DLC0sDBp
	23UunqwjBf5jr7EZUT5vyoZo/9D/wuhyK8OqtAl/yalU6gawY1MelETec5qV+O5PELZewY
	BSj+Y+rQ0q0Mn7ySfC9L8NT1c/WhLcTyInFbTCViy/dudvekMzwJNSRJwXHgQw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=none;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682260777; a=rsa-sha256; cv=none;
	b=CEU+WWOES+iA+Srnay4n3ytykobrILUHjrZu5Ki/Or+if2OgBr/U/z1UlO/Uq9PeSuTU4E
	hHE3IGpOr87gnUzseq+wGijoCrnXHfwpoTyLWCQ9d1tZvKHCH5G+bRa95mEEwI/+CPK8Wj
	ELX3t5ONGlBJ1vPuwpuRrFYZWMM0Miaf1Cws9Cqa9q2zzR4srFxt0gI0svBJYJ/RKVJ3im
	8WbLrZLH64nOqdzAabs7qGJrPNJJjhVXuBoN4R2PSKVjXQlKBkwAqznsSVvA6Ko2SRMEy2
	/5K0BFV+qqflem7UBxV88iXJM1l343kNi/QyyJEJ2bR9oFkP40cHtyWVWHcqTA==
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1pqaYn-0001eM-7H; Sun, 23 Apr 2023 10:19:25 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ruijie@netyu.xyz>) id 1pqaYl-0001dv-DU
 for emacs-orgmode@gnu.org; Sun, 23 Apr 2023 10:19:23 -0400
Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ruijie@netyu.xyz>) id 1pqaYj-0001ic-Ui
 for emacs-orgmode@gnu.org; Sun, 23 Apr 2023 10:19:23 -0400
Received: from fw.net.yu.netyu.xyz (<unknown> [222.248.4.98])
 by netyu.xyz (OpenSMTPD) with ESMTPSA id d1cbfa71
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sun, 23 Apr 2023 14:19:20 +0000 (UTC)
References: <D140FA73-9995-4467-963E-00D5964485C0@axelkielhorn.de>
 <sdvzg70utif.fsf@netyu.xyz> <sdvv8housn7.fsf@netyu.xyz>
 <sdvmt30um3h.fsf@netyu.xyz> <sdvedocukz1.fsf@netyu.xyz>
 <32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de>
 <sdvy1mkt0vw.fsf@netyu.xyz> <sdvh6t7tlmw.fsf@netyu.xyz>
 <37BA8B13-A49D-41A4-B752-4ED9540D5799@axelkielhorn.de>
 <sdvo7nfrs7p.fsf@netyu.xyz> <871qkau9t6.fsf@localhost>
User-agent: mu4e 1.9.22; emacs 30.0.50
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Axel Kielhorn <org-mode@axelkielhorn.de>, emacs-orgmode@gnu.org
Subject: Re: [DRAFT PATCH v4] Decouple LANG= and testing (was: Test failure
 due to LANG)
Date: Sun, 23 Apr 2023 21:57:32 +0800
In-reply-to: <871qkau9t6.fsf@localhost>
Message-ID: <sdvbkjer8c3.fsf@netyu.xyz>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@netyu.xyz;
 helo=mail.netyu.xyz
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Reply-to:  Ruijie Yu <ruijie@netyu.xyz>
From:  Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: UNKNOWN
X-Migadu-Spam-Score: -2.56
X-Spam-Score: -2.56
X-Migadu-Queue-Id: 3F87435BAD
X-Migadu-Scanner: in3.migadu.com
X-TUID: DFFlMj8/Ey9m


Ihor Radchenko <yantar92@posteo.net> writes:

> Ruijie Yu via "General discussions about Org-mode."
> <emacs-orgmode@gnu.org> writes:
>
>> Something very troublesome for me is `test-org-clock/clocktable/lang' on
>> zh_CN.UTF-8.  What I noticed is that when I run this test in batch mode
>> (one of the two methods below), it fails:
>
> Well. Batch and non-batch modes are not the same, especially wrt display
> things. And the differences are not consistent for different Emacs
> versions. This only happens for weird edge cases though. (Or when
> displaying images).

Hmm.  I guess I won't be trying to fix this particular issue then -- it
is a bit beyond my knowledge.  Thanks for explaining it.

>> +(defconst org-test-timestamp-regexp
>
> I recommend `org-element-timestamp-parser' for analysis.

Thanks for pointing that out!  I didn't realize it was there.  Although,
I don't think I can use this function as-is, nor its internal regexps:
all the relevant tests where I used `org-test-timestamp-regexp' tried to
remove the day-of-week part.  So I would need to know the region for the
day-of-week portion.  At the moment, I can't think of anything other
than making a group for DoW, and removing wrapping `save-match-data' in
`org-element-timestamp-parser' -- which is why I had those convoluted
group numbers in my `org-test-timestamp-regexp' for all portions that
one may ever want to use, hoping that nobody goes beyond defining 100
groups.

I also don't know if it is viable to integrate my full-of-`rx' and
full-of-`group-n' regexp expression into the 10s of different internal
constants representing different possible components of a timestamp.

Alternatively (and I say this very hesitantly), we could try to rewrite
all the involved tests so that we don't need to try to remove DoW from
the timestamp.  But, I haven't figured out how to do all of them (they
are also of different styles, some with repeater, some with warning
period, some are bare, etc), and there are -- I think -- around 40 of
them that needs changing.

-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]