emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Julien Danjou <julien@danjou.info>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>, Org Mode <emacs-orgmode@gnu.org>,
	Noorul Islam K M <noorul@noorul.com>
Subject: Re: Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Date: Mon, 17 Jan 2011 16:08:04 +0100	[thread overview]
Message-ID: <sa3ei8b1sbv.fsf@cigue.easter-eggs.fr> (raw)
In-Reply-To: <97009C4F-F6B7-4C54-BF3C-B3DE5EF15547@gmail.com> (Carsten Dominik's message of "Mon, 17 Jan 2011 15:39:10 +0100")


[-- Attachment #1.1.1: Type: text/plain, Size: 524 bytes --]

On Mon, Jan 17 2011, Carsten Dominik wrote:

> have you been following this thread?  I think this has to do with your
> rewrite of the dagenda span stuff.  Maybe you can find out better and
> faster that I why this goes wrong?  Please read the entire thread.

I've followed but not sure I understood what the bug is. But from my
various tries, I found a bug: when pressing 'j', the current span is
discarded.

Attached is a patch that should fix that, even for future use of
`org-agenda-list' with the span unspecified. :)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-Fix-agenda-span-on-date-jump.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]

From 9dd2fe6650b858a4083ebc083bb8d10a0d6ac7f2 Mon Sep 17 00:00:00 2001
From: Julien Danjou <julien@danjou.info>
Date: Mon, 17 Jan 2011 16:05:28 +0100
Subject: [PATCH] Fix agenda span on date jump

* org-agenda.el (org-agenda-list): Use org-agenda-current-span as a
possible default span if it is set.

Signed-off-by: Julien Danjou <julien@danjou.info>
---
 lisp/org-agenda.el |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 0cd620c..0d695b5 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'."
   (setq org-agenda-last-arguments (list include-all start-day span))
   (org-compile-prefix-format 'agenda)
   (org-set-sorting-strategy 'agenda)
-  (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-agenda-span)))
+  (let* ((span (org-agenda-ndays-to-span (or span
+					     org-agenda-current-span
+					     org-agenda-ndays
+					     org-agenda-span)))
 	 (today (org-today))
 	 (sd (or start-day today))
 	 (ndays (org-agenda-span-to-ndays span sd))
-- 
1.7.2.3


[-- Attachment #1.1.3: Type: text/plain, Size: 53 bytes --]


-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2011-01-17 15:08 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22  4:09 Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Bernt Hansen
2010-12-22  7:03 ` Noorul Islam K M
2010-12-22 12:29   ` Bernt Hansen
2011-01-14 12:34     ` Carsten Dominik
2011-01-14 16:03       ` Bernt Hansen
2011-01-14 17:29         ` Carsten Dominik
2011-01-14 17:42           ` Bernt Hansen
2011-01-17 14:27             ` Bernt Hansen
2011-01-17 14:39               ` Carsten Dominik
2011-01-17 15:08                 ` Julien Danjou [this message]
2011-01-17 16:34                   ` Julien Danjou
2011-01-17 16:43                     ` Carsten Dominik
2011-01-17 16:46                       ` Julien Danjou
2011-01-18  9:43                         ` Carsten Dominik
2011-01-18 10:00                           ` Julien Danjou
2011-01-18 10:15                             ` Carsten Dominik
2011-01-17 16:47                   ` Bernt Hansen
2011-01-17 16:54                     ` Julien Danjou
2011-01-17 17:00                       ` Bernt Hansen
2011-01-17 17:04                         ` Julien Danjou
2011-01-17 17:01                       ` Carsten Dominik
2011-01-17 17:11                     ` Julien Danjou
2011-01-17 17:14                       ` Bernt Hansen
2011-01-17 18:27                       ` [Accepted] " Bastien Guerry
2011-01-28 15:18                   ` Julien Danjou
2011-01-28 15:43                     ` Giovanni Ridolfi
2011-01-28 16:10                       ` Julien Danjou
2011-02-01 11:52                         ` Bastien
2011-02-01 11:52                   ` [Accepted] " Bastien Guerry
2011-02-05  1:20                     ` Matt Lundin
2011-02-05  8:56                       ` Julien Danjou
2011-02-07 11:39                       ` Julien Danjou
2011-02-08 17:05                         ` [Accepted] " Bastien Guerry
2011-02-09 16:37                         ` Bastien
2011-02-10  9:20                           ` Carsten Dominik
2011-02-10 10:51                             ` Julien Danjou
2011-02-10 11:50                               ` Carsten Dominik
2011-02-10 12:00                                 ` Julien Danjou
2011-02-10 14:35                                   ` Bastien
2011-02-10 21:21                                     ` Michael Brand
2011-02-17 13:57                                     ` Carsten Dominik
2011-02-17 14:43                                       ` Bastien
2011-02-18 14:19                                       ` Bastien
2011-02-18 14:46                                         ` Gábor Melis
2011-02-18 16:42                                         ` Carsten Dominik
2011-02-19  9:36                                           ` Bastien
2011-02-10 11:18                             ` Michael Brand
2011-02-10 11:55                               ` Carsten Dominik
2011-02-24 14:38                       ` Matt Lundin
2011-02-24 15:01                         ` Matt Lundin
2011-02-25  0:11                           ` Bastien
2011-02-25  0:15                             ` Bastien
2011-03-06 15:40                           ` Bastien
2011-03-06 16:47                             ` Michael Brand
2011-03-06 17:15                               ` Bastien
2011-03-06 18:26                                 ` Michael Brand
2011-03-06 18:35                                   ` Bastien
2011-03-07 18:26                             ` Matt Lundin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sa3ei8b1sbv.fsf@cigue.easter-eggs.fr \
    --to=julien@danjou.info \
    --cc=bernt@norang.ca \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=noorul@noorul.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).