From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0KQqBr5bCGCuAgAA0tVLHw (envelope-from ) for ; Wed, 20 Jan 2021 16:35:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mJ4NAr5bCGAbcQAAB5/wlQ (envelope-from ) for ; Wed, 20 Jan 2021 16:35:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 998099403AC for ; Wed, 20 Jan 2021 16:35:09 +0000 (UTC) Received: from localhost ([::1]:33286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2GRo-0004qS-Fs for larch@yhetil.org; Wed, 20 Jan 2021 11:35:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2GKH-0000lE-Pd for emacs-orgmode@gnu.org; Wed, 20 Jan 2021 11:27:24 -0500 Received: from ciao.gmane.io ([116.202.254.214]:50762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2GKG-0007Au-4l for emacs-orgmode@gnu.org; Wed, 20 Jan 2021 11:27:21 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1l2GKD-000ARl-Fd for emacs-orgmode@gnu.org; Wed, 20 Jan 2021 17:27:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file Date: Wed, 20 Jan 2021 23:27:10 +0700 Message-ID: References: <87ftazz9q0.fsf@gmail.com> <87lfho7ja2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------503677EF786D86083E6820D1" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.094, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.25 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 998099403AC X-Spam-Score: -0.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: bk4VWRx3OvUD This is a multi-part message in MIME format. --------------503677EF786D86083E6820D1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 20/01/2021 10:21, Christopher Miles wrote: > > Thanks for your working. I will modify my mailcap config temporary until Org > Mode fix this issue. You're right, this change might break some behavior of some > users. I don't understand Emacs sub-process mechanism. Can't help on this > problem. But I'm interested in this. I will take some time to study in. Anyway, > thanks for your work. Changes could be less intrusive, see another (untested) patch. However I am against shell where it is really necessary. Personally, I am not comfortable with emacs subprocess functions as well. I just tried to avoid creation of a pseudoterminal that could make some harm to GUI application. I do not know if someone uses a handler that really require terminal features. I have realized that :filter argument is not appropriate to arbitrary handler that could spam with various assert messages. Maybe :sentinel is better to report configuration problem to user when handler is called with inappropriate arguments. --------------503677EF786D86083E6820D1 Content-Type: text/x-patch; charset=UTF-8; name="org-open-file-make-process-min.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="org-open-file-make-process-min.patch" diff --git a/lisp/org.el b/lisp/org.el index 5b1443c4e..43838783b 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8765,7 +8765,9 @@ If the file does not exist, throw an error." (save-window-excursion (message "Running %s...done" cmd) - (start-process-shell-command cmd nil cmd) + (make-process :name "org-open-file" :connection-type 'pipe + :buffer "*Messages*" :noquery 't + :command (list shell-command shell-commad-switch cmd)) (and (boundp 'org-wait) (numberp org-wait) (sit-for org-wait)))) ((or (stringp cmd) (eq cmd 'emacs)) --------------503677EF786D86083E6820D1--