org-bbdb and 1. March

org-bbdb and 1. March

[Tom Rauchenwald]

Hi,

I noticed a bug with org-bbdb. If I enter a anniversary for the 1st of
March, org doesn't show it in the agenda and complains with "Bad sexp at
line 9 in /home/sec/org/geburtstage.org: (org-bbdb-anniversaries)"

It seems to have to do with the special-casing of the 29th of February
in leap-years, i.e. when I comment the following lines:

,----
|     ;; we don't want to miss people born on Feb. 29th
|     (when (and (= m 3) (= d 1) (not (calendar-leap-year-p y)))
|       (setq annivs (cons annivs (gethash (list 2 29) org-bbdb-anniv-hash))))
`----

the bug goes away.

Thanks,
Tom

-- 
Last week, Japanese scientists explaced... placed explosive detonators
at the bottom of Lake Loch Ness to blow Nessie out of the water. 
	-- Napoleon Dynamite

Re: org-bbdb and 1. March

[Thomas Baumann]

confirmed, thanks for reporting.
Carsten surely will checkin the following patch soon.

Thomas

diff --git a/lisp/org-bbdb.el b/lisp/org-bbdb.el
index ad5265f..044b74b 100644
--- a/lisp/org-bbdb.el
+++ b/lisp/org-bbdb.el
@@ -291,11 +291,16 @@ This is used by Org to re-create the anniversary hash table."
          (y (nth 2 date))  ; year
          (annivs (gethash (list m d) org-bbdb-anniv-hash))
          (text ())
-         split class form rec)
+         split class form rec recs)
     
     ;; we don't want to miss people born on Feb. 29th
-    (when (and (= m 3) (= d 1) (not (calendar-leap-year-p y)))
-      (setq annivs (cons annivs (gethash (list 2 29) org-bbdb-anniv-hash))))
+    (when (and (= m 3) (= d 1)
+               (not (null (gethash (list 2 29) org-bbdb-anniv-hash)))
+               (not (calendar-leap-year-p y)))
+      (setq recs (gethash (list 2 29) org-bbdb-anniv-hash))
+      (while (setq rec (pop recs))
+        (push rec annivs)))
+

Re: Re: org-bbdb and 1. March

[Carsten Dominik]

Applied, thanks.

- Carsten

On Oct 6, 2008, at 6:45 PM, Thomas Baumann wrote:

> confirmed, thanks for reporting.
> Carsten surely will checkin the following patch soon.
>
> Thomas
>
> diff --git a/lisp/org-bbdb.el b/lisp/org-bbdb.el
> index ad5265f..044b74b 100644
> --- a/lisp/org-bbdb.el
> +++ b/lisp/org-bbdb.el
> @@ -291,11 +291,16 @@ This is used by Org to re-create the  
> anniversary hash table."
>          (y (nth 2 date))  ; year
>          (annivs (gethash (list m d) org-bbdb-anniv-hash))
>          (text ())
> -         split class form rec)
> +         split class form rec recs)
>
>     ;; we don't want to miss people born on Feb. 29th
> -    (when (and (= m 3) (= d 1) (not (calendar-leap-year-p y)))
> -      (setq annivs (cons annivs (gethash (list 2 29) org-bbdb-anniv- 
> hash))))
> +    (when (and (= m 3) (= d 1)
> +               (not (null (gethash (list 2 29) org-bbdb-anniv-hash)))
> +               (not (calendar-leap-year-p y)))
> +      (setq recs (gethash (list 2 29) org-bbdb-anniv-hash))
> +      (while (setq rec (pop recs))
> +        (push rec annivs)))
> +
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: org-bbdb and 1. March

[Tom Rauchenwald]

Thomas Baumann <dtbaumann@yahoo.de> writes:

> confirmed, thanks for reporting.
> Carsten surely will checkin the following patch soon.

Works fine now, thanks for fixing this so quickly.

> Thomas

Tom