emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-agenda-tags-column does not work anymore [9.1.12 (release_9.1.12-677-g4c13d0 @ /Users/xcy/src/org-mode/lisp/)]
@ 2018-04-29  4:10 Xu Chunyang
  2018-04-29  8:00 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Xu Chunyang @ 2018-04-29  4:10 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

I'm using latest Org mode built from latest git repository, the HEAD
is 4c13d0a1a870a450627ce1d8449a3b7204202250. I notice tags are no longer
aligned in *Org Agenda*.

It seems the issue is introduced by

    e87ebca2a755620a13a49cc748ba987b17d2d64d Use `org-tag-line-re'

and the following patch fixes it for me

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 342ea06b7..2ad09c1ad 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -9003,7 +9003,7 @@ If FORCE-TAGS is non nil, the car of it returns the new tags."
 	l c)
     (save-excursion
       (goto-char (if line (line-beginning-position) (point-min)))
-      (while (re-search-forward org-tag-line-re (and line (line-end-position)) t)
+      (while (re-search-forward org-tag-group-re (and line (line-end-position)) t)
 	(add-text-properties
 	 (match-beginning 1) (match-end 1)
 	 (list 'face (delq nil (let ((prop (get-text-property

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Bug: org-agenda-tags-column does not work anymore [9.1.12 (release_9.1.12-677-g4c13d0 @ /Users/xcy/src/org-mode/lisp/)]
  2018-04-29  4:10 Bug: org-agenda-tags-column does not work anymore [9.1.12 (release_9.1.12-677-g4c13d0 @ /Users/xcy/src/org-mode/lisp/)] Xu Chunyang
@ 2018-04-29  8:00 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2018-04-29  8:00 UTC (permalink / raw)
  To: Xu Chunyang; +Cc: emacs-orgmode

Hello,

Xu Chunyang <mail@xuchunyang.me> writes:

> I'm using latest Org mode built from latest git repository, the HEAD
> is 4c13d0a1a870a450627ce1d8449a3b7204202250. I notice tags are no longer
> aligned in *Org Agenda*.
>
> It seems the issue is introduced by
>
>     e87ebca2a755620a13a49cc748ba987b17d2d64d Use `org-tag-line-re'
>
> and the following patch fixes it for me

Indeed. Funnily, I read this function a couple of times without catching
this.

Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-29  8:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-29  4:10 Bug: org-agenda-tags-column does not work anymore [9.1.12 (release_9.1.12-677-g4c13d0 @ /Users/xcy/src/org-mode/lisp/)] Xu Chunyang
2018-04-29  8:00 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).