From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chunyang Xu <mail@xuchunyang.me>
Subject: Re: Bug: Can't execute C code block from remote directory [9.0.5
 (release_9.0.5-401-g86ff11 @ /Users/xcy/src/org-mode/lisp/)]
Date: Wed, 05 Apr 2017 19:49:53 +0800
Message-ID: <m2shln13by.fsf@xuchunyang.me>
References: <m2wpb4duf1.fsf@xuchunyang.me> <m2o9wern8r.fsf@xuchunyang.me>
	<87wpazz32k.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54950)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@xuchunyang.me>) id 1cvjS2-0004lw-SX
	for emacs-orgmode@gnu.org; Wed, 05 Apr 2017 07:50:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@xuchunyang.me>) id 1cvjRz-0006YW-R7
	for emacs-orgmode@gnu.org; Wed, 05 Apr 2017 07:50:14 -0400
Received: from smtpbgau1.qq.com ([54.206.16.166]:43253)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@xuchunyang.me>) id 1cvjRz-0006SK-5I
	for emacs-orgmode@gnu.org; Wed, 05 Apr 2017 07:50:11 -0400
In-reply-to: <87wpazz32k.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org


Nicolas Goaziou writes:

> Hello,
>
> Chunyang Xu <mail@xuchunyang.me> writes:
>
>> Here is a patch which can fix the issue.
>
> Thank you.
>
>> From e42b22f74c2f04a4d8e7eec0a6bdacbd08bebf12 Mon Sep 17 00:00:00 2001
>> From: Chunyang Xu <mail@xuchunyang.me>
>> Date: Mon, 3 Apr 2017 14:46:51 +0800
>> Subject: [PATCH] ob-C: Fix remote executing
>>
>> * lisp/ob-C.el (org-babel-C-execute): Process remote bin file.
>>
>> TINYCHANGE
>> ---
>>  lisp/ob-C.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/ob-C.el b/lisp/ob-C.el
>> index 795bcb2b7..e54e17492 100644
>> --- a/lisp/ob-C.el
>> +++ b/lisp/ob-C.el
>> @@ -161,7 +161,7 @@ or `org-babel-execute:C++' or `org-babel-execute:D'."
>>  	   (org-babel-eval
>>  	    (pcase org-babel-c-variant
>>  	      ((or `c `cpp)
>> -	       (concat tmp-bin-file cmdline))
>> +	       (concat (org-babel-process-file-name tmp-bin-file) cmdline))
>
> I see that `tmp-bin-file' is used a couple other times in the body.
> Would it make sense to wrap the initial binding within
> `org-babel-process-file-name' instead of doing it only for this
> occurrence?

Both ways look OK to me. `tmp-bin-file' is used only twice and invoking
`org-babel-process-file-name' is cheap. And converting `tmp-bin-file'
from remote to local name only when 100% necessary (i.e. within
`org-babel-eval') looks more logical to me. On the other hand,
`tmp-bin-file' as a remote file name is useless, thus the way you
suggested is reasonable as well.

> Regards,