[PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib

[PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib

[Aimé Bertrand]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

Bonjour,

org-mac-link was removed from org-contrib with 
https://git.sr.ht/~bzg/org-contrib/commit/c6aef31ccfc7c4418c3b51e98f7c3bd8e255f5e6.

This is a patch (attached) for Worg to reflect the changes.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Reflect-the-removal-of-org-mac-link.el-from-org-cont.patch --]
[-- Type: text/x-patch, Size: 4709 bytes --]

From a15e9ba318ce6e13b2b405bc8a5067ee2e80d787 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aim=C3=A9=20Bertrand?= <aime.bertrand@macowners.club>
Date: Wed, 29 Jun 2022 18:10:59 +0200
Subject: [PATCH] Reflect the removal of org-mac-link.el from org-contrib

* org-contrib/index.org: Remove listing of org-mac-link.el
* org-contrib/org-mac-link.org: deleted
* org-mac.org: Update package URL
---
 org-contrib/index.org        |  8 ------
 org-contrib/org-mac-link.org | 55 ------------------------------------
 org-mac.org                  |  7 +----
 3 files changed, 1 insertion(+), 69 deletions(-)
 delete mode 100644 org-contrib/org-mac-link.org

diff --git a/org-contrib/index.org b/org-contrib/index.org
index 308168fc..ca3052f1 100644
--- a/org-contrib/index.org
+++ b/org-contrib/index.org
@@ -110,14 +110,6 @@ the package -- it will hopefully have some documentation.
   Written by /Christopher Suckling/.
   [[contribfile:lisp/org-mac-iCal.el][Link to raw file]].
 
-- [[file:org-mac-link.org][/org-mac-link.el/ -- grab links from various mac applications]] ::
-  Grab the current link or selection from an open mac application and
-  insert it as a hyperlink at point in an org-mode document. Written
-  by /Anthony Lander/, /John Wiegley/ and /Christopher Suckling/.
-  This file replaces the earlier org-mac-message.el and
-  org-mac-link-grabber.el.
-  [[contribfile:lisp/org-mac-link.el][Link to raw file]].
-
 - /org-mairix.el/ -- hook mairix search into Org for different MUAs ::
   Written by /Georg C. F. Greve/.
   [[contribfile:lisp/org-mairix.el][Link to raw file]].
diff --git a/org-contrib/org-mac-link.org b/org-contrib/org-mac-link.org
deleted file mode 100644
index 2b2582e9..00000000
--- a/org-contrib/org-mac-link.org
+++ /dev/null
@@ -1,55 +0,0 @@
-#+TITLE:     org-mac-link.el -- Grab links from open Mac applications
-#+OPTIONS:   ^:{} author:nil
-#+STARTUP: odd
-#+HTML_LINK_UP:    index.html
-#+HTML_LINK_HOME:  https://orgmode.org/worg/
-
-# This file is released by its authors and contributors under the GNU
-# Free Documentation license v1.3 or later, code examples are released
-# under the GNU General Public License v3 or later.
-
-* Overview 
-
-  This code will allow you to grab the current link or selection from
-  an open mac application and insert it as a hyperlink at point in an
-  org-mode document.
-
-*** Supported Applications
-
-    The following applications are currently supported:
-    - Finder.app
-    - Mail.app
-    - Address Book.app
-    - Safari.app
-    - Skim.app
-    - Firefox.app
-    - Firefox.app with the Vimperator plugin
-    - Google Chrome.app
-    - Together.app
-          
-* Installation
-  
-  Customize the org group by typing =M-x customize-group RET org RET=, then
-  expand the /Modules/ section, and enable =mac-link=.
-
-  You may also optionally bind a key to activate the link grabber menu, like
-  this:
-
-  : (add-hook 'org-mode-hook (lambda () 
-  :   (define-key org-mode-map (kbd "C-c g") 'org-mac-grab-link)))
-
-* Usage
-
-  Activate the grabber by typing =C-c g= (or whatever key you decided to bind,
-  as above), or type =M-x org-mac-grab-link RET=. This will give you a menu in
-  the modeline allowing you to select an application. The current selection in
-  that application will be inserted at point as a hyperlink in your org-mode
-  document.
-
-* Customizing
-
-  You may customize which applications appear in the grab menu by customizing
-  the group /org-mac-link/. Changes take effect immediately. If you are using
-  the org-mode version >=8.2, you can also customize whether the
-  =org-mac-link= should highlight the selected text when grabbing the link from
-  Skim.app.
diff --git a/org-mac.org b/org-mac.org
index e5721eca..3c99e2f1 100644
--- a/org-mac.org
+++ b/org-mac.org
@@ -27,15 +27,10 @@ applications other than Emacs...
 ** [[file:org-contrib/org-mac-iCal.org][org-mac-iCal]] -- import OS X iCal.app events into Emacs diary
    Written by /Christopher Suckling/.
 
-** [[file:org-contrib/org-mac-link.org][org-mac-link]] -- Hyperlink to items in mac applications
-   grab the current link or selection from an open mac application and
-   insert it as a hyperlink at point in an org-mode document. Written
-   by /Anthony Lander/.
-
 ** [[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] -- Hyperlink to messages in Mail.app
    A small elisp file that addresses linking to Mail.app messages
    directly via the =org-capture= system. For wider application
-   support check out [[file:org-contrib/org-mac-link.org][org-mac-link]].
+   support check out [[https://gitlab.com/aimebertrand/org-mac-link][org-mac-link]].
 
 * For use outside Emacs
 
-- 
2.32.1 (Apple Git-133)


[-- Attachment #3: Type: text/plain, Size: 63 bytes --]



Salut

--
Aimé Bertrand
aime.bertrand@macowners.club

Re: [PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib

[Ihor Radchenko]

Aimé Bertrand <aime.bertrand@macowners.club> writes:

> org-mac-link was removed from org-contrib with 
> https://git.sr.ht/~bzg/org-contrib/commit/c6aef31ccfc7c4418c3b51e98f7c3bd8e255f5e6.
>
> This is a patch (attached) for Worg to reflect the changes.

Thanks for the patch!

> --- a/org-contrib/index.org
> +++ b/org-contrib/index.org
> @@ -110,14 +110,6 @@ the package -- it will hopefully have some documentation.
>    Written by /Christopher Suckling/.
>    [[contribfile:lisp/org-mac-iCal.el][Link to raw file]].
>  
> -- [[file:org-mac-link.org][/org-mac-link.el/ -- grab links from various mac applications]] ::
> -  Grab the current link or selection from an open mac application and
> -  insert it as a hyperlink at point in an org-mode document. Written
> -  by /Anthony Lander/, /John Wiegley/ and /Christopher Suckling/.
> -  This file replaces the earlier org-mac-message.el and
> -  org-mac-link-grabber.el.
> -  [[contribfile:lisp/org-mac-link.el][Link to raw file]].

Rather than removing the package description completely, it should be
moved to the External section.

> diff --git a/org-contrib/org-mac-link.org b/org-contrib/org-mac-link.org
> deleted file mode 100644
> index 2b2582e9..00000000
> --- a/org-contrib/org-mac-link.org
> +++ /dev/null

I have looked into README.org in
https://gitlab.com/aimebertrand/org-mac-link and I notice that it
contains less information compared to org-mac-link.org. It would be
useful to provide the missing details in the new README.org if you plan
to maintain the documentation there instead of WORG.

> -** [[file:org-contrib/org-mac-link.org][org-mac-link]] -- Hyperlink to items in mac applications
> -   grab the current link or selection from an open mac application and
> -   insert it as a hyperlink at point in an org-mode document. Written
> -   by /Anthony Lander/.
> -
>  ** [[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] -- Hyperlink to messages in Mail.app
>     A small elisp file that addresses linking to Mail.app messages
>     directly via the =org-capture= system. For wider application
> -   support check out [[file:org-contrib/org-mac-link.org][org-mac-link]].
> +   support check out [[https://gitlab.com/aimebertrand/org-mac-link][org-mac-link]].

[[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] is not
changed and will become dead line after applying this patch.

Best,
Ihor

Re: [PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib

[Aimé Bertrand]

[-- Attachment #1: Type: text/plain, Size: 2930 bytes --]

Hi Ihor,

> Aimé Bertrand <aime.bertrand@macowners.club> writes:
>
>> org-mac-link was removed from org-contrib with
>> https://git.sr.ht/~bzg/org-contrib/commit/c6aef31ccfc7c4418c3b51e98f7c3bd8e255f5e6.
>>
>> This is a patch (attached) for Worg to reflect the changes.
>
> Thanks for the patch!
>
>> --- a/org-contrib/index.org
>> +++ b/org-contrib/index.org
>> @@ -110,14 +110,6 @@ the package -- it will hopefully have some 
>> documentation.
>>    Written by /Christopher Suckling/.
>>    [[contribfile:lisp/org-mac-iCal.el][Link to raw file]].
>>
>> -- [[file:org-mac-link.org][/org-mac-link.el/ -- grab links 
>> from various mac applications]] ::
>> -  Grab the current link or selection from an open mac 
>> application and
>> -  insert it as a hyperlink at point in an org-mode 
>> document. Written
>> -  by /Anthony Lander/, /John Wiegley/ and /Christopher 
>> Suckling/.
>> -  This file replaces the earlier org-mac-message.el and
>> -  org-mac-link-grabber.el.
>> -  [[contribfile:lisp/org-mac-link.el][Link to raw file]].
>
> Rather than removing the package description completely, it 
> should be
> moved to the External section.

Took your advice and moved the package description to the External 
section.


>
>> diff --git a/org-contrib/org-mac-link.org 
>> b/org-contrib/org-mac-link.org
>> deleted file mode 100644
>> index 2b2582e9..00000000
>> --- a/org-contrib/org-mac-link.org
>> +++ /dev/null
>
> I have looked into README.org in
> https://gitlab.com/aimebertrand/org-mac-link and I notice that 
> it
> contains less information compared to org-mac-link.org. It would 
> be
> useful to provide the missing details in the new README.org if 
> you plan
> to maintain the documentation there instead of WORG.
>

Left the documentation here and updated page to reflect the 
changes to the package.
Also Added URLs to external sources.

>> -** [[file:org-contrib/org-mac-link.org][org-mac-link]] -- 
>> Hyperlink to items in mac applications
>> -   grab the current link or selection from an open mac 
>> application and
>> -   insert it as a hyperlink at point in an org-mode 
>> document. Written
>> -   by /Anthony Lander/.
>> -
>>  ** 
>>  [[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] 
>>  -- Hyperlink to messages in Mail.app
>>     A small elisp file that addresses linking to Mail.app 
>>     messages
>>     directly via the =org-capture= system. For wider 
>>     application
>> -   support check out 
>> [[file:org-contrib/org-mac-link.org][org-mac-link]].
>> +   support check out 
>> [[https://gitlab.com/aimebertrand/org-mac-link][org-mac-link]].
>
> [[file:org-contrib/org-mac-mail-link.org][org-mac-mail-link]] is 
> not
> changed and will become dead line after applying this patch.
>

Left the page here. There shouldn't be any dead lines after the 
patch.

New patch file attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Reflect-the-removal-of-org-mac-link.el-from-org-cont.patch --]
[-- Type: text/x-patch, Size: 4309 bytes --]

From 6d3e5b319670574fb47a74ed3139990077190406 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aim=C3=A9=20Bertrand?= <aime.bertrand@macowners.club>
Date: Thu, 30 Jun 2022 18:55:34 +0200
Subject: [PATCH] Reflect the removal of org-mac-link.el from org-contrib

* org-contrib/index.org: move org-mac-link.el to external section
* org-contrib/org-mac-link.org: Add more supported Apps.
Add URL to Repo.
Add MELPA URL.
---
 org-contrib/index.org        | 16 ++++++++--------
 org-contrib/org-mac-link.org | 26 ++++++++++++++++++--------
 2 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/org-contrib/index.org b/org-contrib/index.org
index 308168fc..1d329475 100644
--- a/org-contrib/index.org
+++ b/org-contrib/index.org
@@ -110,14 +110,6 @@ the package -- it will hopefully have some documentation.
   Written by /Christopher Suckling/.
   [[contribfile:lisp/org-mac-iCal.el][Link to raw file]].
 
-- [[file:org-mac-link.org][/org-mac-link.el/ -- grab links from various mac applications]] ::
-  Grab the current link or selection from an open mac application and
-  insert it as a hyperlink at point in an org-mode document. Written
-  by /Anthony Lander/, /John Wiegley/ and /Christopher Suckling/.
-  This file replaces the earlier org-mac-message.el and
-  org-mac-link-grabber.el.
-  [[contribfile:lisp/org-mac-link.el][Link to raw file]].
-
 - /org-mairix.el/ -- hook mairix search into Org for different MUAs ::
   Written by /Georg C. F. Greve/.
   [[contribfile:lisp/org-mairix.el][Link to raw file]].
@@ -299,6 +291,14 @@ See [[file:../exporters/index.org][Exporters]].
 - [[http://ozymandias.dk/emacs/org-import-calendar.el][/org-import-icalendar.el/]] -- import iCal events in an Org buffer ::
   Written by /Vagn Johansen/.
 
+- [[file:org-mac-link.org][/org-mac-link/ -- grab links from various mac applications]] ::
+  Grab the current link or selection from an open mac application and
+  insert it as a hyperlink at point in an org-mode document. Written
+  by /Anthony Lander/, /John Wiegley/ and /Christopher Suckling/.
+  This file replaces the earlier org-mac-message.el and
+  org-mac-link-grabber.el.
+  [[https://gitlab.com/aimebertrand/org-mac-link][project page]].
+
 - [[https://github.com/sigma/org-magit][/org-magit/]] -- basic support for [[https://github.com/magit/magit][magit]] links ::
   Written by /Yann Hodique/.
 
diff --git a/org-contrib/org-mac-link.org b/org-contrib/org-mac-link.org
index 2b2582e9..b06b8f0c 100644
--- a/org-contrib/org-mac-link.org
+++ b/org-contrib/org-mac-link.org
@@ -8,7 +8,7 @@
 # Free Documentation license v1.3 or later, code examples are released
 # under the GNU General Public License v3 or later.
 
-* Overview 
+* Overview
 
   This code will allow you to grab the current link or selection from
   an open mac application and insert it as a hyperlink at point in an
@@ -25,23 +25,33 @@
     - Firefox.app
     - Firefox.app with the Vimperator plugin
     - Google Chrome.app
+    - Brave.app
+    - Microsoft Outlook.app
     - Together.app
-          
+    - DEVONthink Pro Office.app
+    - Evernote.app
+    - qutebrowser.app
+
 * Installation
-  
-  Customize the org group by typing =M-x customize-group RET org RET=, then
-  expand the /Modules/ section, and enable =mac-link=.
+
+  Org-mac-link has its own repository [[https://gitlab.com/aimebertrand/org-mac-link][on GitLab]].
+
+  It's also available in [[https://melpa.org/#/org-mac-link][MELPA]].
+
+* Customizing
+
+  Customize the org group by typing =M-x customize-group RET org-mac-link RET=.
 
   You may also optionally bind a key to activate the link grabber menu, like
   this:
 
-  : (add-hook 'org-mode-hook (lambda () 
-  :   (define-key org-mode-map (kbd "C-c g") 'org-mac-grab-link)))
+  : (add-hook 'org-mode-hook (lambda ()
+  :   (define-key org-mode-map (kbd "C-c g") 'org-mac-link-get-link)))
 
 * Usage
 
   Activate the grabber by typing =C-c g= (or whatever key you decided to bind,
-  as above), or type =M-x org-mac-grab-link RET=. This will give you a menu in
+  as above), or type =M-x org-mac-link-get-link RET=. This will give you a menu in
   the modeline allowing you to select an application. The current selection in
   that application will be inserted at point as a hyperlink in your org-mode
   document.
-- 
2.32.1 (Apple Git-133)


[-- Attachment #3: Type: text/plain, Size: 82 bytes --]



> Best,
> Ihor

Salut

--
Aimé Bertrand
aime.bertrand@macowners.club

Re: [PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib

[Ihor Radchenko]

Aimé Bertrand <aime.bertrand@macowners.club> writes:

> New patch file attached.

Thanks!
Applied onto master via aeb504f6.

> +  It's also available in [[https://melpa.org/#/org-mac-link][MELPA]].

Is there any reason why you did not publish on non-GNU ELPA?

Best,
Ihor

Re: [PATCH] worg - Reflect the removal of org-mac-link.el from org-contrib

[Aimé Bertrand]

> Is there any reason why you did not publish on non-GNU ELPA?

Would rather publish there as well. However I am more familiar 
with MELPA for now.
I fully intend to move to non-GNU asap though.

>
> Best,
> Ihor

Salut

--
Aimé Bertrand
aime.bertrand@macowners.club