Re: [BUG] [ODT] Annotations break paragraphs

[Christian Moe <mail@christianmoe.com>]

Hi again,

While we're at it, there's trouble with custom author and date info in
annotations. I hadn't really noticed, since my name was inserted anyway
and dates didn't matter much to my work.

1. Author and date attributes of the annotation are ignored, unless I'm
writing them wrong (I've tried three syntaxes -- below the
signature). My name is used for the authorname, whatever I put as
:author in the #+begin_annotation line. No date is found.

2. In LibreOffice the annotations all say "no date", and indeed, no date
(<dc:date> element) is inserted at all. Maybe it should be. When I
remove the condition testing for a date "(and date <...>)", all the
annotations get stamped with the time of export if the exporter doesn't
find any other date. That was the behavior of the old exporter. It's
debatable whether it's the right thing to do, but I saw it as a feature,
saving work to insert timestamps.

Yours,
Christian

Here's what I've tried for the author/date attributes.

This is the syntax originally used when Jambunathan introduced the feature:

There is an annotation by a reviewer - "Someone else" - here.
#+begin_annotation author "Someone else" date "<2011-10-22 Wed 15:43>"
Yes I do.
#+end_annotation

I have tried these as well:

There is an annotation by a reviewer - "Someone else" - here.
#+begin_annotation :author "Someone else" :date "<2011-10-22 Wed 15:43>"
Yes I do.
#+end_annotation

There is an annotation by a reviewer - "Someone else" - here.
#+begin_annotation :author Someone else :date <2011-10-22 Wed 15:43>
Yes I do.
#+end_annotation



Christian Moe writes:

> Nicolas Goaziou writes:
>>> Minor cosmetic annoyance: An extra space is inserted
>>> before the annotation.
>>>
>>> Pending the introduction of a dedicated syntax, could we have this fix
>>> in master please?
>>
>> Sure, but, if it's not too much work, I'd like the extra space removed
>> first. Do you have an idea about the XML reason behind this?
>
> Yes, there's a newline inserted before the opening <office:annotation>
> tag. I guess that since it's inside a <text:p> tag, it gets interpreted
> as whitespace that's part of the text, and collapsed to a space. But the
> newline is only there to make the XML more readable, so it's expendable.
>
> Sorry, I really could have taken the ten minutes to investigate that
> before my previous message.
>
> Yours,
> Christian