emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Stephen J. Eglen" <stephen@eglen.org.uk>
To: emacs-orgmode@gnu.org
Cc: mail@nicolasgoaziou.fr
Subject: Bug report for ox-icalendar: newlines should be CRLF
Date: Fri, 06 Jan 2023 08:30:41 +0000	[thread overview]
Message-ID: <m2bknc12kv.fsf@cam.ac.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

Hello,

If I have a test file

----------------------------------------------------------------------

* test 1

<2023-01-05 Thu 19:00-19:20>

----------------------------------------------------------------------


and then convert to an .ics file using C-c C-e c f

I get the attached test.ics file, but copied here too:

BEGIN:VCALENDAR
VERSION:2.0
X-WR-CALNAME:test
PRODID//Stephen J. Eglen//Emacs with Org mode//EN
X-WR-TIMEZONE:GMT
X-WR-CALDESC:
CALSCALE:GREGORIAN
BEGIN:VEVENT ***
DTSTAMP:20230105T221431Z ***
UID:TS1-81DE7E9C-0385-49CE-8528-C2FD51372CB4 ***
DTSTART:20230105T190000Z ***
DTEND:20230105T192000Z ***
SUMMARY:test 1 ***
DESCRIPTION:<2023-01-05 Thu 19:00>–<2023-01-05 Thu 19:20> ***
CATEGORIES:test ***
END:VEVENT
END:VCALENDAR

The lines from BEGIN:VEVENT to CATEGORIES:test inclusive have CR (^M) as well
as LF (^J) as newline [in the text above, I've converted the ^M to ***
to see them eaer.  Is that intended?  Uploading the file to
https://icalendar.org/validator.html gives me the error

> Lines not delimited by CRLF sequence near line # 1
> Reference: RFC 5545 3.1. Content Lines

Nicolas (cc'ed) has confirmed that it seems to be a problem.  Before I
work slowly on a suggested patch, does anyone have an idea on the best
way forward?  Is it possible to encode the file as "DOS" ,using
something like set-buffer-file-coding-system?  SOme lines do however
have \r and \n see e.g. org-icalendar-fold-string which inserts both \r
and \n




Best wishes, Stephen



[-- Attachment #2: test.ics --]
[-- Type: application/octet-stream, Size: 404 bytes --]

BEGIN:VCALENDAR
VERSION:2.0
X-WR-CALNAME:test
PRODID:-//Stephen J. Eglen//Emacs with Org mode//EN
X-WR-TIMEZONE:GMT
X-WR-CALDESC:
CALSCALE:GREGORIAN
BEGIN:VEVENT
DTSTAMP:20230105T221431Z
UID:TS1-81DE7E9C-0385-49CE-8528-C2FD51372CB4
DTSTART:20230105T190000Z
DTEND:20230105T192000Z
SUMMARY:test 1
DESCRIPTION:<2023-01-05 Thu 19:00>–<2023-01-05 Thu 19:20>
CATEGORIES:test
END:VEVENT
END:VCALENDAR

             reply	other threads:[~2023-01-08  7:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  8:30 Stephen J. Eglen [this message]
2023-01-08  8:50 ` Bug report for ox-icalendar: newlines should be CRLF Detlef Steuer
2023-02-01 14:51 ` Ihor Radchenko
2023-04-02 20:42   ` Jack Kamm
2023-04-03  8:09     ` Stephen J. Eglen
2023-04-14 10:13       ` Ihor Radchenko
2023-04-14 10:45         ` tomas
2023-04-14 16:38           ` Jack Kamm
2023-04-16  5:01             ` Jack Kamm
2024-01-12 13:54               ` Ihor Radchenko
2023-04-15  9:07           ` Stephen J. Eglen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bknc12kv.fsf@cam.ac.uk \
    --to=stephen@eglen.org.uk \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).