From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wFq7FboXYGHN4wAAgWs5BA (envelope-from ) for ; Fri, 08 Oct 2021 12:04:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AD11EboXYGHMfwAAbx9fmQ (envelope-from ) for ; Fri, 08 Oct 2021 10:04:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFEC6164F3 for ; Fri, 8 Oct 2021 12:04:41 +0200 (CEST) Received: from localhost ([::1]:50586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYmk4-00042y-SE for larch@yhetil.org; Fri, 08 Oct 2021 06:04:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYmix-00040I-G5 for emacs-orgmode@gnu.org; Fri, 08 Oct 2021 06:03:31 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:34375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYmiu-0001ot-KH for emacs-orgmode@gnu.org; Fri, 08 Oct 2021 06:03:31 -0400 Received: by mail-wr1-x42f.google.com with SMTP id t8so28226861wri.1 for ; Fri, 08 Oct 2021 03:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=wertv/ExWwhdbrfBDLci3PMFIZL41sbydSJf3slSOVQ=; b=IWoyei5Xz9q/mBzd9cKhjjGijewHtqgyTJQM7QGkQV6Grr7lBUXUdkPtCwwmE+4ST/ RVkJPiFv9OzJqz7x+jmXDQw8lHW6oN7CoeRRgO+YTbgVaLeBhRzni8v5VTFOBLNQTaG4 dnfwUFeV90WOyChqJeYjs6lsQu8kcj0sixWjbSCIoXDl3I6lHjsJq59ChRDGCbVVZ8PL kE6hkLmAO4ZseSBKZet1DURNkiZeG9zeXySED/+oo0DlWsUaaFyHZksXBI1xrs9DcRg1 HEQxY5HpViUG0VFvvKd3AObO20tTHoyTTXljmAz7JGJrZ5fqb1EgKqXRXZxdL75rMidy 4phw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wertv/ExWwhdbrfBDLci3PMFIZL41sbydSJf3slSOVQ=; b=fB43szjhOEEyhF5HNITSh0p4Yk//VfTpr4CbzmVFs2ucUNh4mOvw1P3SLznEteSNnL w66Py6U9MqEdOH1vjA0d2dAVQvYcjtgkGicrihNEKmLO5Fb2i7QRt3e+oN95f2drxoI5 Y4FqkQi51zlqColDkL4ULbVgA8Qb1zunXXUoV39Eq1z6oFgsxEB42BkVxGqIGmVHmEiz EDu0vNG5DIiuIBzaZgcMGkeYS8ZmPJLzsEwOUjvUKN5GToNmRolUHN2yqKWRJAyRDhNY rIUrQkMNKtSMDNiAxDEF0G8baMocTPpEDroK/ymK/wi6unBL+IZ2Pip9JO6QLwBY6vUK DZQQ== X-Gm-Message-State: AOAM530yGjhl+2OKvYwvAiKv/KpAiWaEFmzrXvZBOHWciSZR81JlhxHE OoDa0X2uXDbFfIYW58H8zdzf8YZmCZ/dhA== X-Google-Smtp-Source: ABdhPJz7fQdwKShYcWDyG/vPDfTlWR485CaaG6seO90W+jn9MRfZP12b+yQtMJWYSMz6hYXECjol1w== X-Received: by 2002:adf:a505:: with SMTP id i5mr2876994wrb.38.1633687406761; Fri, 08 Oct 2021 03:03:26 -0700 (PDT) Received: from Home-Mac ([141.226.10.39]) by smtp.gmail.com with ESMTPSA id p18sm1924962wrt.96.2021.10.08.03.03.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 03:03:26 -0700 (PDT) From: Daniel Fleischer To: emacs-orgmode@gnu.org Subject: [PATCH] Bug: Tag Selection Face Doesn't Toggle References: Date: Fri, 08 Oct 2021 13:03:23 +0300 In-Reply-To: (Daniel Fleischer's message of "Wed, 06 Oct 2021 17:48:39 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=danflscr@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633687481; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wertv/ExWwhdbrfBDLci3PMFIZL41sbydSJf3slSOVQ=; b=LSVM4jqcQKFYCYDz7Sgp2p1tCSENuJtdaxNSEs1hPx7qKmQ2+mJdWIkH/rlJfMauMInGDM jwFX8bQTgAAO5CsHmAxqovRIAc6MNGwv5YbPVtIYuqEX33xrE9t5Ja2fgGEZxBYzaF4pAb gPmdC96UQGT+AdPu9R1MPMbgGFj1sqaYu4Xz+I0yjQM7RD9TpYHCiIQpi/4nhKO4dJpVH4 0A7grtKeJLo0YnlZKXl5tkjiETAVAk0GUb4r4q4TMDC+WQj64MJHNryz0JTo9g2J6qC7I2 yPB54/bZYpYrEBKdIBTGO7ozpNSfd4YU6X0royAVU9PIrfe38cQVNuheFxSlTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633687481; a=rsa-sha256; cv=none; b=hC1DRPPMDJS1WhaI06B8I7EHuEhPgJ6rKqHe2UdRA/OMLrq0bSiXGG9ZiVpSQ8xP2nJK8C u0pyi3DBdqmp7xS1d4/37S7Hb6Axag9jCI6Xnvb+2q+u008YZQGnKHnJSsvqfbDe9bl5Q0 K5gtZHY4PllVsd1eymSG3FkUz0TK84Z74QFqLVbH1Cn0XU0o5/+sgXKKrA/4aJ50Gxrbk8 LNPhphcuf5PRknjZq98NIDwgdq78YzvyFBWu9vWNynUWsa81iQkj6kWWZhwCesd0jE9Nkk OIe6CmuJoq5GUwKJiGWua24QuGQ6SAGrtu0FVpaGim7DgVjHG/6ugcaYdzJ4NQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IWoyei5X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IWoyei5X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: CFEC6164F3 X-Spam-Score: -2.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: H2WVYTHXit/U --=-=-= Content-Type: text/plain Daniel Fleischer writes: > Hi, when selecting tags using fast selection and then de-selecting, the > face doesn't toggle back to regular face. > > Fast selection means `org-use-fast-tag-selection' is t. See attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-org.el-fast-tag-selection-disabled-tag-face.patch Content-Description: Patch >From 0352757d7012dc543bae4039deaed7bbd401bb9f Mon Sep 17 00:00:00 2001 From: Daniel Fleischer Date: Fri, 8 Oct 2021 12:55:04 +0300 Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face A tag can be either selected in "current", "inherited" or disabled. When disabled, it should have the 'org-default face. Previously, if a tag was already selected, upon deselection it will still have an 'org-todo face. --- lisp/org.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 18cb53af6..e6a0350c1 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table &optional todo-table) (cond ((member tag current) c-face) ((member tag inherited) i-face) - (t (get-text-property (match-beginning 1) ' - face)))))))) + (t 'org-default))))))) (goto-char (point-min))))) (delete-overlay org-tags-overlay) (if rtn -- 2.33.0 --=-=-= Content-Type: text/plain -- Daniel Fleischer --=-=-=--