[PATCH] Fix some #+ blocks fontification when there is no lang attribute

[PATCH] Fix some #+ blocks fontification when there is no lang attribute

[julien Barnier]

* lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
lang attribute

When there is no lang attribute to a block (for quote, verse or others), the
lang variable is not nil, but an empty string.
---
 lisp/org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 9fddf3f..fb1041d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5207,7 +5207,7 @@ will be prompted for."
              (add-text-properties end1 (+ end 1) '(face org-meta-line))
                                        ; for end_src
              (cond
-              ((and lang org-src-fontify-natively)
+              ((and lang (not (string= lang "")) org-src-fontify-natively)
                (org-src-font-lock-fontify-block lang block-start block-end)
                ;; remove old background overlays
                (mapc (lambda (ov)
-- 
1.7.5.4

Re: [PATCH] Fix some #+ blocks fontification when there is no lang attribute

[Bastien]

Hi Julien,

julien Barnier <julien@nozav.org> writes:

> * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
> lang attribute
>
> When there is no lang attribute to a block (for quote, verse or others), the
> lang variable is not nil, but an empty string.

Applied, thanks!

-- 
 Bastien

Re: [PATCH] Fix some #+ blocks fontification when there is no lang attribute

[Julien Barnier]

Hi Bastien,

Bastien <bzg <at> altern.org> writes:

> > * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
> > lang attribute
> >
> > When there is no lang attribute to a block (for quote, verse or others), the
> > lang variable is not nil, but an empty string.
> 
> Applied, thanks!

Maybe I'm mistaken, but I think there is a problem with the patch : in the patch
file I sent the new line was the following :

((and lang (not (string= lang "")) org-src-fontify-natively)

But it seems that the applied patch in the git repository is the following :

((and lang (not (string= lang "") org-src-fontify-natively))

http://repo.or.cz/w/org-mode.git/commitdiff/549a5212566e300023e038ec945cb9e8efe37e19

As you can see, the parenthesis is not at the right place, and this seems to
break completely src code blocks fontification...

Thanks in advance,

Julien

Re: [PATCH] Fix some #+ blocks fontification when there is no lang attribute

[Eric Schulte]

Julien Barnier <julien@nozav.org> writes:

> Hi Bastien,
>
> Bastien <bzg <at> altern.org> writes:
>
>> > * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
>> > lang attribute
>> >
>> > When there is no lang attribute to a block (for quote, verse or others), the
>> > lang variable is not nil, but an empty string.
>> 
>> Applied, thanks!
>
> Maybe I'm mistaken, but I think there is a problem with the patch : in the patch
> file I sent the new line was the following :
>
> ((and lang (not (string= lang "")) org-src-fontify-natively)
>
> But it seems that the applied patch in the git repository is the following :
>
> ((and lang (not (string= lang "") org-src-fontify-natively))
>
> http://repo.or.cz/w/org-mode.git/commitdiff/549a5212566e300023e038ec945cb9e8efe37e19
>
> As you can see, the parenthesis is not at the right place, and this seems to
> break completely src code blocks fontification...
>
> Thanks in advance,
>

Fixed.  Thanks for reporting -- Eric

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

Re: [PATCH] Fix some #+ blocks fontification when there is no lang attribute

[Bastien]

Eric Schulte <schulte.eric@gmail.com> writes:

> Fixed.  Thanks for reporting -- Eric

Er, thanks for fixing this typo Eric.

-- 
 Bastien