From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Barnier <julien@nozav.org>
Subject: Re: [PATCH] Fix some #+ blocks fontification when there is no	lang
 attribute
Date: Sat, 2 Jul 2011 00:03:22 +0000 (UTC)
Message-ID: <loom.20110702T020009-500@post.gmane.org>
References: <loom.20110701T164603-332@post.gmane.org> <87oc1e58ak.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:38048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1QcngT-0000tw-FX
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 20:03:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1QcngP-0001FF-AY
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 20:03:41 -0400
Received: from lo.gmane.org ([80.91.229.12]:37502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1QcngO-0001F9-Vf
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 20:03:37 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1QcngN-0004B4-DL
	for emacs-orgmode@gnu.org; Sat, 02 Jul 2011 02:03:35 +0200
Received: from sal69-4-78-192-173-44.fbxo.proxad.net ([78.192.173.44])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sat, 02 Jul 2011 02:03:35 +0200
Received: from julien by sal69-4-78-192-173-44.fbxo.proxad.net with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sat, 02 Jul 2011 02:03:35 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Hi Bastien,

Bastien <bzg <at> altern.org> writes:

> > * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
> > lang attribute
> >
> > When there is no lang attribute to a block (for quote, verse or others), the
> > lang variable is not nil, but an empty string.
> 
> Applied, thanks!

Maybe I'm mistaken, but I think there is a problem with the patch : in the patch
file I sent the new line was the following :

((and lang (not (string= lang "")) org-src-fontify-natively)

But it seems that the applied patch in the git repository is the following :

((and lang (not (string= lang "") org-src-fontify-natively))

http://repo.or.cz/w/org-mode.git/commitdiff/549a5212566e300023e038ec945cb9e8efe37e19

As you can see, the parenthesis is not at the right place, and this seems to
break completely src code blocks fontification...

Thanks in advance,

Julien