From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yKwxLNX3NWPP4QAAbAwnHQ (envelope-from ) for ; Thu, 29 Sep 2022 21:53:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kPVXLNX3NWMEcAEA9RJhRA (envelope-from ) for ; Thu, 29 Sep 2022 21:53:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 374703AFC7 for ; Thu, 29 Sep 2022 21:53:57 +0200 (CEST) Received: from localhost ([::1]:48718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odzbY-0004Qu-Dj for larch@yhetil.org; Thu, 29 Sep 2022 15:53:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odzas-0004ND-Pd for emacs-orgmode@gnu.org; Thu, 29 Sep 2022 15:53:14 -0400 Received: from smtp1-g21.free.fr ([2a01:e0c:1:1599::10]:23148) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odzao-0003NT-0c for emacs-orgmode@gnu.org; Thu, 29 Sep 2022 15:53:14 -0400 Received: from [IPv6:2a01:e35:39f3:4610:257c:2b50:412c:9f8d] (unknown [IPv6:2a01:e35:39f3:4610:257c:2b50:412c:9f8d]) (Authenticated sender: tbanelwebmin@free.fr) by smtp1-g21.free.fr (Postfix) with ESMTPSA id 07CFDB0051B for ; Thu, 29 Sep 2022 21:53:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1664481184; bh=KvDW4yXznCpHstbtLpZzy/c+pcr3bBH0SUTmjMxy4dc=; h=Subject:References:To:From:Date:In-Reply-To:From; b=IeCow6isdLmLYqoQW95SZ010IpvaH7P6la4OgdZbkBKnBEg8FvwHhlrDMSACFvHYU PiaZeWEhXZYZ6DB0QQCtqZpRohg0COUBNdsJHFCaZ1z7yzYro4WYOX3jPPvY2bn4Ne 4t6c7NNydFi5H5Zg76T34CrPm3olYRaU75jLuljGJ72KBxQHQBFrBie0nz8KXtH4rN eJVt1vjf8uSc4qjXQhXHXl3tKfE6nkAG++R3RxzXjM7UL8hrymuEmHoVagEk//y6dw LdWM3S1EK7djxXZ6QfKVZDjsznp7ANbh3EzQ9kJxg275Bsrm4CWYJeBkizbLhiYqmr 9AspjtipyKe1g== Subject: Re: Please add support for dlangs packagemanager to ob-C.el References: <87ill8sg77.fsf@gnu.org> To: Org Mode From: tbanelwebmin Message-ID: Date: Thu, 29 Sep 2022 21:53:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87ill8sg77.fsf@gnu.org> Content-Type: text/html; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:e0c:1:1599::10; envelope-from=tbanelwebmin@free.fr; helo=smtp1-g21.free.fr X-Spam_score_int: -60 X-Spam_score: -6.1 X-Spam_bar: ------ X-Spam_report: (-6.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.1, NICE_REPLY_A=-4.099, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664481237; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=W6AZKrUMi8kKZsJxn3FkMICfBCBJ3F/0SDKF7TBG0Ts=; b=B69tLUsxL7h+FqJoQQwFH13cf+wJIzuF8OGXLZwnWNOE465xIo0aY+4LcVHtZQeKtkZCzK xRyyPMvBv+Hbxkwy8rdABaSLLOeivqVRLYgB8vO/kws5rnmEwRD58cuDOjBg/X6kv/+8aN UFkYUppr9x/7ObKTBbG/2JgXBq0Ii7w3oGk3IAlBeiNUciAwOvsHLXzjH+HIiYsopyuAxR tEmo+QgxhC9yv0ILHLmWnlefphZhlddDjYZFwSp81FdEl8HfZjYrN20xf/xX4YT1eavUdT P39luCWCww0VyOHk4YZ3nFgpkAitVQ6Zpk/zI42U4/2Rf8gdB5GZWgybbbD8cw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664481237; a=rsa-sha256; cv=none; b=UMbWcB9Wba/gOef/SR5kuBGRAeMpS/18vLESYttVxkv6THdW/WAgWsABE6uEWKzRHlPlSZ 5RUrT+ocWKWXR3a5Q0WLL5KrzDsI7oSfFgpDjzN1G0X/3M56RV3avBf5AxP1M8i9haERJb /4sDBnltSV180ezblt/vCBcNHCXwVUR4gsTfKyt6kr6i44LGk3tgqLZvImtwmJmNCccKUl SN4oRQj+zqwz3dUjpakJzmqaCRB5lbA08eY2heRqc2ccS7WX30T1Kz2WKVt2s3Zxyjl083 cAgvCnSokUvoIgvoxAbeYxQ6sFoUWoCrp5/2C7D1PaDBq2KnsSCO/XBQ07hvnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=free.fr header.s=smtp-20201208 header.b=IeCow6is; dmarc=pass (policy=none) header.from=free.fr; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=free.fr header.s=smtp-20201208 header.b=IeCow6is; dmarc=pass (policy=none) header.from=free.fr; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 374703AFC7 X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: NVByj992rMP0 Thanks Christian.

Your TINYCHANGE fits into the 15 lines limit. I will review it.

As Bastien said, we follow as much as we can a predefined format for commit messages:
https://orgmode.org/worg/org-contribute.html#commit-messages

You may also look at past commit messages, for instance this one:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0a6a56c804099e358ca558119b7aede0b2b9b90f
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/

If you want to further contribute, maybe in another TINYCHANGE, automatic unit tests are very valuable. There are already examples of Dlang tests in:
testing/examples/ob-C-test.org
testing/lisp/test-ob-C.el

The best


Le 27/09/2022 à 22:41, Bastien a écrit :
Hi Christian,

thanks for the patch (you forgot to advertize it by adding [PATCH] in
the subject.)

Christian Köstlin <christian.koestlin@gmail.com> writes:


Please see the patch comment. I reworked my original patch to fit
into the TINYPATCH category.

I'm CC'ing Thierry as the maintainer of ob-C.el.

The commit message should be reworked - see
https://orgmode.org/worg/org-contribute.html#commit-messages

I would recommend not using source blocks in the message.

I hope Thierry will have time to review it.

Thanks!