From: Max Nikulin <manikulin@gmail.com>
To: Leo Butler <Leo.Butler@umanitoba.ca>,
Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] remove unused code in ob-octave.el
Date: Fri, 10 Feb 2023 09:32:05 +0700 [thread overview]
Message-ID: <c4139839-eee2-86e4-fd54-54543805e46a@gmail.com> (raw)
In-Reply-To: <87sffetu09.fsf@t14.reltub.ca>
On 10/02/2023 04:21, Leo Butler wrote:
> In lisp/ob-octave.el:
>
> What is the point of ob-octave-prep-session:octave or its brother,
> ob-octave-prep-session:matlab?
>
> These two functions are unused in the existing code.
Have you checked the following? I am not familiar with org-babel code.
grep -nH org-babel-prep-session lisp/ob-core.el
lisp/ob-core.el:1041: (prep-cmd (intern (concat
"org-babel-prep-session:" lang))))
lisp/ob-core.el:1050: (error "No org-babel-prep-session function for
%s!" lang))
Do test passes when you patch is applied? It might mean that test
coverage is not perfect.
next prev parent reply other threads:[~2023-02-10 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 21:21 [PATCH] remove unused code in ob-octave.el Leo Butler
2023-02-10 2:32 ` Max Nikulin [this message]
2023-02-14 17:50 ` Leo Butler
2023-02-10 12:02 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4139839-eee2-86e4-fd54-54543805e46a@gmail.com \
--to=manikulin@gmail.com \
--cc=Leo.Butler@umanitoba.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).