From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id SLUkBs7hJ2ZTSgAAe85BDQ:P1 (envelope-from ) for ; Tue, 23 Apr 2024 18:29:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id SLUkBs7hJ2ZTSgAAe85BDQ (envelope-from ) for ; Tue, 23 Apr 2024 18:29:02 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713889741; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=WJsPNDW+vW47n4bcUezwe1BjsVcTeqdewRAE4vKfNlc=; b=hgX+954fm0XMQIK75PFvxcqohNXhqJluo8EXUbJUtaqvUbKM4Dmjps18E9FRFz6KaPbGGf n3TC2vyEfusZ928o7tb1BmCRcy5g9IMiMLh0y2hc9GdrciLDZMmMuw5p6ywxB2WshSBhTL /djzLv8QWcaDvndDtECmCXasBYQu8PS9SbgL4Muc4mAGRD5+s6H2gx5GTTuEOQcS6AVUpr 7Wh3jv3d3sUpGOcj1sCWYgSWSnko+NKKGu0UCNO3vPFU1/bRxU+F3rFFMyfxoK0uJXsvbL +Yq4jPKGRsjBLqLYJUHpFPeN9mZsEHvNI+tldMQCP8mc4UvKW0iY9u9vrDw2pQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713889741; a=rsa-sha256; cv=none; b=NvH7rh7mUYqb9ohpXCdhxM+F3qFOY4AFH1H7VgnF7GYduXUgp+fV7d01krZTJFjLSw8at7 Mi7YpYZ+fpZHoFDRBfhUpkoIyKMKqZDiFhurObE5373YTdkkYflxTQrbkCwXuDaYnm6RAg gLoSEqxSRtG8O91VrM4kDvxSUfa7OJPIqqCo/nh9aVBQfTYhwjixWIyEeN1jwXe5ICTgfm f+9wZNlWQ1Pys43PG6cix4CvBCGLHape2IMn0Sn9tiQVQHaKQBbO2VD/F5gReYV90w7BMu WpELdcgujjyUtSWLu6vAPNqEJaTZeBjZWv3FhQNWof7jgVI5AQXDR1r8GfFe+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC2D5181C3 for ; Tue, 23 Apr 2024 18:29:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzIzz-00014h-CA; Tue, 23 Apr 2024 12:28:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzIzw-00013h-1M for emacs-orgmode@gnu.org; Tue, 23 Apr 2024 12:28:00 -0400 Received: from smtprelay02.ispgateway.de ([80.67.29.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzIzu-0000Eg-3C for emacs-orgmode@gnu.org; Tue, 23 Apr 2024 12:27:59 -0400 Received: from [185.17.206.77] (helo=condition-alpha.com) by smtprelay02.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1rzIzp-000000006lm-2Yfm; Tue, 23 Apr 2024 18:27:53 +0200 Message-Id: From: Alexander Adolf To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM In-Reply-To: <87zftkpbbf.fsf@localhost> References: <486d2b818b62c71b3f307305c06c4318@condition-alpha.com> <871q7cypxl.fsf@localhost> <00aa9bf72dc93f6554bdd236fdfba192@condition-alpha.com> <87y19hbb05.fsf@localhost> <8b72386d118136210f27b553f0a13066@condition-alpha.com> <87cyqtyzgt.fsf@localhost> <91dfeb0fed1a1fe0564e5eb9b95a409d@condition-alpha.com> <87a5lpeiey.fsf@localhost> <87zftp6zz3.fsf@localhost> <98f04a910f31ff9ab38e2ddf9e7f2f5c@condition-alpha.com> <87mspmq1ce.fsf@localhost> <117e93f189241f4800af207ce30aa606@condition-alpha.com> <87zftkpbbf.fsf@localhost> Date: Tue, 23 Apr 2024 18:27:53 +0200 MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: YWxleGFuZGVyLmFkb2xmQGNvbmRpdGlvbi1hbHBoYS5jb20= Received-SPF: pass client-ip=80.67.29.24; envelope-from=alexander.adolf@condition-alpha.com; helo=smtprelay02.ispgateway.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.38 X-Spam-Score: -6.38 X-Migadu-Queue-Id: CC2D5181C3 X-Migadu-Scanner: mx12.migadu.com X-TUID: EdXsK9ngxMsj Ihor Radchenko writes: > [...] > It would make sense then to include `org-quote-vert' call into > `org-columns--clean-item' then. Good point. I'll move the call to `org-quote-vert' there. > [...] >> (defun org-columns--capture-view (maxlevel match skip-empty exclude-tags format local) >> "Get the column view of the current buffer. >>... >> +When LOCAL is non-nil, only capture headings in current subtree. When >> +LINK is non-nil, item headlines will be linked to their origins. > > Looks like you removed the LINK parameter, but forgot to remove its > description from the docstring. Ah, ashes to my head for overlooking this. Well spotted! >> + (let ((search (org-link-heading-search-string raw))) >> + (org-link-make-string >> + (if (not (buffer-file-name)) search >> + (format "file:%s::%s" (buffer-file-name) search)) >> + cleaned)) > > This will unconditionally generate file: links, even when the dynamic > block only refers to headings in the same buffer. The clock tables do > use internal links when appropriate (see `org-clock-get-table-data'). Um, actually it does exactly the same as `org-clock-get-table-data' (from where I borrowed the code snippet): it generates file: links in buffers visiting files, and local links in buffers not visiting any file. Perhaps you were looking at a test case in which `org-clock-get-table-data' gets called in an Org buffer that is not visiting any file? > [...] > I am attaching a patch containing test case making sure that internal > links are generated when appropriate. The test case is failing with > the latest version of your patch. > > If you can, please add some more tests like mine checking > `org-columns--clean-item'. > [...] Thanks for the springboard hint to get started with adding tests, which I'm happy to do, of course. Is there any way for me to run a specific subset of the tests only, for instance "make test colview", or similar? Many thanks and cheers, --alexander