emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Charles C. Berry" <ccberry@ucsd.edu>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: David Talmage <david.talmage@shoutpoint.com>, emacs-orgmode@gnu.org
Subject: Re: Release 9.0 test failed: test-ob/indented-cached-org-bracket-link
Date: Sat, 19 Nov 2016 09:40:01 -0800	[thread overview]
Message-ID: <alpine.OSX.2.20.1611190927540.1611@charles-berrys-macbook.local> (raw)
In-Reply-To: <874m34m0ab.fsf@nicolasgoaziou.fr>

On Fri, 18 Nov 2016, Nicolas Goaziou wrote:

> Hello,
>
> "Charles C. Berry" <ccberry@ucsd.edu> writes:
>
>> On Fri, 18 Nov 2016, Nicolas Goaziou wrote:
>>
>>> Hello,
>>>
>>> David Talmage <david.talmage@shoutpoint.com> writes:
>>>
>>>> I built org 9.0 on my Mac today.  'make test' reported one failed test.  I
>>>> don't know if it is important or not.  Please advise me.
>>>>
>>>> 'make test' said:
>>>>
>>>> 1 unexpected results:
>>>>    FAILED  test-ob/indented-cached-org-bracket-link
>>>

[snip]

>
>
> Another option is to modify the test so it prints some useful debugging
> information before failing (e.g., contents of default-directory and
> return value of (org-babel-execute-src-block)).
>

Doing this with `make test', I see that default-directory is let bound to

"/var/folders/kb/2hchpbyj7lb6z76l0q73w_fh0000gn/T//tmp-orgtest/"

and (concat default-directory "test.txt") will retain the double slash.

The return value from the second (org-babel-execute-src-block) has only a 
single slash between 'T' and 'tmp'. Hence the failure.

When run interactively, there is no double slash and the test succeeds.

Using

: (expand-file-name "test.txt")

in place of

: (concat default-directory "test.txt)

cleans out the double slash and succeeds either with `make test' or 
interactively.

So, maybe make that change?

Chuck

  reply	other threads:[~2016-11-19 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 16:37 Release 9.0 test failed: test-ob/indented-cached-org-bracket-link David Talmage
2016-11-18  8:44 ` Nicolas Goaziou
2016-11-18 18:50   ` Charles C. Berry
2016-11-19  6:49     ` Nicolas Goaziou
2016-11-19 17:40       ` Charles C. Berry [this message]
2016-11-19 17:55         ` Achim Gratz
2016-11-19 19:15           ` John Kitchin
2016-11-20  4:03             ` Charles C. Berry
2016-11-20  8:38               ` Nicolas Goaziou
2016-11-22 14:18                 ` David Talmage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.OSX.2.20.1611190927540.1611@charles-berrys-macbook.local \
    --to=ccberry@ucsd.edu \
    --cc=david.talmage@shoutpoint.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).