Args out of range, XEmacs 21.4.21

Args out of range, XEmacs 21.4.21

[Hugh Daschbach]

I'm a late comer.  Just found Carston's presentation at Google.  Nice
piece of work.  Many thanks.

Unfortunately, the first thing I did failed with an "Args out of range
error".  I've worked through that (described below).  And have just
finished converting all my sticky notes to org-mode.  Label me a
convert.

The "Args out of range" error is specific to XEmacs [running 21.4
(patch 21)].  I'm running org-mode from the git repository:

$ git-describe
release_6.13a-23-g269c5a8

My first experiment consisted of:

* 1234
* 4567 Meta-Up

That deleted the second line of text and threw the args range exception
   #<buffer "xxx.org">, 0, 1

Here's the traceback:

Debugger entered--Lisp error: (args-out-of-range #<buffer "xxx.org"> 0 1)
  map-extents((lambda (ex ignored) (if (< ... beg) (if ... ... ...)
(if ... ... ...))) #<buffer "xxx.org"> 0 1 nil end-closed outline)
  (save-excursion (map-extents (function ...) (current-buffer) beg end
nil (quote end-closed) (quote outline)))
  outline-discard-extents(0 1)
  outline-flag-region(0 1 nil)
  org-move-subtree-down(-1)
  org-move-subtree-up(1)
  call-interactively(org-move-subtree-up)
  org-metaup(nil)
  call-interactively(org-metaup)

Here's what I did to noutline.el to mask the issue:

diff --git a/xemacs/noutline.el b/xemacs/noutline.el
index f9ea1da..2463011 100644
--- a/xemacs/noutline.el
+++ b/xemacs/noutline.el
@@ -735,6 +735,8 @@ BEG and END default respectively to the beginning
and end of buffer."
 If FLAG is nil then text is shown, while if FLAG is t the text is hidden."
   (when (< to from)
     (setq from (prog1 to (setq to from))))
+  (when (< from (point-min))
+    (setq from (point-min)))
   ;; first clear it all out
   (outline-discard-extents from to)
   (when flag

I doubt this is a proper fix.  It likely just masks the real issue.
The line in org-move-subtree-down that called outline-flag-region with
FROM set to zero is:

    (outline-flag-region (1- (point)) (point) nil)

I haven't dug into why this isn't already reported or why it doesn't
occur with FSF Emacs.

But many thank for an excellent tool.

Re: Args out of range, XEmacs 21.4.21

[Carsten Dominik]

Fixed, thanks, in particular for the partial analysis
which helped to quickly find the problem.

- Carsten

On Dec 5, 2008, at 8:56 AM, Hugh Daschbach wrote:

> I'm a late comer.  Just found Carston's presentation at Google.  Nice
> piece of work.  Many thanks.
>
> Unfortunately, the first thing I did failed with an "Args out of range
> error".  I've worked through that (described below).  And have just
> finished converting all my sticky notes to org-mode.  Label me a
> convert.
>
> The "Args out of range" error is specific to XEmacs [running 21.4
> (patch 21)].  I'm running org-mode from the git repository:
>
> $ git-describe
> release_6.13a-23-g269c5a8
>
> My first experiment consisted of:
>
> * 1234
> * 4567 Meta-Up
>
> That deleted the second line of text and threw the args range  
> exception
>   #<buffer "xxx.org">, 0, 1
>
> Here's the traceback:
>
> Debugger entered--Lisp error: (args-out-of-range #<buffer "xxx.org">  
> 0 1)
>  map-extents((lambda (ex ignored) (if (< ... beg) (if ... ... ...)
> (if ... ... ...))) #<buffer "xxx.org"> 0 1 nil end-closed outline)
>  (save-excursion (map-extents (function ...) (current-buffer) beg end
> nil (quote end-closed) (quote outline)))
>  outline-discard-extents(0 1)
>  outline-flag-region(0 1 nil)
>  org-move-subtree-down(-1)
>  org-move-subtree-up(1)
>  call-interactively(org-move-subtree-up)
>  org-metaup(nil)
>  call-interactively(org-metaup)
>
> Here's what I did to noutline.el to mask the issue:
>
> diff --git a/xemacs/noutline.el b/xemacs/noutline.el
> index f9ea1da..2463011 100644
> --- a/xemacs/noutline.el
> +++ b/xemacs/noutline.el
> @@ -735,6 +735,8 @@ BEG and END default respectively to the beginning
> and end of buffer."
> If FLAG is nil then text is shown, while if FLAG is t the text is  
> hidden."
>   (when (< to from)
>     (setq from (prog1 to (setq to from))))
> +  (when (< from (point-min))
> +    (setq from (point-min)))
>   ;; first clear it all out
>   (outline-discard-extents from to)
>   (when flag
>
> I doubt this is a proper fix.  It likely just masks the real issue.
> The line in org-move-subtree-down that called outline-flag-region with
> FROM set to zero is:
>
>    (outline-flag-region (1- (point)) (point) nil)
>
> I haven't dug into why this isn't already reported or why it doesn't
> occur with FSF Emacs.
>
> But many thank for an excellent tool.
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode