unofficial mirror of emacs-orgmode@gnu.org
 help / color / Atom feed
* Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)]
@ 2020-06-11 20:27 John Ciolfi
  2020-06-12  3:49 ` stardiviner
  2020-06-13  6:42 ` Kyle Meyer
  0 siblings, 2 replies; 5+ messages in thread
From: John Ciolfi @ 2020-06-11 20:27 UTC (permalink / raw)
  To: emacs-orgmode


Given the following org file, on the #+end_src line, I get "Org mode fontification error in #<buffer foo.org> at 9". If I place a newline before the #+end_src line, the error goes away. This is a recent regression. This worked fine in 9.2.6 and prior.

  #+begin_src C++
    #include <iostream>
    int main() {
        std::cout << "hello";
        return 0;
    }

    // The results:
  #+end_src

  #+RESULTS:



Emacs  : GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2019-09-22, modified by Debian
Package: Org mode version 9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-latex-default-packages-alist '(("colorlinks=true,linkcolor={red!50!black},citecolor={blue!50!black},urlcolor={blue!80!black}" "hyperref" nil)
                                    ("AUTO" "inputenc" t ("pdflatex"))
                                    ("T1" "fontenc" t ("pdflatex")) ("" "graphicx" t)
                                    ("" "grffile" t) ("" "longtable" nil) ("" "wrapfig" nil)
                                    ("" "rotating" nil) ("normalem" "ulem" t) ("" "amsmath" t)
                                    ("" "textcomp" t) ("" "amssymb" t) ("" "capt-of" nil)
                                    ("" "hyperref" nil))
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-show-all append local] 5]
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-link-file-path-type 'relative
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-babel-tangle-lang-exts '(("perl" . "pl") ("D" . "d") ("C++" . "cpp") ("emacs-lisp" . "el")
                              ("elisp" . "el"))
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-open-link :export org-attach-export-link
                        :complete org-attach-complete-link)
                       ("id" :follow org-id-open) ("eww" :follow eww :store org-eww-store-link)
                       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link :export
                        org-irc-export)
                       ("info" :follow org-info-open :export org-info-export :store
                        org-info-store-link)
                       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                       ("docview" :follow org-docview-open :export org-docview-export :store
                        org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
                        org-bbdb-complete-link :store org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
                       ("shell" :follow org-link--open-shell)
                       ("news" :follow
                        #[257 "\301\300\302Q!\207" ["news" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("mailto" :follow
                        #[257 "\301\300\302Q!\207" ["mailto" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("https" :follow
                        #[257 "\301\300\302Q!\207" ["https" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("http" :follow
                        #[257 "\301\300\302Q!\207" ["http" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("ftp" :follow
                        #[257 "\301\300\302Q!\207" ["ftp" browse-url ":"] 5 "\n\n(fn URL)"])
                       ("help" :follow org-link--open-help)
                       ("file" :complete org-link-complete-file)
                       ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi))
 org-link-elisp-confirm-function 'yes-or-no-p
 org-list-indent-offset 2
 )



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)]
  2020-06-11 20:27 Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)] John Ciolfi
@ 2020-06-12  3:49 ` stardiviner
  2020-06-13  6:42 ` Kyle Meyer
  1 sibling, 0 replies; 5+ messages in thread
From: stardiviner @ 2020-06-12  3:49 UTC (permalink / raw)
  To: ciolfi; +Cc: emacs-orgmode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


I got same problem, fontification on the ~#+end_src~ seems failed.

John Ciolfi <ciolfi@mathworks.com> writes:

> Given the following org file, on the #+end_src line, I get "Org mode fontification error in #<buffer foo.org> at 9". If I place a newline before the #+end_src line, the error goes away. This is a recent regression. This worked fine in 9.2.6 and prior.
>
>   #+begin_src C++
>     #include <iostream>
>     int main() {
>         std::cout << "hello";
>         return 0;
>     }
>
>     // The results:
>   #+end_src
>
>   #+RESULTS:
>
>
>
> Emacs  : GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
>  of 2019-09-22, modified by Debian
> Package: Org mode version 9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)
>
> current state:
> ==============
> (setq
>  org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
>  org-link-shell-confirm-function 'yes-or-no-p
>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
>  org-latex-default-packages-alist '(("colorlinks=true,linkcolor={red!50!black},citecolor={blue!50!black},urlcolor={blue!80!black}" "hyperref" nil)
>                                     ("AUTO" "inputenc" t ("pdflatex"))
>                                     ("T1" "fontenc" t ("pdflatex")) ("" "graphicx" t)
>                                     ("" "grffile" t) ("" "longtable" nil) ("" "wrapfig" nil)
>                                     ("" "rotating" nil) ("normalem" "ulem" t) ("" "amsmath" t)
>                                     ("" "textcomp" t) ("" "amssymb" t) ("" "capt-of" nil)
>                                     ("" "hyperref" nil))
>  org-mode-hook '(#[0 "\300\301\302\303\304$\207"
>                    [add-hook change-major-mode-hook org-show-all append local] 5]
>                  #[0 "\300\301\302\303\304$\207"
>                    [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
>                  org-babel-result-hide-spec org-babel-hide-all-hashes)
>  org-archive-hook '(org-attach-archive-delete-maybe)
>  org-confirm-elisp-link-function 'yes-or-no-p
>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>  org-metaup-hook '(org-babel-load-in-session-maybe)
>  org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
>  org-babel-pre-tangle-hook '(save-buffer)
>  org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
>  org-link-file-path-type 'relative
>  org-occur-hook '(org-first-headline-recenter)
>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines
>                   org-optimize-window-after-visibility-change)
>  org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
>  org-babel-tangle-lang-exts '(("perl" . "pl") ("D" . "d") ("C++" . "cpp") ("emacs-lisp" . "el")
>                               ("elisp" . "el"))
>  org-confirm-shell-link-function 'yes-or-no-p
>  org-link-parameters '(("attachment" :follow org-attach-open-link :export org-attach-export-link
>                         :complete org-attach-complete-link)
>                        ("id" :follow org-id-open) ("eww" :follow eww :store org-eww-store-link)
>                        ("rmail" :follow org-rmail-open :store org-rmail-store-link)
>                        ("mhe" :follow org-mhe-open :store org-mhe-store-link)
>                        ("irc" :follow org-irc-visit :store org-irc-store-link :export
>                         org-irc-export)
>                        ("info" :follow org-info-open :export org-info-export :store
>                         org-info-store-link)
>                        ("gnus" :follow org-gnus-open :store org-gnus-store-link)
>                        ("docview" :follow org-docview-open :export org-docview-export :store
>                         org-docview-store-link)
>                        ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
>                        ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
>                         org-bbdb-complete-link :store org-bbdb-store-link)
>                        ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
>                        ("shell" :follow org-link--open-shell)
>                        ("news" :follow
>                         #[257 "\301\300\302Q!\207" ["news" browse-url ":"] 5 "\n\n(fn URL)"])
>                        ("mailto" :follow
>                         #[257 "\301\300\302Q!\207" ["mailto" browse-url ":"] 5 "\n\n(fn URL)"])
>                        ("https" :follow
>                         #[257 "\301\300\302Q!\207" ["https" browse-url ":"] 5 "\n\n(fn URL)"])
>                        ("http" :follow
>                         #[257 "\301\300\302Q!\207" ["http" browse-url ":"] 5 "\n\n(fn URL)"])
>                        ("ftp" :follow
>                         #[257 "\301\300\302Q!\207" ["ftp" browse-url ":"] 5 "\n\n(fn URL)"])
>                        ("help" :follow org-link--open-help)
>                        ("file" :complete org-link-complete-file)
>                        ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi))
>  org-link-elisp-confirm-function 'yes-or-no-p
>  org-list-indent-offset 2
>  )


- -- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7i+zgUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsODLwgAoO1OD+5Rsvzr4HYWynlVYFmu2LIw
atICi53TXYdZF7FIQfbtKwKIMn8ltqwu2ByMhrXm67ArcRFYO5A4u6BXinYj1G/w
Al+KZ8zoNUnq/8oUdGQpFcj/leOzS1ZTpCzHpj9hKq6Urw20egqS8p7MFcG62mJ0
TmSmsoj//f6F65TxrX+bdtWI1UkfJOvXQRr5QzXGj3jHprZfVRKbXdVSmC3Jho+w
S7DqCOn0oTRgiNZiQRDm0xIATFrgCsPqLkRUejblV4YK01smhxUCGEtGTUcOhi50
v0NQYT6wyiGmvZWu5cJQfI3thxId+fy2CY/Qo68jynQsXAyFDHe7vqpNbw==
=PzO7
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)]
  2020-06-11 20:27 Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)] John Ciolfi
  2020-06-12  3:49 ` stardiviner
@ 2020-06-13  6:42 ` Kyle Meyer
  2020-06-13 19:21   ` Kyle Meyer
  1 sibling, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2020-06-13  6:42 UTC (permalink / raw)
  To: ciolfi; +Cc: emacs-orgmode

John Ciolfi writes:

> Given the following org file, on the #+end_src line, I get "Org mode
> fontification error in #<buffer foo.org> at 9". If I place a newline
> before the #+end_src line, the error goes away. This is a recent
> regression. This worked fine in 9.2.6 and prior.
>
>   #+begin_src C++
>     #include <iostream>
>     int main() {
>         std::cout << "hello";
>         return 0;
>     }
>
>     // The results:
>   #+end_src
>
>   #+RESULTS:

Thanks for the report.

This bisects to 04d2828ad (org: Fix verbatim block fontification to end
blocks on headlines, 2019-12-11).  Reverting different parts of that
patch, it seems this is the problematic hunk:

diff --git a/lisp/org.el b/lisp/org.el
index 68ca5839a..14840d8ca 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5320,10 +5320,14 @@ (defun org-fontify-meta-lines-and-blocks-1 (limit)
 	    (add-text-properties
 	     beg (if whole-blockline bol-after-beginline end-of-beginline)
 	     '(face org-block-begin-line))
-	    (add-text-properties
-	     beg-of-endline
-	     (min (point-max) (if whole-blockline (min (point-max) (1+ end-of-endline)) end-of-endline))
-	     '(face org-block-end-line))
+	    (unless (string-prefix-p "*" (match-string 1))
+	      (add-text-properties
+	       beg-of-endline
+	       (if whole-blockline
+		   (let ((beg-of-next-line (1+ end-of-endline)))
+		     (min (point-max) beg-of-next-line))
+		 (min (point-max) end-of-endline))
+	       '(face org-block-end-line)))
 	    t))
 	 ((member dc1 '("+title:" "+author:" "+email:" "+date:"))
 	  (org-remove-flyspell-overlays-in

I'll try to take a closer look tomorrow.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)]
  2020-06-13  6:42 ` Kyle Meyer
@ 2020-06-13 19:21   ` Kyle Meyer
  2020-06-15 14:58     ` John Ciolfi
  0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2020-06-13 19:21 UTC (permalink / raw)
  To: ciolfi; +Cc: emacs-orgmode

Kyle Meyer writes:

> I'll try to take a closer look tomorrow.

This should be fixed by ba6ca79af.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)]
  2020-06-13 19:21   ` Kyle Meyer
@ 2020-06-15 14:58     ` John Ciolfi
  0 siblings, 0 replies; 5+ messages in thread
From: John Ciolfi @ 2020-06-15 14:58 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Thanks - I verified the fix.
________________________________
From: Kyle Meyer <kyle@kyleam.com>
Sent: Saturday, June 13, 2020 3:21 PM
To: John Ciolfi <ciolfi@mathworks.com>
Cc: emacs-orgmode@gnu.org <emacs-orgmode@gnu.org>
Subject: Re: Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)]

Kyle Meyer writes:

> I'll try to take a closer look tomorrow.

This should be fixed by ba6ca79af.


[-- Attachment #2: Type: text/html, Size: 1215 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 20:27 Bug: fontification error with #end_src in 9.3.7 [9.3.7 (9.3.7-dist @ /PATH/TO/org/install/emacs/site-lisp/org/)] John Ciolfi
2020-06-12  3:49 ` stardiviner
2020-06-13  6:42 ` Kyle Meyer
2020-06-13 19:21   ` Kyle Meyer
2020-06-15 14:58     ` John Ciolfi

unofficial mirror of emacs-orgmode@gnu.org

Archives are clonable:
	git clone --mirror https://yhetil.org/orgmode/0 orgmode/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 orgmode orgmode/ https://yhetil.org/orgmode \
		emacs-orgmode@gnu.org
	public-inbox-index orgmode

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.orgmode
	nntp://news.gmane.io/gmane.emacs.orgmode


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git