From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Bug Report: org-blocker-hook and org-trigger-hook are named incorrectly Date: Mon, 30 Nov 2009 15:43:45 +0100 Message-ID: References: <4B10365F.4050404@thompsonclan.org> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF7Tm-00056h-FL for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:43:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF7Th-00055l-SV for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:43:54 -0500 Received: from [199.232.76.173] (port=40184 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF7Th-00055e-OK for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:43:49 -0500 Received: from mail-ew0-f224.google.com ([209.85.219.224]:63207) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF7Th-0008Ih-1u for emacs-orgmode@gnu.org; Mon, 30 Nov 2009 09:43:49 -0500 Received: by ewy24 with SMTP id 24so4211476ewy.26 for ; Mon, 30 Nov 2009 06:43:48 -0800 (PST) In-Reply-To: <4B10365F.4050404@thompsonclan.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Ryan C. Thompson" Cc: org-mode Mailinglist Hi Ryan, yes, we have some non-standard names here, but often these standards cam after the names were used for quite some time, so I am not going to change them. - Carsten On Nov 27, 2009, at 9:28 PM, Ryan C. Thompson wrote: > I believe it is the emacs convention to distinguish between hooks > that take no arguments and hooks that do. Since org-blocker-hook and > org-trigger-hook pass an argument to their functions, they should > actually be called org-blocker-functions and org-trigger-functions. > > From the elisp info, 23.1 Hooks: > > If the hook variable's name does not end with `-hook', that > indicates it is probably an "abnormal hook". That means the hook > functions are called with arguments, or their return values are used > in > some way. The hook's documentation says how the functions are called. > You can use `add-hook' to add a function to an abnormal hook, but you > must write the function to follow the hook's calling convention. > By convention, abnormal hook names end in `-functions' or `-hooks'. > If the variable's name ends in `-function', then its value is just a > single function, not a list of functions. > > -Ryan > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten