emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Stephan Schmitt <drmabuse@cs.tu-berlin.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] set variables org-timer-timer[123] correctly
Date: Thu, 5 Nov 2009 16:12:23 +0100	[thread overview]
Message-ID: <EDBFA4E8-F170-427E-8FE2-600F9E4989F6@gmail.com> (raw)
In-Reply-To: <1257415055-8120-2-git-send-email-drmabuse@cs.tu-berlin.de>

Applied, thanks.

- Carsten

On Nov 5, 2009, at 10:57 AM, Stephan Schmitt wrote:

> before these variables were set to nil, and consequently
> org-timer-last-timer as well.
> ---
> lisp/org-timer.el |   12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/org-timer.el b/lisp/org-timer.el
> index 8a59c74..660312a 100644
> --- a/lisp/org-timer.el
> +++ b/lisp/org-timer.el
> @@ -312,12 +312,12 @@ VALUE can be `on', `off', or `pause'."
> 		(t (error "Not in an Org buffer"))))
> 	   timer-set)
>       (mapcar (lambda(timer)
> -		(if (not (or (eval timer) timer-set))
> -		    (setq timer-set t
> -			  timer
> -			  (run-with-timer
> -			   secs nil 'org-notify (format "%s: time out" hl) t)
> -			  org-timer-last-timer timer)))
> +		(when (not (or (eval timer) timer-set))
> +		  (setq timer-set t)
> +		  (setq org-timer-last-timer
> +			(run-with-timer
> +			secs nil 'org-notify (format "%s: time out" hl) t))
> +		  (set timer org-timer-last-timer)))
> 	      '(org-timer-timer1
> 		org-timer-timer2
> 		org-timer-timer3)))))
> -- 
> 1.6.4.4
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

  reply	other threads:[~2009-11-05 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  9:57 [PATCH 1/2] respect startgroup/endgroup delimiters with description in org-tag-alist Stephan Schmitt
2009-11-05  9:57 ` [PATCH 2/2] set variables org-timer-timer[123] correctly Stephan Schmitt
2009-11-05 15:12   ` Carsten Dominik [this message]
2009-11-05 15:12 ` [PATCH 1/2] respect startgroup/endgroup delimiters with description in org-tag-alist Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EDBFA4E8-F170-427E-8FE2-600F9E4989F6@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=drmabuse@cs.tu-berlin.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).