Re: [PATCH] org-protocol: fixes open-source and extends rewriting of URLs

[Mario Martelli <tlmtr@schnuddelhuddel.de>]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

> If all tests in "test-org-protocol.el" pass with your changes, I think
> it is fine to apply them.


	Selector: "test-org-protocol/"
	Passed:  2
	Failed:  0
	Skipped: 0
	Total:   2/2

> Another round of tests for the cases you solve
> would be nice, too.

I added the configuration part. That will be parsed during the tests I suppose.


	Selector: "test-org-protocol/"
	Passed:  3
	Failed:  0
	Skipped: 0
	Total:   3/3


[-- Attachment #2: 0004-config-for-date-style-URL-is-added-to-org-protocol-t.patch --]
[-- Type: application/octet-stream, Size: 1036 bytes --]

From 4408f27e37f6578b3244a1ff7f4d7bd27720e1e6 Mon Sep 17 00:00:00 2001
From: Mario Martelli <cocoa@schnuddelhuddel.de>
Date: Sun, 25 Jun 2017 10:14:40 +0200
Subject: [PATCH 4/4] config for date style URL is added to org-protocol tests

---
 testing/lisp/test-org-protocol.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/testing/lisp/test-org-protocol.el b/testing/lisp/test-org-protocol.el
index 8f946864c..b11c72a68 100644
--- a/testing/lisp/test-org-protocol.el
+++ b/testing/lisp/test-org-protocol.el
@@ -137,6 +137,12 @@
 	     :base-url "http://another.example.com/"
 	     :online-suffix ".js"
 	     :working-directory ,(file-name-directory temp-file-name2))
+	    (test3
+	     :base-url "https://blog-example.com/"
+	     :working-directory ,(file-name-directory temp-file-name2))
+	     :online-suffix ".html"
+	     :working-suffix ".md"
+	     :rewrites (("\\(https://blog-example.com/[0-9]+/[0-9]+/[0-9]+/\\)" . ".md"))
 	    ))
 	 (test-cases
 	  (list
-- 
2.11.0 (Apple Git-81)


[-- Attachment #3: Type: text/plain, Size: 538 bytes --]



Adding full test-coverage of my changes is beyond my abilities at the moment, I must admit.
But I will come back to it soon, I promise ;)
Especially as there are succeeding tests for open-source using old-style URIs. (old-style URIs are not working for me with open-source)
That will be the next task for me after completing the documentation.

Speaking of the documentation: is it right, that there is no more support for “remember”? 
I would then remove that part from the documentation.

Kind regards
Mario
—