From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-clock-select-task bugfix (XEmacs incompatibility) Date: Thu, 3 Dec 2009 14:54:12 +0100 Message-ID: References: <87y6lmwj8o.fsf@gmail.com> <252E914A-E305-4841-B39E-470700D355F6@gmail.com> <87ws15blp6.fsf@gmail.com> <87ljhk8c1b.fsf@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGC8V-0007n8-BG for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 08:54:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGC8Q-0007h3-0Q for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 08:54:22 -0500 Received: from [199.232.76.173] (port=56645 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGC8P-0007gh-H4 for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 08:54:17 -0500 Received: from mail-ew0-f214.google.com ([209.85.219.214]:34555) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGC8P-00084v-2R for emacs-orgmode@gnu.org; Thu, 03 Dec 2009 08:54:17 -0500 Received: by ewy6 with SMTP id 6so1452238ewy.9 for ; Thu, 03 Dec 2009 05:54:16 -0800 (PST) In-Reply-To: <87ljhk8c1b.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Richard KLINDA Cc: emacs-orgmode@gnu.org Ah, of course, sorry about that, thanks. - Carsten On Dec 3, 2009, at 1:41 PM, Richard KLINDA wrote: > Almost good, but the variable "s" contains a list, we need to > int-to-char the "car" of that, see attached trivial patch. It works > with this. Thank you. > > diff --git a/lisp/org-clock.el b/lisp/org-clock.el > index 321dd95..ce309ef 100644 > --- a/lisp/org-clock.el > +++ b/lisp/org-clock.el > @@ -339,7 +339,7 @@ of a different task.") > (if (< i 10) > (+ i ?0) > (+ i (- ?A 10))) m)) > - (if (fboundp 'int-to-char) (setq s (int-to-char s))) > + (if (fboundp 'int-to-char) (setf (car s) (int-to-char > (car s)))) > (push s sel-list))) > org-clock-history) > (org-fit-window-to-buffer) > > >>>>>> Regarding 'Re: [Orgmode] [PATCH] org-clock-select-task bugfix >>>>>> (XEmacs incompatibility)'; Carsten Dominik adds: > >> Hi Richard, I ave fixed this in a different way. Please verify! > >> - Carsten > >> On Dec 2, 2009, at 1:32 PM, Richard KLINDA wrote: > >>> Hello Carsten, this failed for me ever since, but as I haven't >>> needed the functionality I was just lazy to report it. Oh:) I see >>> why my patch must be problematic, sorry about that. > >>> The problem is that, when pressed a number as a reply to the >>> question, this cond command (see below) always goes to the error >>> clause, because rpl gets the value of ?1 for example, but sel-list >>> look like ((49 . ...) (50 . ...)) so the assoc can't find ?1. >>> With my patch, the assoc finds it because rpl is converted to ASCII >>> code, but now ?q and ?x clauses don't work.:) > >>> (cond ((eq rpl ?q) nil) ((eq rpl ?x) nil) ((assoc rpl sel-list) >>> (cdr (assoc rpl sel-list))) (t (error "Invalid task choice %c" >>> rpl))) > >>> I hope you see what the problem is, I think it must be an XEmacs >>> issue. > >>>>>>>> Regarding 'Re: [Orgmode] [PATCH] org-clock-select-task bugfix >>>>>>>> (XEmacs incompatibility)'; Carsten Dominik adds: > >>>> Hi Richard, I don't see why this would be necessary? Under what >>>> circumstances does this fail? > >>>> - Carsten > >>>> On Dec 1, 2009, at 9:07 PM, Richard KLINDA wrote: > >>>>> See attached simple patch. > >>>>> From 795d529d622f509f47c2bf17a0139fbe1659cc5f Mon Sep 17 00:00:00 >>>>> 2001 From: Richard Klinda Date: Tue, 1 Dec >>>>> 2009 21:03:39 +0100 Subject: [PATCH] org-clock: >>>>> org-clock-select-task bugfix (XEmacs) > >>>>> --- lisp/org-clock.el | 4 ++++ 1 files changed, 4 insertions(+), >>>>> 0 >>>>> deletions(-) > >>>>> diff --git a/lisp/org-clock.el b/lisp/org-clock.el index >>>>> 56dbab5..87017fc 100644 >>>>> --- a/lisp/org-clock.el >>>>> +++ b/lisp/org-clock.el >>>>> @@ -344,6 +344,10 @@ of a different task.") >>>>> (org-fit-window-to-buffer) (message (or prompt "Select task for >>>>> clocking:")) (setq rpl (read-char-exclusive)) >>>>> + (when (featurep 'xemacs) >>>>> + ;; in XEmacs read-char-exclusive returns character, instead >>>>> of >>>>> + ;; ascii value >>>>> + (setq rpl (char-octet rpl))) >>>>> (cond ((eq rpl ?q) nil) ((eq rpl ?x) nil) -- 1.6.2.1 > > >>>>> -- Richard _______________________________________________ >>>>> Emacs-orgmode mailing list Please use `Reply All' to send replies >>>>> to the list. Emacs-orgmode@gnu.org >>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode > >>>> - Carsten > >>> -- Richard > >> - Carsten > > -- > Udv, Richard - Carsten