From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Suckling Subject: Re: Patch for growl notifications without uncommenting hacks Date: Tue, 7 Apr 2009 22:50:28 +0100 Message-ID: References: <8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com> <63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com> <03A40B38-6EFF-4C3A-BEEE-879BA1E30F87@gmail.com> <4F5F2D2E-636B-43CC-A957-1B29CC84BD99@boostpro.com> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: multipart/mixed; boundary=Apple-Mail-26-988307284 Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrJBm-0000yy-F6 for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 17:50:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrJBh-0000wY-QY for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 17:50:38 -0400 Received: from [199.232.76.173] (port=50098 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrJBh-0000wS-Kh for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 17:50:33 -0400 Received: from mail-ew0-f160.google.com ([209.85.219.160]:35556) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LrJBg-0003Ys-Se for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 17:50:33 -0400 Received: by ewy4 with SMTP id 4so3091867ewy.42 for ; Tue, 07 Apr 2009 14:50:31 -0700 (PDT) In-Reply-To: <4F5F2D2E-636B-43CC-A957-1B29CC84BD99@boostpro.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Abrahams Cc: emacs-orgmode emacs-orgmode , Christopher Suckling --Apple-Mail-26-988307284 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Hi Carsten, Hopefully this is the last of the org-mac-message.el patches and it supersedes everything from yesterday morning onwards... It adds Growl detection AppleScript, fixes the commentary, tidies the indentation and fixes two bugs (message:// regex and some formatting) Best, Christopher On 7 Apr 2009, at 14:15, David Abrahams wrote: > > On Apr 7, 2009, at 4:12 AM, Christopher Suckling wrote: > >> And done. > > Thanks. > > s/GrowlaHelperApp/GrowlHelperApp/ > > and there are two lines of comment (where the link is) that seem to > be indented slightly differently from the rest. > >> Carsten, ignore yesterday's patch. >> >> BTW, is there a way of automatically doing the AppleScript >> indentation (I lost it all when I ran indent-region on the buffer >> and was too tired last night to put it back in...)? > > That level of emacs-fu is beyond me :-) > I just did it manually. > > -- > David Abrahams > BoostPro Computing > http://boostpro.com > > > > --Apple-Mail-26-988307284 Content-Disposition: attachment; filename=org-mac-message.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="org-mac-message.patch" Content-Transfer-Encoding: 7bit diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el index abb2e4e..c94457f 100644 --- a/lisp/org-mac-message.el +++ b/lisp/org-mac-message.el @@ -43,10 +43,6 @@ ;; message:// links within the first level of the heading are deleted ;; and replaced with links to flagged messages. -;; If you have Growl installed and would like more visual feedback -;; whilst AppleScript searches for messages, please uncomment lines -;; 114 to 119. - ;;; Code: (require 'org) @@ -89,41 +85,65 @@ This will use the command `open' with the message URL." (do-applescript (concat "tell application \"Mail\"\n" - "set theLinkList to {}\n" - "set theSelection to selection\n" - "repeat with theMessage in theSelection\n" - "set theID to message id of theMessage\n" - "set theSubject to subject of theMessage\n" - "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" - "copy theLink to end of theLinkList\n" - "end repeat\n" - "return theLinkList as string\n" + "set theLinkList to {}\n" + "set theSelection to selection\n" + "repeat with theMessage in theSelection\n" + "set theID to message id of theMessage\n" + "set theSubject to subject of theMessage\n" + "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" + "copy theLink to end of theLinkList\n" + "end repeat\n" + "return theLinkList as string\n" "end tell"))) (defun as-get-flagged-mail () "AppleScript to create links to flagged messages in Mail.app" (do-applescript - (concat - "tell application \"Mail\"\n" - "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n" - "set theLinkList to {}\n" - "repeat with aMailbox in theMailboxes\n" - "set theSelection to (every message in aMailbox whose flagged status = true)\n" - "repeat with theMessage in theSelection\n" - "set theID to message id of theMessage\n" - "set theSubject to subject of theMessage\n" - "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" - "copy theLink to end of theLinkList\n" - ;; "tell application \"GrowlHelperApp\"\n" - ;; "set the allNotificationsList to {\"FlaggedMail\"}\n" - ;; "set the enabledNotificationsList to allNotificationsList\n" - ;; "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n" - ;; "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n" - ;; "end tell\n" - "end repeat\n" - "end repeat\n" - "return theLinkList as string\n" - "end tell"))) + (concat + ;; Is Growl installed? + "tell application \"System Events\"\n" + "set growlHelpers to the name of every process whose creator type contains \"GRRR\"\n" + "if (count of growlHelpers) > 0 then\n" + "set growlHelperApp to item 1 of growlHelpers\n" + "else\n" + "set growlHelperApp to \"\"\n" + "end if\n" + "end tell\n" + + ;; Get links + "tell application \"Mail\"\n" + "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n" + "set theLinkList to {}\n" + "repeat with aMailbox in theMailboxes\n" + "set theSelection to (every message in aMailbox whose flagged status = true)\n" + "repeat with theMessage in theSelection\n" + "set theID to message id of theMessage\n" + "set theSubject to subject of theMessage\n" + "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" + "copy theLink to end of theLinkList\n" + + ;; Report progress through Growl + ;; This "double tell" idiom is described in detail at + ;; http://macscripter.net/viewtopic.php?id=24570 The + ;; script compiler needs static knowledge of the + ;; growlHelperApp. Hmm, since we're compiling + ;; on-the-fly here, this is likely to be way less + ;; portable than I'd hoped. It'll work when the name + ;; is still "GrowlHelperApp", though. + "if growlHelperApp is not \"\" then\n" + "tell application \"GrowlHelperApp\"\n" + "tell application growlHelperApp\n" + "set the allNotificationsList to {\"FlaggedMail\"}\n" + "set the enabledNotificationsList to allNotificationsList\n" + "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n" + "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n" + "end tell\n" + "end tell\n" + "end if\n" + "end repeat\n" + "end repeat\n" + "return theLinkList as string\n" + "end tell"))) (defun org-mac-message-get-links (select-or-flag) "Create links to the messages currently selected or flagged in @@ -183,7 +203,7 @@ list of message:// links to flagged mail after heading." (set-buffer org-buffer) (goto-char (point-min)) (let ((isearch-forward t) - (message-re "\\[\\[\\(message:\\)?\\([^]]+\\)\\]\\(\\[\\([^]]+\\)\\]\\)?\\]")) + (message-re "\\[\\[\\(message:\\)\\([^]]+\\)\\]\\(\\[\\([^]]+\\)\\]\\)?\\]")) (if (org-goto-local-search-headings org-heading nil t) (if (not (eobp)) (progn @@ -191,6 +211,7 @@ list of message:// links to flagged mail after heading." (while (re-search-forward message-re (save-excursion (outline-next-heading)) t) (delete-region (match-beginning 0) (match-end 0))) + (insert "\n") (org-mac-message-get-links "f") (yank)) (flush-lines "^$" (point) (outline-next-heading))) --Apple-Mail-26-988307284 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --Apple-Mail-26-988307284--