From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathaniel Flath Subject: Re: [PATCH] org-agenda tag completion works with ido Date: Thu, 13 Jul 2017 10:07:02 -0700 Message-ID: References: <87bmopdkcy.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a11400cae2d5dd9055435f6a8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVhZx-0001W7-PS for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 13:07:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVhZw-0000YQ-Kg for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 13:07:05 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:33165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVhZw-0000YF-Fm for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 13:07:04 -0400 Received: by mail-qk0-x22d.google.com with SMTP id a66so42078528qkb.0 for ; Thu, 13 Jul 2017 10:07:04 -0700 (PDT) In-Reply-To: <87bmopdkcy.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kyle Meyer Cc: org-mode List --001a11400cae2d5dd9055435f6a8 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 12, 2017 at 9:35 PM, Kyle Meyer wrote: > Nathaniel Flath writes: > >> After upgrading to the latest org-mode, tag completion when filtering >> in the agenda was broken - I had to fully enter the tag, despite using >> ido (eg I would have a tag 'home', and 'ho-enter' would not compete). > > [...] > >> * org-agenda.el (org-agenda-filter-by-tag): >> (org-agenda-filter-by-tag): pass t to require-match argument of completing-read. > > ^ repeated function name > Removed that in patch attached. >> This causes ido-mode to complete tags properly when inputting partial matches, rather >> that just sending the typed input. > > Wouldn't this mean that, in general, ido won't complete partial matches > properly when require-match is nil? That doesn't sound right. > > I'm not an ido user, but testing with > > (require 'ido-ubiquitous) > (ido-ubiquitous-mode 1) > > partial completion seems to work fine when I hit tab after calling > org-agenda-filter-by-tag. Are you using ido-ubiquitous, or are you > using some other package to get ido completion for non-file/buffer > completion? The issue is that that 'tab' is required - in the previous version of org, this was not required and 'enter' would do the completion for you. > > In this particular case, your change looks OK because I think all useful > values should be in the collection. But I don't understand why you're > not able to do partial completion without this change. Are you running > into the same issue everywhere else that completing-read is called with > a nil value for require-match? I haven't checked everywhere else - presumably. > > -- > Kyle --001a11400cae2d5dd9055435f6a8 Content-Type: application/octet-stream; name="0001-completing-read-in-org-agenda-filter-by-tag-complete.patch" Content-Disposition: attachment; filename="0001-completing-read-in-org-agenda-filter-by-tag-complete.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j52osx7x0 RnJvbSAwMDJjODY3NGVjOWRiNTFlZDJjYzE2ZTczYjQzZDAyYWE4NDRlYTAwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYXRoYW5pZWwgRmxhdGggPGZsYXQwMTAzQGdtYWlsLmNvbT4K RGF0ZTogV2VkLCAxMiBKdWwgMjAxNyAxNzoxNTowNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGNv bXBsZXRpbmctcmVhZCBpbiBvcmctYWdlbmRhLWZpbHRlci1ieS10YWcgY29tcGxldGVzCiBwYXJ0 aWFsbHktZW50ZXJlZCBpbnB1dAoKKiBvcmctYWdlbmRhLmVsOgoob3JnLWFnZW5kYS1maWx0ZXIt YnktdGFnKTogcGFzcyB0IHRvIHJlcXVpcmUtbWF0Y2ggYXJndW1lbnQgb2YgY29tcGxldGluZy1y ZWFkLgpUaGlzIGNhdXNlcyBpZG8tbW9kZSB0byBjb21wbGV0ZSB0YWdzIHByb3Blcmx5IHdoZW4g aW5wdXR0aW5nIHBhcnRpYWwgbWF0Y2hlcywgcmF0aGVyCnRoYXQganVzdCBzZW5kaW5nIHRoZSB0 eXBlZCBpbnB1dC4KLS0tCiBsaXNwL29yZy1hZ2VuZGEuZWwgfCAyICstCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL29yZy1h Z2VuZGEuZWwgYi9saXNwL29yZy1hZ2VuZGEuZWwKaW5kZXggOWFjNGY2NS4uMjBkMTI4ZCAxMDA2 NDQKLS0tIGEvbGlzcC9vcmctYWdlbmRhLmVsCisrKyBiL2xpc3Avb3JnLWFnZW5kYS5lbApAQCAt NzQ5Niw3ICs3NDk2LDcgQEAgYWxzbyBwcmVzcyBgLScgb3IgYCsnIHRvIHN3aXRjaCBiZXR3ZWVu IGZpbHRlcmluZyBhbmQgZXhjbHVkaW5nLiIKIAkJICAgIChvcmctZ2xvYmFsLXRhZ3MtY29tcGxl dGlvbi10YWJsZSkpKQogICAgICAgKGxldCAoKGNvbXBsZXRpb24taWdub3JlLWNhc2UgdCkpCiAJ KHNldHEgdGFnIChjb21wbGV0aW5nLXJlYWQKLQkJICAgIlRhZzogIiBvcmctZ2xvYmFsLXRhZ3Mt Y29tcGxldGlvbi10YWJsZSkpKSkKKwkJICAgIlRhZzogIiBvcmctZ2xvYmFsLXRhZ3MtY29tcGxl dGlvbi10YWJsZSBuaWwgdCkpKSkKICAgICAoY29uZAogICAgICAoKGVxIGNoYXIgP1xyKQogICAg ICAgKG9yZy1hZ2VuZGEtZmlsdGVyLXNob3ctYWxsLXRhZykKLS0gCjIuMTAuMSAoQXBwbGUgR2l0 LTc4KQoK --001a11400cae2d5dd9055435f6a8--