From: Bill Wishon <bill@wishon.org>
To: nicholas.dokos@hp.com
Cc: eric.schulte@gmail.com, emacs-orgmode@gnu.org
Subject: Re: Question about adding to inherited properties
Date: Tue, 24 Apr 2012 19:13:04 -0700 [thread overview]
Message-ID: <CAP2uJAvAtU5t-STdb=L3WmMqUtM8yCQwnGEMV7vMeXUPDWBY3g@mail.gmail.com> (raw)
In-Reply-To: <9494.1334894889@alphaville>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
I think I fixed the problem, but in reading up on how to contribute I
haven't gotten git setup yet or the FSF contribution form done. Should I
do that first before sharing the patch with the group?
Meanwhile is there some sort of test suite to ensure contributions don't
break existing features?
~>Bill
On Thu, Apr 19, 2012 at 9:08 PM, Nick Dokos <nicholas.dokos@hp.com> wrote:
> Eric Schulte (cc:ed) implemented accumulating properties with commit
> 3af89e696a32afcc39f2e3bdb6132ac588d530ae. The commit adds a function
> org-update-property-plist which takes care of the '+' case in property
> names. But as you observed, it does not seem to work. I don't really
> understand what should be happening: what I do know is that when
> org-entry-get calls the above function, the props parameter is nil,
> whereas the function expects it to contain the inherited sestting. So it
> may be that the function is expecting something that is not going to
> happen or org-entry-get passes it the wrong thing somehow. I don't know
> which
> one of these two is correct (or perhaps some other thing is wrong), but
> in any case there does seem to be a disconnect.
>
> Nick
>
[-- Attachment #2: Type: text/html, Size: 1542 bytes --]
prev parent reply other threads:[~2012-04-25 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 23:05 Question about adding to inherited properties Bill Wishon
2012-04-20 0:06 ` Bill Wishon
2012-04-20 4:08 ` Nick Dokos
2012-04-25 2:13 ` Bill Wishon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP2uJAvAtU5t-STdb=L3WmMqUtM8yCQwnGEMV7vMeXUPDWBY3g@mail.gmail.com' \
--to=bill@wishon.org \
--cc=emacs-orgmode@gnu.org \
--cc=eric.schulte@gmail.com \
--cc=nicholas.dokos@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).