Re: re-search-forward hang in org-link-search

[Pip Cet <pipcet@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2209 bytes --]

Can you try this patch? That appears to fix the issue here, at least
for this one file, at the cost of yet another shy group added to the
regular expression.

diff --git a/lisp/org.el b/lisp/org.el
index a908d9e..7f46687 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11128,18 +11128,18 @@ of matched result, with is either
`dedicated' or `fuzzy'."
                       "\\[[0-9]*\\(?:%\\|/[0-9]*\\)\\]"
                       wspaceopt
                       "\\)"))
-              (sep (concat "\\(?:" wspace "+\\|" cookie "+\\)"))
+              (sep (concat "\\(?:\\(?:" wspace "\\|" cookie "\\)+\\)"))
               (re (concat
                org-outline-regexp-bol
                "\\(?:" org-todo-regexp "[ \t]+\\)?"
                "\\(?:\\[#.\\][ \t]+\\)?"
                "\\(?:" org-comment-string "[ \t]+\\)?"
-               sep "*"
+               sep "?"
                (let ((title (mapconcat #'regexp-quote
                            words
-                           (concat sep "+"))))
+                           sep)))
                  (if starred (substring title 1) title))
-               sep "*"
+               sep "?"
                (org-re "\\(?:[ \t]+:[[:alnum:]_@#%%:]+:\\)?")
                "[ \t]*$")))
          (goto-char (point-min))

(Sorry if this arrives in duplicate, I had neglected to configure
Gmail to default to reply-to-all behaviour).


On Thu, Aug 13, 2015 at 6:36 PM, Matthew MacLean <archenoth@gmail.com> wrote:
>
> On Thu, Aug 13, 2015 at 12:26 PM, Pip Cet <pipcet@gmail.com> wrote:
>>
>> It's not an Emacs bug. Your regular expression whittles down to:
>>
>> (defvar hang-re "^\\*+ *Mawile\\(?:[ ]+\\)+stuff\\(?:[ ]+\\)*$")
>>
>> or even
>>
>> (defvar hang-re "\\(?:[ ]+\\)+s")
>>
>> That expression matches the string of spaces separating the first
>> Mawhile headline from its tags in many many different ways, and is one
>> of the type of regular expressions warned about in the (Emacs Lisp
>> Reference) manual. We shouldn't be generating it, and it is a bug, but
>> it is in Org, not Emacs.
>
>
> Ah... Well, this is the reason I posted it here first.
>
> In that case, the bug is present as late as
> a97f2c1830910d7a239dcbb98e200a6e4038acaa.

[-- Attachment #2: org-mode-003.diff --]
[-- Type: text/plain, Size: 897 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index a908d9e..7f46687 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11128,18 +11128,18 @@ of matched result, with is either `dedicated' or `fuzzy'."
 				      "\\[[0-9]*\\(?:%\\|/[0-9]*\\)\\]"
 				      wspaceopt
 				      "\\)"))
-		      (sep (concat "\\(?:" wspace "+\\|" cookie "+\\)"))
+		      (sep (concat "\\(?:\\(?:" wspace "\\|" cookie "\\)+\\)"))
 		      (re (concat
 			   org-outline-regexp-bol
 			   "\\(?:" org-todo-regexp "[ \t]+\\)?"
 			   "\\(?:\\[#.\\][ \t]+\\)?"
 			   "\\(?:" org-comment-string "[ \t]+\\)?"
-			   sep "*"
+			   sep "?"
 			   (let ((title (mapconcat #'regexp-quote
 						   words
-						   (concat sep "+"))))
+						   sep)))
 			     (if starred (substring title 1) title))
-			   sep "*"
+			   sep "?"
 			   (org-re "\\(?:[ \t]+:[[:alnum:]_@#%%:]+:\\)?")
 			   "[ \t]*$")))
 		 (goto-char (point-min))