From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0HkUOMvV6WAEEQAAgWs5BA (envelope-from ) for ; Sat, 10 Jul 2021 19:15:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +B+vM8vV6WBPUgAAbx9fmQ (envelope-from ) for ; Sat, 10 Jul 2021 17:15:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 438551F54C for ; Sat, 10 Jul 2021 19:15:55 +0200 (CEST) Received: from localhost ([::1]:57628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2Ga1-0001Iu-GC for larch@yhetil.org; Sat, 10 Jul 2021 13:15:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2GZW-0001Gu-0S for emacs-orgmode@gnu.org; Sat, 10 Jul 2021 13:15:22 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:37419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2GZU-0003Bh-Dd for emacs-orgmode@gnu.org; Sat, 10 Jul 2021 13:15:21 -0400 Received: by mail-lj1-x230.google.com with SMTP id h19so3201990ljl.4 for ; Sat, 10 Jul 2021 10:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yx//GtXzricq8G1Vzbd/iCsmwqHSzmZPfFY1HwAOsd8=; b=nXrWHlQucFsGM1ZblgOVMXZB1kAvOLsYM0s3hMVAFUfWJAx6p2t272z0EMZRX1hlJ2 qbiNQ0JXP4PKqQGyjcGBe7XH/hH9BR8utqsEM5j2vj6XJ6xABRYPvRATIcd1E7+dqqkX LvthIdkKJALfiXEpUdbtBmZzXeHkdAgYeMUQZPBr2L9YhiPmakl5f27F2At9+Qxc5X5j ReTumUwoLfAQHVua16knkYrJX/q92tAnUF1+WqAuLm64/io1WNRjxzZuUFMrS1sLW7qv 8oQD+Z5HfEKlmpOhse0DraOZIeZwpxdKceVCsFPuthlOtRPjQL8/UuY+AcqqhbT0necb WlIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yx//GtXzricq8G1Vzbd/iCsmwqHSzmZPfFY1HwAOsd8=; b=Bmy4HzqW/AU/1Ji3qQYMFVMMONtU00M9HPy4LfhxyT+PkyFBy3bz8drGVlircLwDmK kl/7erGl3NhVMhzeYWCg0XsWSoyKaNOt0tQHhFw4s7UE+cqgPp22wpzLwHnJGLjbL24C DcrSy8BLp8DHTD9K9HRP1jVeqpeAeonkx3oIfAtQjLyiApjzjGIANWsg5IWFgvAS5P1J Y8LKrnCwLY4myq/foV9XOlwARz6wC+v1xA6sr8NGZGUcV/6p5XMo+jijFqQeH35DyDJg 8xWz2j2MXcneqUY7CLCU3jsx5+kva8Zrpljyw4Kg/LHqsbxF8zkm66/jUwgBEHir9FaI Bv7g== X-Gm-Message-State: AOAM532k6ECi9wcbia9h3ez03suvT6HAIqeoAcvGSnNrfl3DJoAso0ZP ZQy03FWgNqVT4lGWIa8Ll2847Ac0/xA9Y9n0yWY= X-Google-Smtp-Source: ABdhPJz1D5TTeMv2EvLFwgt1fsJzOQCDGxHrcyKyg6ZAk4IOU2fPs768v6TzB76GSfK0ze9mz/aiUJ3wVd/wvBVXzRE= X-Received: by 2002:a2e:814c:: with SMTP id t12mr31065880ljg.156.1625937318008; Sat, 10 Jul 2021 10:15:18 -0700 (PDT) MIME-Version: 1.0 References: <877diwbm6a.fsf@gmail.com> <87a6muwa93.fsf@localhost> In-Reply-To: <87a6muwa93.fsf@localhost> From: Bhavin Gandhi Date: Sat, 10 Jul 2021 22:44:41 +0530 Message-ID: Subject: Re: [PATCH] Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] To: Ihor Radchenko Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=bhavin7392@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Gustavo Barros Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625937355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yx//GtXzricq8G1Vzbd/iCsmwqHSzmZPfFY1HwAOsd8=; b=gHTv32gVW+occmfHCBrAcsYKRsC/pihE76mcBZ+vfbmSM4ZuQkGS+zF/g5NcbBilP63K1s 1LNZRfN80w01AWIFf9GTVRNehYq8mveMo7SwyxNrAQgZP8MQit3UXTx7P0bQNOO31x8C0k bmdCNZ6Yq3b/jaPF+WJilzvAU/qOo+K5V9m5djKWpE/Zi2ZwGldixlt0+odsyT0cfb3+GX 1GtAF2qDsXrKoK3jc0wxGemz9qL/f8kc0Z7kUlBUu51itNIwh/3JQaL5L8RgakhN7CToee FSaMh7gYfdV+jBh+T+N/cOgap79zUqAtRUxzJBVJD1Qshg2DdASIcviPol8RjA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625937355; a=rsa-sha256; cv=none; b=FGSELirxr58jwdIVi8Ga2VlzeBdT3O3RBJO2rw2bcWACnf/gNNQBUutgVf/OBIFk1Mul0Z ZgbcvdbLajA4YZljDjQ+UkZPo2aJl+E6sLko0gBHE3AoAQEMUm2b5CcSalVCWeANtcA3Rc z4XXdS3lN2ttGnVFSgZvad9BOH50UCNnTUjOZjFWCg50W31Ps5rpoF4Oa6/gbf5G0emGOS QKC28HQ+bIRZM6tOQdUdlCM19clTl8vZLnnoEtBLORclCS4sFoqmTcwfajzbsR50Dv1uGV QEeKrOFSNxOT/ojWbUtRVXNLaxdeNI2wfjWFe4eaLQyzwy7tOtfY/VF4AmaIPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=nXrWHlQu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=nXrWHlQu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 438551F54C X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: C+GVo6qNuEUF Hello Ihor, On Sat, 10 Jul 2021 at 19:18, Ihor Radchenko wrote: > The breakage was introduced in commit c67037: > > [c670379adfbdc4883d3cfa230289fd2829993265] Fix `org-agenda-todo' undo behavior when logging (not adding note) > > The fix is attached. Thank you! I tried the patch, but the original bug[1] which the commit `c67037' tried to fix, gets introduced again. Basically, `org-agenda-undo' just removes the logbook entry and the scheduled date remains new. [1] https://orgmode.org/list/87v98a8mes.fsf@gnu.org/