From: Adam Porter <adam@alphapapa.net>
To: Bastien <bzg@gnu.org>
Cc: orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [BUG] 81c7a2dee8 misaligns time lines in agenda
Date: Sat, 25 Sep 2021 21:53:15 -0500 [thread overview]
Message-ID: <CAO_b3FU=BASPFqVaGrJkTM5G0-U5B0wrr3ji0A-XuKDO14STWg@mail.gmail.com> (raw)
In-Reply-To: <878rzkcuao.fsf@gnu.org>
Hi Bastien,
On Sat, Sep 25, 2021 at 2:46 PM Bastien <bzg@gnu.org> wrote:
> > Since Bastien made this change, and it's very simple, I'm guessing he'll
> > know what the proper fix is. :)
>
> The change I made was superceded by Nicolas series of patches:
>
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/?qt=grep&q=fix+org-duration-to-minutes+error
Oops, thanks. I found your commit by searching the log, but I should
have checked blame on the code to see if it had been changed since
then.
> I agree the new alignment looks wrong: the starting time should
> bit right-aligned with other time above/below, and the separating
> dash should not spaces for "HH:MM" time strings on the right, but
> only for " H:MM".
>
> Would you have time to prepare a patch for this?
Unfortunately, I'm unable to reproduce it on my system, even using Org
9.4.6 in a clean Emacs config. For some reason, it only seems to
happen on the org-super-agenda repo's GitHub Actions CI (which tests
on Emacs 26.3, 27.1, and snapshot versions). So I'm not sure what's
going on. :( Hopefully Nicolas's changes solve the problem for Org
9.5 (if the problem is really one after all).
prev parent reply other threads:[~2021-09-26 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 23:00 [BUG] 81c7a2dee8 misaligns time lines in agenda Adam Porter
2021-09-25 19:46 ` Bastien
2021-09-26 2:53 ` Adam Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO_b3FU=BASPFqVaGrJkTM5G0-U5B0wrr3ji0A-XuKDO14STWg@mail.gmail.com' \
--to=adam@alphapapa.net \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).