From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitri Makarov Subject: Re: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat. Date: Thu, 10 Sep 2015 12:26:34 +0200 Message-ID: References: <87lhcesiky.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1130ce2291475d051f62088b Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZz3w-0002NX-Ni for emacs-orgmode@gnu.org; Thu, 10 Sep 2015 06:26:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZz3t-00009N-EG for emacs-orgmode@gnu.org; Thu, 10 Sep 2015 06:26:40 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:33945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZz3t-00007j-4q for emacs-orgmode@gnu.org; Thu, 10 Sep 2015 06:26:37 -0400 Received: by wicfx3 with SMTP id fx3so22245326wic.1 for ; Thu, 10 Sep 2015 03:26:36 -0700 (PDT) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com. [209.85.212.171]) by smtp.gmail.com with ESMTPSA id nf15sm1068155wic.22.2015.09.10.03.26.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2015 03:26:35 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so17420862wic.0 for ; Thu, 10 Sep 2015 03:26:34 -0700 (PDT) In-Reply-To: <87lhcesiky.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Dmitri Makarov , Alan Schmitt , emacs-orgmode@gnu.org --001a1130ce2291475d051f62088b Content-Type: text/plain; charset=UTF-8 Attached is the patch with requested corrections. I hope now this small patch is sufficiently well commented. Regards, Dmitri On Thu, Sep 10, 2015 at 11:57 AM, Nicolas Goaziou wrote: > Hello, > > Dmitri Makarov writes: > >> If you haven't pushed the patch yet, here is attached an updated >> patch, with a correction in the commit message, and a minor correction >> in one of the comments. > > Thank you. Some comments follow. > >> > On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt wrote: > >>> LGTM (with a tiny caveat that I can fix: the first line of the commit >>> message should not end with a dot). Nicolas, can I push this? > > Sure. However, it would be nice to fix the two minor issues below. > >> From: Dmitri Makarov >> Date: Wed, 9 Sep 2015 17:24:42 +0200 >> Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat >> >> * contrib/lisp/org-mac-link.el: Add new link type "acrobat" to grab >> links to documents open in Adobe Acrobat application. > > You need to mention new functions and variables in the commit message. > >> +(defun as-get-acrobat-page-link () > > Wrong namespace. It should be prefixed with "org-mac-". > > > Regards, > > -- > Nicolas Goaziou --001a1130ce2291475d051f62088b Content-Type: text/plain; charset=US-ASCII; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iee2k38o0 RnJvbSBhZGEzZTlhZmJjYWRiNjAyMGI4ZTQ5NDliNDlhZmMxMjQzZjgyNzhkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEbWl0cmkgTWFrYXJvdiA8ZG1ha2Fyb3ZAYWx1bW5pLnN0YW5m b3JkLmVkdT4KRGF0ZTogV2VkLCA5IFNlcCAyMDE1IDE3OjI0OjQyICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gb3JnLW1hYy1saW5rLmVsOiBIYW5kbGUgbGlua3MgdG8vZnJvbSBBZG9iZSBBY3JvYmF0 CgpBZGQgbmV3IGxpbmsgdHlwZSAiYWNyb2JhdCIgdG8gZ3JhYiBsaW5rcyB0byBkb2N1bWVudHMg b3BlbiBpbiBBZG9iZQpBY3JvYmF0IGFwcGxpY2F0aW9uLgoKKiBjb250cmliL2xpc3Avb3JnLW1h Yy1saW5rLmVsIChvcmctbWFjLWFjcm9iYXQtb3Blbik6IE9wZW4gQWRvYmUKICBBY3JvYmF0IGRv Y3VtZW50IHBvaW50ZWQgdG8gYnkgYSBsaW5rLgoqIGNvbnRyaWIvbGlzcC9vcmctbWFjLWxpbmsu ZWwgKG9yZy1tYWMtYXMtZ2V0LWFjcm9iYXQtcGFnZS1saW5rKToKICBJbnZva2UgYXBwbGVzY3Jp cHQgdG8gZ2VuZXJhdGUgYSBsaW5rIHRvIGFuIG9wZW4gYW5kIGFjdGl2ZSBBZG9iZQogIEFjcm9i YXQgZG9jdW1lbnQuCiogY29udHJpYi9saXNwL29yZy1tYWMtbGluay5lbCAob3JnLW1hYy1hY3Jv YmF0LWdldC1wYWdlLAogIG9yZy1tYWMtYWNyb2JhdC1pbnNlcnQtcGFnZSk6IG1ldGhvZHMgdXNl ZCB3aGVuIGFuIEFkb2JlIEFjcm9iYXQgbGluawogIGdyYWIgcmVxdWVzdCBpcyBpc3N1ZWQgb3Ig YSBsaW5rIGlzIGNsaWNrZWQgaW4gYW4gb3JnIGRvY3VtZW50LgoqIGNvbnRyaWIvbGlzcC9vcmct bWFjLWxpbmsuZWwgKG9yZy1tYWMtZ3JhYi1BY3JvYmF0LWFwcC1wKTogcHJlZGljYXRlCiAgdGhh dCBlbmFibGVzIGdyYWJiaW5nIEFkb2JlIEFjcm9iYXQgbGlua3MuCi0tLQogY29udHJpYi9saXNw L29yZy1tYWMtbGluay5lbCB8IDYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2NvbnRyaWIvbGlzcC9vcmctbWFjLWxpbmsuZWwgYi9jb250cmliL2xp c3Avb3JnLW1hYy1saW5rLmVsCmluZGV4IDVlMGY4OTEuLjAxNTU2ZjcgMTAwNjQ0Ci0tLSBhL2Nv bnRyaWIvbGlzcC9vcmctbWFjLWxpbmsuZWwKKysrIGIvY29udHJpYi9saXNwL29yZy1tYWMtbGlu ay5lbApAQCAtMTY5LDYgKzE2OSwxMiBAQAogICA6Z3JvdXAgJ29yZy1tYWMtbGluawogICA6dHlw ZSAnYm9vbGVhbikKIAorKGRlZmN1c3RvbSBvcmctbWFjLWdyYWItQWNyb2JhdC1hcHAtcCB0Cisg ICJBZGQgbWVudSBvcHRpb24gW0FdY3JvYmF0IHRvIGdyYWIgcGFnZSBsaW5rcyBmcm9tIEFjcm9i YXQuYXBwLiIKKyAgOnRhZyAiR3JhYiBBY3JvYmF0LmFwcCBwYWdlIGxpbmtzIgorICA6Z3JvdXAg J29yZy1tYWMtbGluaworICA6dHlwZSAnYm9vbGVhbikKKwogKGRlZmdyb3VwIG9yZy1tYWMtZmxh Z2dlZC1tYWlsIG5pbAogICAiT3B0aW9ucyBmb3JpbmcgbGlua2luZyB0byBmbGFnZ2VkIE1haWwu YXBwIG1lc3NhZ2VzLiIKICAgOnRhZyAiT3JnIE1haWwuYXBwIgpAQCAtMjExLDcgKzIxNyw4IEBA IFdoZW4gZG9uZSwgZ28gZ3JhYiB0aGUgbGluaywgYW5kIGluc2VydCBpdCBhdCBwb2ludC4iCiAJ ICAgICgidiIgImltcGVyYXRvciIgb3JnLW1hYy12aW1wZXJhdG9yLWluc2VydC1mcm9udG1vc3Qt dXJsICxvcmctbWFjLWdyYWItRmlyZWZveCtWaW1wZXJhdG9yLXApCiAJICAgICgiYyIgImhyb21l IiBvcmctbWFjLWNocm9tZS1pbnNlcnQtZnJvbnRtb3N0LXVybCAsb3JnLW1hYy1ncmFiLUNocm9t ZS1hcHAtcCkKIAkgICAgKCJ0IiAib2dldGhlciIgb3JnLW1hYy10b2dldGhlci1pbnNlcnQtc2Vs ZWN0ZWQgLG9yZy1tYWMtZ3JhYi1Ub2dldGhlci1hcHAtcCkKLQkgICAgKCJTIiAia2ltIiBvcmct bWFjLXNraW0taW5zZXJ0LXBhZ2UgLG9yZy1tYWMtZ3JhYi1Ta2ltLWFwcC1wKSkpCisJICAgICgi UyIgImtpbSIgb3JnLW1hYy1za2ltLWluc2VydC1wYWdlICxvcmctbWFjLWdyYWItU2tpbS1hcHAt cCkKKwkgICAgKCJBIiAiY3JvYmF0IiBvcmctbWFjLWFjcm9iYXQtaW5zZXJ0LXBhZ2UgLG9yZy1t YWMtZ3JhYi1BY3JvYmF0LWFwcC1wKSkpCiAgICAgICAgICAobWVudS1zdHJpbmcgKG1ha2Utc3Ry aW5nIDAgP3gpKQogICAgICAgICAgaW5wdXQpCiAKQEAgLTU0Myw2ICs1NTAsNTcgQEAgVGhlIGxp bmtzIGFyZSBvZiB0aGUgZm9ybSA8bGluaz46OnNwbGl0Ojo8bmFtZT4uIgogICAoaW50ZXJhY3Rp dmUpCiAgIChpbnNlcnQgKG9yZy1tYWMtc2tpbS1nZXQtcGFnZSkpKQogCis7OyBIYW5kbGUgbGlu a3MgZnJvbSBBZG9iZSBBY3JvYmF0IFByby5hcHAKKzs7Cis7OyBPcmlnaW5hbCBjb2RlICYgaWRl YSBieSBDaHJpc3RvcGhlciBTdWNrbGluZyAob3JnLW1hYy1wcm90b2NvbCkKKzs7Cis7OyBUaGUg VVJJIGZvcm1hdCBpcyBwYXRoX3RvX3BkZl9maWxlOjpwYWdlX251bWJlcgorCisob3JnLWFkZC1s aW5rLXR5cGUgImFjcm9iYXQiICdvcmctbWFjLWFjcm9iYXQtb3BlbikKKworKGRlZnVuIG9yZy1t YWMtYWNyb2JhdC1vcGVuICh1cmkpCisgICJWaXNpdCBwYWdlIG9mIHBkZiBpbiBBY3JvYmF0Igor ICAobGV0KiAoKHBhZ2UgKHdoZW4gKHN0cmluZy1tYXRjaCAiOjpcXCguK1xcKVxcJyIgdXJpKQor ICAgICAgICAgICAgICAgICAobWF0Y2gtc3RyaW5nIDEgdXJpKSkpCisgICAgICAgICAoZG9jdW1l bnQgKHN1YnN0cmluZyB1cmkgMCAobWF0Y2gtYmVnaW5uaW5nIDApKSkpCisgICAgKGRvLWFwcGxl c2NyaXB0CisgICAgIChjb25jYXQKKyAgICAgICJ0ZWxsIGFwcGxpY2F0aW9uIFwiQWRvYmUgQWNy b2JhdCBQcm9cIlxuIgorICAgICAgIiAgYWN0aXZhdGVcbiIKKyAgICAgICIgIHNldCB0aGVEb2Mg dG8gXCIiIGRvY3VtZW50ICJcIlxuIgorICAgICAgIiAgc2V0IHRoZVBhZ2UgdG8gIiBwYWdlICJc biIKKyAgICAgICIgIG9wZW4gdGhlRG9jXG4iCisgICAgICAiICB0ZWxsIFBERiBXaW5kb3cgMVxu IgorICAgICAgIiAgICBnb3RvIHBhZ2UgdGhlUGFnZVxuIgorICAgICAgIiAgZW5kIHRlbGxcbiIK KyAgICAgICJlbmQgdGVsbCIpKSkpCisKKzs7IFRoZSBhcHBsZXNjcmlwdCByZXR1cm5zIGxpbmsg aW4gdGhlIGZvcm1hdAorOzsgImFkb2JlOnBhdGhfdG9fcGRmX2ZpbGU6OnBhZ2VfbnVtYmVyOjpz cGxpdDo6ZG9jdW1lbnRfdGl0bGUsIHAucGFnZV9sYWJlbCIKKworKGRlZnVuIG9yZy1tYWMtYXMt Z2V0LWFjcm9iYXQtcGFnZS1saW5rICgpCisgIChkby1hcHBsZXNjcmlwdAorICAgKGNvbmNhdAor ICAgICJ0ZWxsIGFwcGxpY2F0aW9uIFwiQWRvYmUgQWNyb2JhdCBQcm9cIlxuIgorICAgICIgIHNl dCB0aGVEb2MgdG8gYWN0aXZlIGRvY1xuIgorICAgICIgIHNldCB0aGVXaW5kb3cgdG8gKFBERiBX aW5kb3cgMSBvZiB0aGVEb2MpXG4iCisgICAgIiAgc2V0IHRoZVBhdGggdG8gKGZpbGUgYWxpYXMg b2YgdGhlRG9jKVxuIgorICAgICIgIHNldCB0aGVUaXRsZSB0byAobmFtZSBvZiB0aGVXaW5kb3cp XG4iCisgICAgIiAgc2V0IHRoZVBhZ2UgdG8gKHBhZ2UgbnVtYmVyIG9mIHRoZVdpbmRvdylcbiIK KyAgICAiICBzZXQgdGhlTGFiZWwgdG8gKGxhYmVsIHRleHQgb2YgKHBhZ2UgdGhlUGFnZSBvZiB0 aGVXaW5kb3cpKVxuIgorICAgICJlbmQgdGVsbFxuIgorICAgICJzZXQgdGhlUmVzdWx0IHRvIFwi YWNyb2JhdDpcIiAmIHRoZVBhdGggJiBcIjo6XCIgJiB0aGVQYWdlICYgXCI6OnNwbGl0OjpcIiAm IHRoZVRpdGxlICYgXCIsIHAuXCIgJiB0aGVMYWJlbFxuIgorICAgICJyZXR1cm4gdGhlUmVzdWx0 IGFzIHN0cmluZ1xuIikpKQorCisoZGVmdW4gb3JnLW1hYy1hY3JvYmF0LWdldC1wYWdlICgpCisg IChpbnRlcmFjdGl2ZSkKKyAgKG1lc3NhZ2UgIkFwcGxlc2NyaXB0OiBHZXR0aW5nIEFjcm9iYXQg cGFnZSBsaW5rLi4uIikKKyAgKG9yZy1tYWMtcGFzdGUtYXBwbGVzY3JpcHQtbGlua3MgKG9yZy1t YWMtYXMtZ2V0LWFjcm9iYXQtcGFnZS1saW5rKSkpCisKKyhkZWZ1biBvcmctbWFjLWFjcm9iYXQt aW5zZXJ0LXBhZ2UgKCkKKyAgKGludGVyYWN0aXZlKQorICAoaW5zZXJ0IChvcmctbWFjLWFjcm9i YXQtZ2V0LXBhZ2UpKSkKKwogDAogOzsgSGFuZGxlIGxpbmtzIGZyb20gTWljcm9zb2Z0IE91dGxv b2suYXBwCiAKLS0gCjIuNS4xCgo= --001a1130ce2291475d051f62088b--