Error when using org-ctrl-c-ctrl-c to add tags

Error when using org-ctrl-c-ctrl-c to add tags

[Vicente Vera]

Hello. This shows up when trying to add tags to a headline with
org-ctrl-c-ctrl-c:

apply: Wrong type argument: listp, org-tags-completion-function

Org-mode version 8.3beta (release_8.3beta-1045-gd8494b @
/usr/local/share/emacs/site-lisp/org/)
GNU Emacs 24.5.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2)

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Rasmus]

Hi Vicenet,

Vicente Vera <vicentemvp@gmail.com> writes:

> Hello. This shows up when trying to add tags to a headline with
> org-ctrl-c-ctrl-c:
>
> apply: Wrong type argument: listp, org-tags-completion-function

I can't reproduce by clicking C-c C-c on a headline.  Can you be more
specific as to how you trigger the error?  Do you see it when you start
Emacs via emacs -q?

Thanks,
Rasmus

-- 
Need more coffee. . .

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Vicente Vera]

Hi.
Don't think there are more details to provide. The error message
appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
on a headline, doesn't matter which level.
It happened in 3 different Org files, one of which was created for testing.
Also tried with "emacs -q" but the error persisted.

Strange message though, org-tags-completion-function is a function,
not a variable, so why is Emacs complaining that it isn't a list?
Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Marc Ihm]

Vicente Vera <vicentemvp@gmail.com> writes:

> Hi.
> Don't think there are more details to provide. The error message
> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
> on a headline, doesn't matter which level.
> It happened in 3 different Org files, one of which was created for testing.
> Also tried with "emacs -q" but the error persisted.
>
> Strange message though, org-tags-completion-function is a function,
> not a variable, so why is Emacs complaining that it isn't a list?
> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?

I see this error too; the patch below fixes it for me (and corrects the
nexting level of 'completing-read too ...)

best regards
Marc


diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,10 +10512,11 @@ from."
                  (listp (second args)))
             'org-iswitchb-completing-read)
            (t (or (and (boundp 'completing-read-function)
-                       completing-read-function)
-                  'completing-read)))
+                       completing-read-function))
+              'completing-read))
       (concat (car args))
-      (if (consp (car (nth 1 args)))
+      (if (and (consp (nth 1 args))
+              (consp (car (nth 1 args))))
          (mapcar 'car (nth 1 args))
        (nth 1 args))
       (cddr args)))))

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Rasmus]

Hi Marc (and Vincent),

Marc Ihm <marc@ihm.name> writes:

> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> Don't think there are more details to provide. The error message
>> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
>> on a headline, doesn't matter which level.
>> It happened in 3 different Org files, one of which was created for testing.
>> Also tried with "emacs -q" but the error persisted.

Thanks for confirming.

>> Strange message though, org-tags-completion-function is a function,
>> not a variable, so why is Emacs complaining that it isn't a list?
>> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
>
> I see this error too; the patch below fixes it for me (and corrects the
> nexting level of 'completing-read too ...)

Thanks for confirming.  Do you (also) see it when starting Emacs with
"emacs -q", as Vincent?

Finally, can you repost post the patch via git am against master?

Thanks,
Rasmus

-- 
Summon the Mothership!

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Vicente Vera]

Hello Marc. Yes, upon further inspection it seems the problem is in
org-icompleting-read. This function is complaining that
org-tags-completion--function---one of its arguments---is not a list.

2015-04-19 11:36 GMT-03:00 Marc Ihm <marc@ihm.name>:
> Vicente Vera <vicentemvp@gmail.com> writes:
>
>> Hi.
>> Don't think there are more details to provide. The error message
>> appears upon pressing C-c C-c (bound to the org-ctrl-c-ctrl-c command)
>> on a headline, doesn't matter which level.
>> It happened in 3 different Org files, one of which was created for testing.
>> Also tried with "emacs -q" but the error persisted.
>>
>> Strange message though, org-tags-completion-function is a function,
>> not a variable, so why is Emacs complaining that it isn't a list?
>> Probably related to commit acf7f47ecd20a48c05f97dc660b00d1850b57e10?
>
> I see this error too; the patch below fixes it for me (and corrects the
> nexting level of 'completing-read too ...)
>
> best regards
> Marc
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 8a00847..f440382 100755
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10512,10 +10512,11 @@ from."
>                   (listp (second args)))
>              'org-iswitchb-completing-read)
>             (t (or (and (boundp 'completing-read-function)
> -                       completing-read-function)
> -                  'completing-read)))
> +                       completing-read-function))
> +              'completing-read))
>        (concat (car args))
> -      (if (consp (car (nth 1 args)))
> +      (if (and (consp (nth 1 args))
> +              (consp (car (nth 1 args))))
>           (mapcar 'car (nth 1 args))
>         (nth 1 args))
>        (cddr args)))))

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Marc Ihm]

Okay, this one only tries to fix, what seems broken ...
Could someone please check ?

best regards
Marc


diff --git a/lisp/org.el b/lisp/org.el
index 24b3a69..8a00847 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10515,8 +10515,7 @@ from."
                        completing-read-function)
                   'completing-read)))
       (concat (car args))
-      (if (and (consp (nth 1 args))
-              (consp (car (nth 1 args))))
+      (if (consp (car (nth 1 args)))
          (mapcar 'car (nth 1 args))
        (nth 1 args))
       (cddr args)))))

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Vicente Vera]

Worked for me.

2015-04-19 13:05 GMT-03:00 Marc Ihm <marc@ihm.name>:
>
> Okay, this one only tries to fix, what seems broken ...
> Could someone please check ?
>
> best regards
> Marc
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 24b3a69..8a00847 100755
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10515,8 +10515,7 @@ from."
>                         completing-read-function)
>                    'completing-read)))
>        (concat (car args))
> -      (if (and (consp (nth 1 args))
> -              (consp (car (nth 1 args))))
> +      (if (consp (car (nth 1 args)))
>           (mapcar 'car (nth 1 args))
>         (nth 1 args))
>        (cddr args)))))

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Rasmus]

Hi,

Marc Ihm <marc@ihm.name> writes:

> Okay, this one only tries to fix, what seems broken ...
> Could someone please check ?

Please run pull the latest version and create your patch using git am.

I still don't know how to reproduce the error.  I have tried with Emacs
24.4 and the git version.

Combining your two diffs I get:

diff --git a/lisp/org.el b/lisp/org.el
index 8a00847..f440382 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10512,11 +10512,11 @@ from."
                  (listp (second args)))
             'org-iswitchb-completing-read)
            (t (or (and (boundp 'completing-read-function)
-                       completing-read-function)
-                  'completing-read)))
+                       completing-read-function))
+              'completing-read))
       (concat (car args))

which seems wrong (notice that the or becomes irrelevant).

What is completing-read-function?

Thanks,
Rasmus

-- 
You people at the NSA are becoming my new best friends!

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Rasmus]

Hi,

Rasmus <rasmus@gmx.us> writes:

> I still don't know how to reproduce the error.  I have tried with Emacs
> 24.4 and the git version.

Sorry for the noise.  This should be fixed now.

Thanks,
Rasmus

-- 
I feel emotional landscapes they puzzle me

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Marc Ihm]

Works for me too, and probably better than my suggestion :-)

best regards
Marc

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Ken Mankoff]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi,

I'm still experiencing this bug, although with a slightly different error
message. When "C-c C-c" on a headline, I see:

org-set-tags: Wrong type argument: listp, org-tags-completion-function

Compared to the original report of:

apply: Wrong type argument: listp, org-tags-completion-function

I'm running latest git head:
Org-mode version 8.3beta (release_8.3beta-1078-gd13a2b @
/Users/mankoff/local/src/org-mode/lisp/)


  -k.



On Mon, Apr 20, 2015 at 4:02 PM, Marc Ihm <marc@ihm.name> wrote:

> Works for me too, and probably better than my suggestion :-)
>
> best regards
> Marc
>
>

[-- Attachment #2: Type: text/html, Size: 2070 bytes --]

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Rasmus]

Ken Mankoff <mankoff@gmail.com> writes:

> I'm still experiencing this bug, although with a slightly different error
> message. When "C-c C-c" on a headline, I see:
>
> org-set-tags: Wrong type argument: listp, org-tags-completion-function

Do you see this from emacs -q?  If not, how can I get to the state where
this happens from emacs -q?

Thanks,
Rasmus

-- 
Warning: Everything saved will be lost

Re: Error when using org-ctrl-c-ctrl-c to add tags

[Ken Mankoff]

On 2015-04-27 at 04:26, Rasmus <rasmus@gmx.us> wrote:
> Ken Mankoff <mankoff@gmail.com> writes:
>
>> I'm still experiencing this bug, although with a slightly different error
>> message. When "C-c C-c" on a headline, I see:
>>
>> org-set-tags: Wrong type argument: listp, org-tags-completion-function
>
> Do you see this from emacs -q?  If not, how can I get to the state where
> this happens from emacs -q?

A "make clean" before "make autoloads" fixed it.

Sorry for the noise,

  -k.