From: Miro Bezjak <bezjak.miro@gmail.com>
To: Teika Kazura <teika@gmx.com>,
emacs-orgmode@gnu.org, me <bezjak.miro@gmail.com>
Subject: Re: Bug (regression) in org-replace-disputed-keys. Bisected.
Date: Fri, 14 Nov 2014 23:29:43 +0100 [thread overview]
Message-ID: <CAMJqDfP0GD0MTZLDrxrFwQDO-9b+UvPzHMUuRB_HpZdVsvtRug@mail.gmail.com> (raw)
In-Reply-To: <87fve0c8dp.fsf@nicolasgoaziou.fr>
Hi all,
I rather like that `org-read-date` takes over windmove keys during the
second or two that I'm using it. By reverting this, I guess I'll have
to copy and paste the whole `defvar` just to add
`(org-replace-disputed-keys nil)`.
May I make a compromise here? Can we make a new defcustom
(org-disable-disputed-keys-during-read-date?) that will disable
`org-replace-disputed-keys` when setting up
`org-read-date-minibuffer-local-map`?
Regards,
Miro
On Mon, Nov 3, 2014 at 9:54 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Teika Kazura <teika@gmx.com> writes:
>
>> Now a real fix. There're two candidates:
>>
>> (i) Revert the wrong commit. Since it was in fact done in two separate commits[2], you need another patch, not git-revert. Here it is:
>> ------------------------------------------------------------------------
>> diff -u -r org-8.2.7c-orig/lisp/org.el org-8.2.7c/lisp/org.el
>> --- org-8.2.7c-orig/lisp/org.el 2014-09-30 18:10:54.485977061 +0900
>> +++ org-8.2.7c/lisp/org.el 2014-09-30 18:11:24.293602328 +0900
>> @@ -16220,8 +16220,7 @@
>> (defvar org-read-date-inactive)
>>
>> (defvar org-read-date-minibuffer-local-map
>> - (let* ((org-replace-disputed-keys nil)
>> - (map (make-sparse-keymap)))
>> + (let* ((map (make-sparse-keymap)))
>> (set-keymap-parent map minibuffer-local-map)
>> (org-defkey map (kbd ".")
>> (lambda () (interactive)
>> ------------------------------------------------------------------------
>
> I think this change is appropriate. Could you provide a patch with git
> format-patch?
>
>
> Regards,
>
> --
> Nicolas Goaziou
next prev parent reply other threads:[~2014-11-14 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 11:42 Bug (regression) in org-replace-disputed-keys. Bisected Teika Kazura
2014-09-28 20:07 ` Nicolas Goaziou
2014-10-01 1:22 ` Teika Kazura
2014-11-03 20:54 ` Nicolas Goaziou
2014-11-12 11:49 ` [patch] " Teika Kazura
2014-11-13 22:32 ` Nicolas Goaziou
2014-11-14 22:29 ` Miro Bezjak [this message]
2014-11-18 21:32 ` Nicolas Goaziou
2014-11-19 9:50 ` Miro Bezjak
-- strict thread matches above, loose matches on Subject: below --
2014-09-17 8:42 Teika Kazura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMJqDfP0GD0MTZLDrxrFwQDO-9b+UvPzHMUuRB_HpZdVsvtRug@mail.gmail.com \
--to=bezjak.miro@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=teika@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).