From mboxrd@z Thu Jan  1 00:00:00 1970
From: Noam Postavsky <npostavs@gmail.com>
Subject: Re: Fontification error
Date: Sun, 19 Mar 2017 14:04:49 -0400
Message-ID: <CAM-tV--Zzsa_tZkUj4a=VWMMRj=GA1osreRfck4jD22tmDt+7A@mail.gmail.com>
References: <CAHyO48wTnPsmWx4F1PLWNQA504dpMRrRX_EGb_gjf=KOQNnSRg@mail.gmail.com>
	<87r31trybx.fsf@kyleam.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <npostavs@gmail.com>) id 1cpfCF-0006RZ-LD
	for emacs-orgmode@gnu.org; Sun, 19 Mar 2017 14:04:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <npostavs@gmail.com>) id 1cpfCE-00075L-J5
	for emacs-orgmode@gnu.org; Sun, 19 Mar 2017 14:04:51 -0400
Received: from mail-ot0-x236.google.com ([2607:f8b0:4003:c0f::236]:35001)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <npostavs@gmail.com>) id 1cpfCE-00074y-Dd
	for emacs-orgmode@gnu.org; Sun, 19 Mar 2017 14:04:50 -0400
Received: by mail-ot0-x236.google.com with SMTP id x37so121096462ota.2
	for <emacs-orgmode@gnu.org>; Sun, 19 Mar 2017 11:04:50 -0700 (PDT)
In-Reply-To: <87r31trybx.fsf@kyleam.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org, Aaron Jensen <aaronjensen@gmail.com>

On Sun, Mar 19, 2017 at 1:05 PM, Kyle Meyer <kyle@kyleam.com> wrote:
>>
>>     * lisp/org-src.el (org-src-font-lock-fontify-block): Let-bind
>>     `inhibit-modification-hooks' to nil, since this function can be called
>>     from jit-lock-function which binds that variable to t (Bug#25132).
>>
>>     Call modification hooks in org-src fontify buffers
>>     ae8264c5cccf19d5b25a340a605bf2f07de1577e
>>     Noam Postavsky
>>     Sun Jan 29 11:01:32 2017 -0500
>>
>> At the moment, the minimum ECM I know of is to install spacemacs and
>> open an org file containing:
>
> [+cc Noam because I'm not sure if he follows this list.]

[Thanks, I don't follow this list indeed]

>
> I backported this commit to the Org repo, but I don't have any good
> guesses at what's leading to the error below.

I think the problem is that the let-binding's scope is too big, it's
applying to a text property change on the original org buffer, which
seems to cause problems with one of its modifcation hooks due to
narrowing. Actually, I initially posted the patch with a smaller
binding, but then enlarged it before I pushed it; I don't remember
why...

Could someone who can reproduce this problem try shrinking the scope
of (let ((inhibit-modification-hooks nil))...) to stop after the
(insert " ") as in [1], and see if that fixes it?

[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25132;att=3;filename=v1-0001-Call-modification-hooks-in-org-src-fontify-buffer.patch;msg=22