From mboxrd@z Thu Jan 1 00:00:00 1970 From: Puneeth Chaganti Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed. Date: Sat, 24 Oct 2015 10:59:31 +0530 Message-ID: References: <874mhh1u7s.fsf@gmx.us> <87oafpz65e.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZprOr-0000zS-20 for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 01:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZprOp-0001ae-Tv for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 01:29:52 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:32955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZprOp-0001Zz-O2 for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 01:29:51 -0400 Received: by wijp11 with SMTP id p11so101941187wij.0 for ; Fri, 23 Oct 2015 22:29:51 -0700 (PDT) In-Reply-To: <87oafpz65e.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode Hi Rasmus, On Sat, Oct 24, 2015 at 1:52 AM, Rasmus wrote: > Hi Puneeth, > > Thanks for the followup. > > Puneeth Chaganti writes: > >> On Fri, Oct 23, 2015 at 8:57 PM, Rasmus wrote: >>> It's not obvious that org should change a=E2=80=94potentially=E2=80=94c= arefully selected >>> narrowed region. >> >> I agree. But, am I not explicitly asking to jump to the specified >> item. I don't mind the widening, at least when the call is >> interactive. I agree with you when some other code is calling it, >> though. > > I see your point, but I also remember being quite annoyed in the past whe= n > I lost my narrow because of e.g. inserting a footnote. I see. >>> Perhaps you could mimic the way org-edit-special works for this case. >> >> You mean, display the entry in a new buffer, and any changes will be >> applied onto the original entry too? > > Yeah, I would prefer that. Would that work for you or would still prefer > to have your buffer widened? I agree that widening a buffer that was narrowed on purpose can be annoying, sometimes. Most times, I think I wouldn't mind the widening. That said, I'm not quite sure what is the right fix for this. I find it weird to have a subtly different thing happening depending on whether or not the target buffer is narrowed -- entry shown in normal buffer when no narrowing vs. entry shown in a special/indirect buffer. Also, given that no other part of org really uses indirect buffers, I don't know if this function alone should make use of that feature. Let me know what you think. -- Puneeth PS: I've patched my org sources to do indirect buffers for this, and will try it out for sometime to see how it feels.